Re: [PATCHv3 RFC] uio: add generic driver for PCI 2.3 devices

2009-07-15 Thread Chris Wright
* Michael S. Tsirkin (m...@redhat.com) wrote: > Right. Note that the limitation that only a single thread should touch > config space through sysfs applies to any sub-byte field. If we wanted > to make such ops atomic, pci devices would need some kind of compare and > swap ioctl. > Looks good. A

Re: [PATCHv3 RFC] uio: add generic driver for PCI 2.3 devices

2009-07-14 Thread Michael S. Tsirkin
On Tue, Jul 14, 2009 at 04:25:07PM -0700, Chris Wright wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Tue, Jul 14, 2009 at 11:03:38AM -0700, Chris Wright wrote: > > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > > - remove irqcontrol: user can enable interrupts by > > > > wr

Re: [PATCHv3 RFC] uio: add generic driver for PCI 2.3 devices

2009-07-14 Thread Chris Wright
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Tue, Jul 14, 2009 at 11:03:38AM -0700, Chris Wright wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > - remove irqcontrol: user can enable interrupts by > > > writing command register directly > > > > Sorry if I gave you the impress

Re: [PATCHv3 RFC] uio: add generic driver for PCI 2.3 devices

2009-07-14 Thread Michael S. Tsirkin
On Tue, Jul 14, 2009 at 11:03:38AM -0700, Chris Wright wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > - remove irqcontrol: user can enable interrupts by > > writing command register directly > > Sorry if I gave you the impression that removing was needed. > I actually think the irqco

Re: [PATCHv3 RFC] uio: add generic driver for PCI 2.3 devices

2009-07-14 Thread Chris Wright
* Michael S. Tsirkin (m...@redhat.com) wrote: > - remove irqcontrol: user can enable interrupts by > writing command register directly Sorry if I gave you the impression that removing was needed. I actually think the irqcontrol was useful since it's atomic. > + gdev->info.name = "uio_pci_ge