Re: [PATCH v3 11/19] KVM: MMU: filter out the mmio pfn from the fault pfn

2011-07-06 Thread Xiao Guangrong
On 07/07/2011 01:17 AM, Marcelo Tosatti wrote: >> +int is_mmio_pfn(pfn_t pfn) >> +{ >> +return pfn == bad_pfn; >> +} >> +EXPORT_SYMBOL_GPL(is_mmio_pfn); > > Please use another name this conflicts with real mmio pfn, > see kvm_is_mmio_pfn. "noslot_pfn" is meaningful to me. > OK, will fix, t

Re: [PATCH v3 11/19] KVM: MMU: filter out the mmio pfn from the fault pfn

2011-07-06 Thread Marcelo Tosatti
On Thu, Jun 30, 2011 at 04:24:06PM +0800, Xiao Guangrong wrote: > If the page fault is caused by mmio, the gfn can not be found in memslots, and > 'bad_pfn' is returned on gfn_to_hva path, so we can use 'bad_pfn' to identify > the mmio page fault. > And, to clarify the meaning of mmio pfn, we retur