Re: [PATCH v2 1/6] kvm: Pass kvm_irqfd to functions

2012-06-29 Thread Alex Williamson
On Thu, 2012-06-28 at 11:38 +0300, Michael S. Tsirkin wrote: > On Wed, Jun 27, 2012 at 04:24:30PM +0200, Cornelia Huck wrote: > > On Tue, 26 Jun 2012 23:09:04 -0600 > > Alex Williamson wrote: > > > > > Prune this down to just the struct kvm_irqfd so we can avoid > > > changing function definition

Re: [PATCH v2 1/6] kvm: Pass kvm_irqfd to functions

2012-06-28 Thread Michael S. Tsirkin
On Thu, Jun 28, 2012 at 06:51:09PM +0200, Cornelia Huck wrote: > On Thu, 28 Jun 2012 15:09:49 +0300 > "Michael S. Tsirkin" wrote: > > > On Thu, Jun 28, 2012 at 02:00:41PM +0200, Cornelia Huck wrote: > > > On Thu, 28 Jun 2012 12:34:43 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Thu,

Re: [PATCH v2 1/6] kvm: Pass kvm_irqfd to functions

2012-06-28 Thread Cornelia Huck
On Thu, 28 Jun 2012 15:09:49 +0300 "Michael S. Tsirkin" wrote: > On Thu, Jun 28, 2012 at 02:00:41PM +0200, Cornelia Huck wrote: > > On Thu, 28 Jun 2012 12:34:43 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Jun 28, 2012 at 11:03:16AM +0200, Cornelia Huck wrote: > > > > > > How about

Re: [PATCH v2 1/6] kvm: Pass kvm_irqfd to functions

2012-06-28 Thread Michael S. Tsirkin
On Thu, Jun 28, 2012 at 02:00:41PM +0200, Cornelia Huck wrote: > On Thu, 28 Jun 2012 12:34:43 +0300 > "Michael S. Tsirkin" wrote: > > > On Thu, Jun 28, 2012 at 11:03:16AM +0200, Cornelia Huck wrote: > > > > How about something like this as parameter for the new ioctl? > > > > > > struct kvm_irq

Re: [PATCH v2 1/6] kvm: Pass kvm_irqfd to functions

2012-06-28 Thread Cornelia Huck
On Thu, 28 Jun 2012 12:34:43 +0300 "Michael S. Tsirkin" wrote: > On Thu, Jun 28, 2012 at 11:03:16AM +0200, Cornelia Huck wrote: > > How about something like this as parameter for the new ioctl? > > > > struct kvm_irqfd2 { > > __u32 fd; > > __u32 flags; /* for things like deassign */ >

Re: [PATCH v2 1/6] kvm: Pass kvm_irqfd to functions

2012-06-28 Thread Michael S. Tsirkin
On Thu, Jun 28, 2012 at 11:03:16AM +0200, Cornelia Huck wrote: > On Thu, 28 Jun 2012 11:38:57 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Jun 27, 2012 at 04:24:30PM +0200, Cornelia Huck wrote: > > > On Tue, 26 Jun 2012 23:09:04 -0600 > > > Alex Williamson wrote: > > > > > > > Prune this d

Re: [PATCH v2 1/6] kvm: Pass kvm_irqfd to functions

2012-06-28 Thread Cornelia Huck
On Thu, 28 Jun 2012 11:38:57 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jun 27, 2012 at 04:24:30PM +0200, Cornelia Huck wrote: > > On Tue, 26 Jun 2012 23:09:04 -0600 > > Alex Williamson wrote: > > > > > Prune this down to just the struct kvm_irqfd so we can avoid > > > changing function defini

Re: [PATCH v2 1/6] kvm: Pass kvm_irqfd to functions

2012-06-28 Thread Michael S. Tsirkin
On Wed, Jun 27, 2012 at 04:24:30PM +0200, Cornelia Huck wrote: > On Tue, 26 Jun 2012 23:09:04 -0600 > Alex Williamson wrote: > > > Prune this down to just the struct kvm_irqfd so we can avoid > > changing function definition for every flag or field we use. > > > > Signed-off-by: Alex Williamson

Re: [PATCH v2 1/6] kvm: Pass kvm_irqfd to functions

2012-06-27 Thread Alex Williamson
On Wed, 2012-06-27 at 12:35 +0300, Michael S. Tsirkin wrote: > On Tue, Jun 26, 2012 at 11:09:04PM -0600, Alex Williamson wrote: > > Prune this down to just the struct kvm_irqfd so we can avoid > > changing function definition for every flag or field we use. > > > > Signed-off-by: Alex Williamson

Re: [PATCH v2 1/6] kvm: Pass kvm_irqfd to functions

2012-06-27 Thread Cornelia Huck
On Tue, 26 Jun 2012 23:09:04 -0600 Alex Williamson wrote: > Prune this down to just the struct kvm_irqfd so we can avoid > changing function definition for every flag or field we use. > > Signed-off-by: Alex Williamson I'm currently trying to find a way to make irqfd workable for s390 which wi

Re: [PATCH v2 1/6] kvm: Pass kvm_irqfd to functions

2012-06-27 Thread Michael S. Tsirkin
On Tue, Jun 26, 2012 at 11:09:04PM -0600, Alex Williamson wrote: > Prune this down to just the struct kvm_irqfd so we can avoid > changing function definition for every flag or field we use. > > Signed-off-by: Alex Williamson This is not needed anymore, right? We are not adding new fields. > --