Re: [PATCH v2] MMIO: Make coalesced mmio use a device per zone

2012-02-12 Thread Amos Kong
- Original Message - > - Original Message - > > On 07/19/2011 02:05 PM, Sasha Levin wrote: > > > On Tue, 2011-07-19 at 13:57 +0300, Avi Kivity wrote: > > > > On 07/19/2011 01:31 PM, Sasha Levin wrote: > > > > > This patch changes coalesced mmio to create one mmio device > > > >

Re: [PATCH v2] MMIO: Make coalesced mmio use a device per zone

2011-12-21 Thread Amos Kong
- Original Message - > On 07/19/2011 02:05 PM, Sasha Levin wrote: > > On Tue, 2011-07-19 at 13:57 +0300, Avi Kivity wrote: > > > On 07/19/2011 01:31 PM, Sasha Levin wrote: > > > > This patch changes coalesced mmio to create one mmio device > > > > per > > > > zone instead of handling

Re: [PATCH v2] MMIO: Make coalesced mmio use a device per zone

2011-07-19 Thread Avi Kivity
On 07/19/2011 03:34 PM, Sasha Levin wrote: > > btw, don't we leak all zones on guest destruction? the array didn't need > any cleanup, but this list does. > No, the destructor is called for all devices on the bus when the bus is going down. We're handling it in coalesced_mmio_destructor() whic

Re: [PATCH v2] MMIO: Make coalesced mmio use a device per zone

2011-07-19 Thread Sasha Levin
On Tue, 2011-07-19 at 15:24 +0300, Avi Kivity wrote: > On 07/19/2011 02:05 PM, Sasha Levin wrote: > > On Tue, 2011-07-19 at 13:57 +0300, Avi Kivity wrote: > > > On 07/19/2011 01:31 PM, Sasha Levin wrote: > > > > This patch changes coalesced mmio to create one mmio device per > > > > zone inste

Re: [PATCH v2] MMIO: Make coalesced mmio use a device per zone

2011-07-19 Thread Avi Kivity
On 07/19/2011 02:05 PM, Sasha Levin wrote: On Tue, 2011-07-19 at 13:57 +0300, Avi Kivity wrote: > On 07/19/2011 01:31 PM, Sasha Levin wrote: > > This patch changes coalesced mmio to create one mmio device per > > zone instead of handling all zones in one device. > > > > Doing so enables u

Re: [PATCH v2] MMIO: Make coalesced mmio use a device per zone

2011-07-19 Thread Sasha Levin
On Tue, 2011-07-19 at 13:57 +0300, Avi Kivity wrote: > On 07/19/2011 01:31 PM, Sasha Levin wrote: > > This patch changes coalesced mmio to create one mmio device per > > zone instead of handling all zones in one device. > > > > Doing so enables us to take advantage of existing locking and prevents

Re: [PATCH v2] MMIO: Make coalesced mmio use a device per zone

2011-07-19 Thread Avi Kivity
On 07/19/2011 01:31 PM, Sasha Levin wrote: This patch changes coalesced mmio to create one mmio device per zone instead of handling all zones in one device. Doing so enables us to take advantage of existing locking and prevents a race condition between coalesced mmio registration/unregistration