RE: [PATCH v11 8/8] PPC: Don't use hardcoded opcode for ePAPR hcall invocation

2012-07-03 Thread Yoder Stuart-B08248
> -Original Message- > From: Wood Scott-B07421 > Sent: Monday, July 02, 2012 12:25 PM > To: Alexander Graf > Cc: Yoder Stuart-B08248; kvm-...@vger.kernel.org; kvm@vger.kernel.org; Tabi > Timur-B04825 > Subject: Re: [PATCH v11 8/8] PPC: Don't use hardco

Re: [PATCH v11 8/8] PPC: Don't use hardcoded opcode for ePAPR hcall invocation

2012-07-02 Thread Timur Tabi
Scott Wood wrote: >> > So are you saying that it was wrong before, but it's correct now? > Not really *wrong* before, but unnecessary. In that case, my code was really just ahead of its time. :-) -- Timur Tabi Linux kernel developer at Freescale -- To unsubscribe from this list: send the line

Re: [PATCH v11 8/8] PPC: Don't use hardcoded opcode for ePAPR hcall invocation

2012-07-02 Thread Scott Wood
On 07/02/2012 12:53 PM, Timur Tabi wrote: > Scott Wood wrote: I'm still a little confused. Which inline assembly code is clobbering LR? Are you talking about the "BL" instruction, which wasn't there before? > >> Yes, I didn't realize that LR had been in the clobber list before that. >

Re: [PATCH v11 8/8] PPC: Don't use hardcoded opcode for ePAPR hcall invocation

2012-07-02 Thread Timur Tabi
Scott Wood wrote: >> > I'm still a little confused. Which inline assembly code is clobbering LR? >> > Are you talking about the "BL" instruction, which wasn't there before? > Yes, I didn't realize that LR had been in the clobber list before that. So are you saying that it was wrong before, but

Re: [PATCH v11 8/8] PPC: Don't use hardcoded opcode for ePAPR hcall invocation

2012-07-02 Thread Scott Wood
On 07/02/2012 12:34 PM, Timur Tabi wrote: > Scott Wood wrote: > >> Hmm. The comment says, "XER, CTR, and LR are currently listed as >> clobbers because it's uncertain whether they will be clobbered." Maybe >> it dates back to when the ABI was still being discussed? Timur, do you >> recall? > >

Re: [PATCH v11 8/8] PPC: Don't use hardcoded opcode for ePAPR hcall invocation

2012-07-02 Thread Timur Tabi
Scott Wood wrote: > Hmm. The comment says, "XER, CTR, and LR are currently listed as > clobbers because it's uncertain whether they will be clobbered." Maybe > it dates back to when the ABI was still being discussed? Timur, do you > recall? Nope, sorry. I'm sure we discussed this and looked a

Re: [PATCH v11 8/8] PPC: Don't use hardcoded opcode for ePAPR hcall invocation

2012-07-02 Thread Scott Wood
On 07/02/2012 07:30 AM, Alexander Graf wrote: > > On 22.06.2012, at 22:06, Stuart Yoder wrote: > >> From: Liu Yu-B13201 >> >> Signed-off-by: Liu Yu >> Signed-off-by: Stuart Yoder >> --- >> -v11: no changes >> >> arch/powerpc/include/asm/epapr_hcalls.h | 22 +- >> arch/powerpc/

Re: [PATCH v11 8/8] PPC: Don't use hardcoded opcode for ePAPR hcall invocation

2012-07-02 Thread Scott Wood
On 07/02/2012 12:17 PM, Alexander Graf wrote: > > On 02.07.2012, at 19:16, Scott Wood wrote: > >> On 07/02/2012 12:13 PM, Alexander Graf wrote: >>> >>> On 02.07.2012, at 19:10, Scott Wood wrote: >>> On 07/02/2012 07:30 AM, Alexander Graf wrote: > > On 22.06.2012, at 22:06, Stuart Yod

Re: [PATCH v11 8/8] PPC: Don't use hardcoded opcode for ePAPR hcall invocation

2012-07-02 Thread Alexander Graf
On 02.07.2012, at 19:16, Scott Wood wrote: > On 07/02/2012 12:13 PM, Alexander Graf wrote: >> >> On 02.07.2012, at 19:10, Scott Wood wrote: >> >>> On 07/02/2012 07:30 AM, Alexander Graf wrote: On 22.06.2012, at 22:06, Stuart Yoder wrote: > From: Liu Yu-B13201 > >

Re: [PATCH v11 8/8] PPC: Don't use hardcoded opcode for ePAPR hcall invocation

2012-07-02 Thread Scott Wood
On 07/02/2012 12:13 PM, Alexander Graf wrote: > > On 02.07.2012, at 19:10, Scott Wood wrote: > >> On 07/02/2012 07:30 AM, Alexander Graf wrote: >>> >>> On 22.06.2012, at 22:06, Stuart Yoder wrote: >>> From: Liu Yu-B13201 Signed-off-by: Liu Yu Signed-off-by: Stuart Yoder >>>

Re: [PATCH v11 8/8] PPC: Don't use hardcoded opcode for ePAPR hcall invocation

2012-07-02 Thread Alexander Graf
On 02.07.2012, at 19:10, Scott Wood wrote: > On 07/02/2012 07:30 AM, Alexander Graf wrote: >> >> On 22.06.2012, at 22:06, Stuart Yoder wrote: >> >>> From: Liu Yu-B13201 >>> >>> Signed-off-by: Liu Yu >>> Signed-off-by: Stuart Yoder >>> --- >>> -v11: no changes >>> >>> arch/powerpc/include/a

Re: [PATCH v11 8/8] PPC: Don't use hardcoded opcode for ePAPR hcall invocation

2012-07-02 Thread Alexander Graf
On 22.06.2012, at 22:06, Stuart Yoder wrote: > From: Liu Yu-B13201 > > Signed-off-by: Liu Yu > Signed-off-by: Stuart Yoder > --- > -v11: no changes > > arch/powerpc/include/asm/epapr_hcalls.h | 22 +- > arch/powerpc/include/asm/fsl_hcalls.h | 36 +++--