Re: [PATCH V7 4/4 net-next] vhost: vhost TX zero-copy support

2011-07-06 Thread Shirley Ma
On Wed, 2011-06-29 at 12:13 +0300, Michael S. Tsirkin wrote: > On Sat, May 28, 2011 at 12:34:27PM -0700, Shirley Ma wrote: > > Hello Michael, > > > > In order to use wait for completion in shutting down, seems to me > > another work thread is needed to call vhost_zerocopy_add_used, > > Hmm I don'

Re: [PATCH V7 4/4 net-next] vhost: vhost TX zero-copy support

2011-06-30 Thread Shirley Ma
On Wed, 2011-06-29 at 12:13 +0300, Michael S. Tsirkin wrote: > Assuming you mean vhost_zerocopy_signal_used, here's how I would do > it: > add a kref and a completion, signal completion in kref_put > callback, when backend is set - kref_get, on cleanup, > kref_put and then wait_for_completion_inter

Re: [PATCH V7 4/4 net-next] vhost: vhost TX zero-copy support

2011-06-29 Thread Michael S. Tsirkin
On Sat, May 28, 2011 at 12:34:27PM -0700, Shirley Ma wrote: > Hello Michael, > > In order to use wait for completion in shutting down, seems to me > another work thread is needed to call vhost_zerocopy_add_used, Hmm I don't see vhost_zerocopy_add_used here. > it seems > too much work to address