Re: [PATCH RFC] virtio-net: remove useless disable on freeze

2012-05-31 Thread Michael S. Tsirkin
On Thu, May 31, 2012 at 11:47:17AM +0300, Michael S. Tsirkin wrote: > On Thu, May 31, 2012 at 06:35:08PM +1000, Stephen Rothwell wrote: > > Hi all, > > > > On Wed, 30 May 2012 19:41:47 +0930 Rusty Russell > > wrote: > > > > > > On Mon, 28 May 2012 15:53:25 +0300, "Michael S. Tsirkin" > > > wro

Re: [PATCH RFC] virtio-net: remove useless disable on freeze

2012-05-31 Thread Michael S. Tsirkin
On Thu, May 31, 2012 at 06:35:08PM +1000, Stephen Rothwell wrote: > Hi all, > > On Wed, 30 May 2012 19:41:47 +0930 Rusty Russell > wrote: > > > > On Mon, 28 May 2012 15:53:25 +0300, "Michael S. Tsirkin" > > wrote: > > > On Wed, Apr 04, 2012 at 12:19:54PM +0300, Michael S. Tsirkin wrote: > > >

Re: [PATCH RFC] virtio-net: remove useless disable on freeze

2012-05-31 Thread Stephen Rothwell
Hi all, On Wed, 30 May 2012 19:41:47 +0930 Rusty Russell wrote: > > On Mon, 28 May 2012 15:53:25 +0300, "Michael S. Tsirkin" > wrote: > > On Wed, Apr 04, 2012 at 12:19:54PM +0300, Michael S. Tsirkin wrote: > > > disable_cb is just an optimization: it > > > can not guarantee that there are no ca

Re: [PATCH RFC] virtio-net: remove useless disable on freeze

2012-05-30 Thread Rusty Russell
On Mon, 28 May 2012 15:53:25 +0300, "Michael S. Tsirkin" wrote: > On Wed, Apr 04, 2012 at 12:19:54PM +0300, Michael S. Tsirkin wrote: > > disable_cb is just an optimization: it > > can not guarantee that there are no callbacks. > > > > I didn't yet figure out whether a callback > > in freeze wil

Re: [PATCH RFC] virtio-net: remove useless disable on freeze

2012-05-28 Thread Michael S. Tsirkin
On Wed, Apr 04, 2012 at 12:19:54PM +0300, Michael S. Tsirkin wrote: > disable_cb is just an optimization: it > can not guarantee that there are no callbacks. > > I didn't yet figure out whether a callback > in freeze will trigger a bug, but disable_cb > won't address it in any case. So let's remov

Re: [PATCH RFC] virtio-net: remove useless disable on freeze

2012-05-03 Thread Michael S. Tsirkin
On Thu, May 03, 2012 at 04:29:59PM +0530, Amit Shah wrote: > On (Wed) 04 Apr 2012 [12:19:55], Michael S. Tsirkin wrote: > > disable_cb is just an optimization: it > > can not guarantee that there are no callbacks. > > Even then, what's the harm in keeping it? If indeed there's an > attempt to rai

Re: [PATCH RFC] virtio-net: remove useless disable on freeze

2012-05-03 Thread Amit Shah
On (Wed) 04 Apr 2012 [12:19:55], Michael S. Tsirkin wrote: > disable_cb is just an optimization: it > can not guarantee that there are no callbacks. Even then, what's the harm in keeping it? If indeed there's an attempt to raise an interrupt after the host has been notified, it will be suppressed