Re: [PATCH 4/4] Convert irq notifiers lists to RCU locking.

2009-07-14 Thread Gleb Natapov
On Tue, Jul 14, 2009 at 05:03:09AM -0700, Paul E. McKenney wrote: > On Tue, Jul 14, 2009 at 08:46:12AM +0300, Gleb Natapov wrote: > > On Mon, Jul 13, 2009 at 12:31:39PM -0700, Paul E. McKenney wrote: > > > On Mon, Jul 13, 2009 at 04:40:59PM +0300, Michael S. Tsirkin wrote: > > > > On Mon, Jul 13, 2

Re: [PATCH 4/4] Convert irq notifiers lists to RCU locking.

2009-07-14 Thread Paul E. McKenney
On Tue, Jul 14, 2009 at 08:46:12AM +0300, Gleb Natapov wrote: > On Mon, Jul 13, 2009 at 12:31:39PM -0700, Paul E. McKenney wrote: > > On Mon, Jul 13, 2009 at 04:40:59PM +0300, Michael S. Tsirkin wrote: > > > On Mon, Jul 13, 2009 at 04:32:34PM +0300, Gleb Natapov wrote: > > > > Yeah I understand tha

Re: [PATCH 4/4] Convert irq notifiers lists to RCU locking.

2009-07-13 Thread Gleb Natapov
On Mon, Jul 13, 2009 at 12:31:39PM -0700, Paul E. McKenney wrote: > On Mon, Jul 13, 2009 at 04:40:59PM +0300, Michael S. Tsirkin wrote: > > On Mon, Jul 13, 2009 at 04:32:34PM +0300, Gleb Natapov wrote: > > > Yeah I understand that other RCU read section may introduce delays too. > > > The question

Re: [PATCH 4/4] Convert irq notifiers lists to RCU locking.

2009-07-13 Thread Paul E. McKenney
On Mon, Jul 13, 2009 at 04:40:59PM +0300, Michael S. Tsirkin wrote: > On Mon, Jul 13, 2009 at 04:32:34PM +0300, Gleb Natapov wrote: > > Yeah I understand that other RCU read section may introduce delays too. > > The question is how big the delay may be. > > I recall seeing the number "at least 3 j

Re: [PATCH 4/4] Convert irq notifiers lists to RCU locking.

2009-07-13 Thread Gleb Natapov
On Mon, Jul 13, 2009 at 10:02:13AM -0400, Gregory Haskins wrote: > Gleb Natapov wrote: > > On Mon, Jul 13, 2009 at 09:40:01AM -0400, Gregory Haskins wrote: > > > >> Gleb Natapov wrote: > >> > >>> On Mon, Jul 13, 2009 at 09:26:21AM -0400, Gregory Haskins wrote: > >>> > >>> > G

Re: [PATCH 4/4] Convert irq notifiers lists to RCU locking.

2009-07-13 Thread Gregory Haskins
Gleb Natapov wrote: > On Mon, Jul 13, 2009 at 09:40:01AM -0400, Gregory Haskins wrote: > >> Gleb Natapov wrote: >> >>> On Mon, Jul 13, 2009 at 09:26:21AM -0400, Gregory Haskins wrote: >>> >>> Gleb Natapov wrote: > On Mon, Jul 13, 2009 at 04:02:56PM

Re: [PATCH 4/4] Convert irq notifiers lists to RCU locking.

2009-07-13 Thread Gleb Natapov
On Mon, Jul 13, 2009 at 09:40:01AM -0400, Gregory Haskins wrote: > Gleb Natapov wrote: > > On Mon, Jul 13, 2009 at 09:26:21AM -0400, Gregory Haskins wrote: > > > >> Gleb Natapov wrote: > >> > >>> On Mon, Jul 13, 2009 at 04:02:56PM +0300, Michael S. Tsirkin wrote: > >>> > >>> > >>>

Re: [PATCH 4/4] Convert irq notifiers lists to RCU locking.

2009-07-13 Thread Gregory Haskins
Michael S. Tsirkin wrote: > On Sun, Jul 12, 2009 at 03:03:53PM +0300, Gleb Natapov wrote: > >> Use RCU locking for mask/ack notifiers lists. >> >> Signed-off-by: Gleb Natapov >> --- >> virt/kvm/irq_comm.c | 20 +++- >> 1 files changed, 11 insertions(+), 9 deletions(-) >> >> d

Re: [PATCH 4/4] Convert irq notifiers lists to RCU locking.

2009-07-13 Thread Gregory Haskins
Michael S. Tsirkin wrote: > On Mon, Jul 13, 2009 at 04:32:34PM +0300, Gleb Natapov wrote: > >> Yeah I understand that other RCU read section may introduce delays too. >> The question is how big the delay may be. >> > > I recall seeing the number "at least 3 jiffies" somewhere, but that > mi

Re: [PATCH 4/4] Convert irq notifiers lists to RCU locking.

2009-07-13 Thread Michael S. Tsirkin
On Mon, Jul 13, 2009 at 04:32:34PM +0300, Gleb Natapov wrote: > Yeah I understand that other RCU read section may introduce delays too. > The question is how big the delay may be. I recall seeing the number "at least 3 jiffies" somewhere, but that might have changed since. > I don't think multipl

Re: [PATCH 4/4] Convert irq notifiers lists to RCU locking.

2009-07-13 Thread Gregory Haskins
Gleb Natapov wrote: > On Mon, Jul 13, 2009 at 09:26:21AM -0400, Gregory Haskins wrote: > >> Gleb Natapov wrote: >> >>> On Mon, Jul 13, 2009 at 04:02:56PM +0300, Michael S. Tsirkin wrote: >>> >>> On Sun, Jul 12, 2009 at 03:03:53PM +0300, Gleb Natapov wrote:

Re: [PATCH 4/4] Convert irq notifiers lists to RCU locking.

2009-07-13 Thread Gleb Natapov
On Mon, Jul 13, 2009 at 09:26:21AM -0400, Gregory Haskins wrote: > Gleb Natapov wrote: > > On Mon, Jul 13, 2009 at 04:02:56PM +0300, Michael S. Tsirkin wrote: > > > >> On Sun, Jul 12, 2009 at 03:03:53PM +0300, Gleb Natapov wrote: > >> > >>> Use RCU locking for mask/ack notifiers lists. > >>

Re: [PATCH 4/4] Convert irq notifiers lists to RCU locking.

2009-07-13 Thread Michael S. Tsirkin
On Mon, Jul 13, 2009 at 04:05:58PM +0300, Gleb Natapov wrote: > On Mon, Jul 13, 2009 at 03:56:40PM +0300, Michael S. Tsirkin wrote: > > On Sun, Jul 12, 2009 at 03:03:53PM +0300, Gleb Natapov wrote: > > > Use RCU locking for mask/ack notifiers lists. > > > > > > Signed-off-by: Gleb Natapov > > > -

Re: [PATCH 4/4] Convert irq notifiers lists to RCU locking.

2009-07-13 Thread Gregory Haskins
Gleb Natapov wrote: > On Mon, Jul 13, 2009 at 04:02:56PM +0300, Michael S. Tsirkin wrote: > >> On Sun, Jul 12, 2009 at 03:03:53PM +0300, Gleb Natapov wrote: >> >>> Use RCU locking for mask/ack notifiers lists. >>> >>> Signed-off-by: Gleb Natapov >>> --- >>> virt/kvm/irq_comm.c | 20

Re: [PATCH 4/4] Convert irq notifiers lists to RCU locking.

2009-07-13 Thread Gleb Natapov
On Mon, Jul 13, 2009 at 04:02:56PM +0300, Michael S. Tsirkin wrote: > On Sun, Jul 12, 2009 at 03:03:53PM +0300, Gleb Natapov wrote: > > Use RCU locking for mask/ack notifiers lists. > > > > Signed-off-by: Gleb Natapov > > --- > > virt/kvm/irq_comm.c | 20 +++- > > 1 files chang

Re: [PATCH 4/4] Convert irq notifiers lists to RCU locking.

2009-07-13 Thread Gleb Natapov
On Mon, Jul 13, 2009 at 03:56:40PM +0300, Michael S. Tsirkin wrote: > On Sun, Jul 12, 2009 at 03:03:53PM +0300, Gleb Natapov wrote: > > Use RCU locking for mask/ack notifiers lists. > > > > Signed-off-by: Gleb Natapov > > --- > > virt/kvm/irq_comm.c | 20 +++- > > 1 files chang

Re: [PATCH 4/4] Convert irq notifiers lists to RCU locking.

2009-07-13 Thread Michael S. Tsirkin
On Sun, Jul 12, 2009 at 03:03:53PM +0300, Gleb Natapov wrote: > Use RCU locking for mask/ack notifiers lists. > > Signed-off-by: Gleb Natapov > --- > virt/kvm/irq_comm.c | 20 +++- > 1 files changed, 11 insertions(+), 9 deletions(-) > > diff --git a/virt/kvm/irq_comm.c b/virt/

Re: [PATCH 4/4] Convert irq notifiers lists to RCU locking.

2009-07-13 Thread Michael S. Tsirkin
On Sun, Jul 12, 2009 at 03:03:53PM +0300, Gleb Natapov wrote: > Use RCU locking for mask/ack notifiers lists. > > Signed-off-by: Gleb Natapov > --- > virt/kvm/irq_comm.c | 20 +++- > 1 files changed, 11 insertions(+), 9 deletions(-) > > diff --git a/virt/kvm/irq_comm.c b/virt/