Re: [PATCH 3/5] watchdog: fix print-once on enable

2014-08-18 Thread Don Zickus
On Mon, Aug 18, 2014 at 11:07:57AM +0200, Ingo Molnar wrote: > > * Don Zickus wrote: > > > --- a/kernel/watchdog.c > > +++ b/kernel/watchdog.c > > @@ -522,6 +522,9 @@ static void watchdog_nmi_disable(unsigned int cpu) > > /* should be in cleanup, but blocks oprofile */ > >

Re: [PATCH 3/5] watchdog: fix print-once on enable

2014-08-18 Thread Ingo Molnar
* Don Zickus wrote: > --- a/kernel/watchdog.c > +++ b/kernel/watchdog.c > @@ -522,6 +522,9 @@ static void watchdog_nmi_disable(unsigned int cpu) > /* should be in cleanup, but blocks oprofile */ > perf_event_release_kernel(event); > } > + if (cpu == 0) > +

Re: [PATCH 3/5] watchdog: fix print-once on enable

2014-08-18 Thread Ingo Molnar
* Don Zickus wrote: > From: Ulrich Obergfell > > This patch avoids printing the message 'enabled on all CPUs, ...' > multiple times. For example, the issue can occur in the following > scenario: > > 1) watchdog_nmi_enable() fails to enable PMU counters and sets >cpu0_err. > > 2) 'echo [0