Re: [PATCH 2/5 V5] Add functions to check if the host has stopped the vm

2011-12-14 Thread Eric B Munson
On Wed, 14 Dec 2011, Avi Kivity wrote: > On 12/14/2011 07:11 PM, Eric B Munson wrote: > > > > > > > > > > If I understand (please correct me if this is wrong) because this is > > > > > only > > > > > called from the watchdog, which disables preemption, we should be > > > > > protected > > > > >

Re: [PATCH 2/5 V5] Add functions to check if the host has stopped the vm

2011-12-14 Thread Avi Kivity
On 12/14/2011 07:11 PM, Eric B Munson wrote: > > > > > > > > If I understand (please correct me if this is wrong) because this is > > > > only > > > > called from the watchdog, which disables preemption, we should be > > > > protected > > > > from something else writing to these flags. > > > > >

Re: [PATCH 2/5 V5] Add functions to check if the host has stopped the vm

2011-12-14 Thread Eric B Munson
On Wed, 14 Dec 2011, Avi Kivity wrote: > On 12/14/2011 02:11 PM, Marcelo Tosatti wrote: > > On Thu, Dec 08, 2011 at 10:23:10AM -0500, Eric B Munson wrote: > > > On Wed, 07 Dec 2011, Avi Kivity wrote: > > > > > > > On 12/05/2011 10:19 PM, Eric B Munson wrote: > > > > > When a host stops or suspend

Re: [PATCH 2/5 V5] Add functions to check if the host has stopped the vm

2011-12-14 Thread Avi Kivity
On 12/14/2011 02:11 PM, Marcelo Tosatti wrote: > On Thu, Dec 08, 2011 at 10:23:10AM -0500, Eric B Munson wrote: > > On Wed, 07 Dec 2011, Avi Kivity wrote: > > > > > On 12/05/2011 10:19 PM, Eric B Munson wrote: > > > > When a host stops or suspends a VM it will set a flag to show this. The > > > >

Re: [PATCH 2/5 V5] Add functions to check if the host has stopped the vm

2011-12-14 Thread Marcelo Tosatti
On Thu, Dec 08, 2011 at 10:23:10AM -0500, Eric B Munson wrote: > On Wed, 07 Dec 2011, Avi Kivity wrote: > > > On 12/05/2011 10:19 PM, Eric B Munson wrote: > > > When a host stops or suspends a VM it will set a flag to show this. The > > > watchdog will use these functions to determine if a softlo

Re: [PATCH 2/5 V5] Add functions to check if the host has stopped the vm

2011-12-08 Thread Eric B Munson
On Wed, 07 Dec 2011, Avi Kivity wrote: > On 12/05/2011 10:19 PM, Eric B Munson wrote: > > When a host stops or suspends a VM it will set a flag to show this. The > > watchdog will use these functions to determine if a softlockup is real, or > > the > > result of a suspended VM. > > > > +bool k

Re: [PATCH 2/5 V5] Add functions to check if the host has stopped the vm

2011-12-07 Thread Avi Kivity
On 12/05/2011 10:19 PM, Eric B Munson wrote: > When a host stops or suspends a VM it will set a flag to show this. The > watchdog will use these functions to determine if a softlockup is real, or the > result of a suspended VM. > > +bool kvm_check_and_clear_guest_paused(int cpu) > +{ > + boo