Re: [PATCH 2/4] KVM: SVM: use NPT page attributes

2015-07-16 Thread Paolo Bonzini
On 17/07/2015 02:35, Andy Lutomirski wrote: > >> Right now, NPT page attributes are not used, and the final page >> attribute depends solely on gPAT (which however is not synced >> correctly), the guest MTRRs and the guest page attributes. >> >> However, we can do better by mimicking what is don

Re: [PATCH 2/4] KVM: SVM: use NPT page attributes

2015-07-16 Thread Andy Lutomirski
On 07/07/2015 06:45 AM, Paolo Bonzini wrote: Right now, NPT page attributes are not used, and the final page attribute depends solely on gPAT (which however is not synced correctly), the guest MTRRs and the guest page attributes. However, we can do better by mimicking what is done for VMX. In th

Re: [PATCH 2/4] KVM: SVM: use NPT page attributes

2015-07-10 Thread Xiao Guangrong
On 07/10/2015 06:47 PM, Paolo Bonzini wrote: On 10/07/2015 03:19, Xiao Guangrong wrote: yes, this is correct. QEMU still does not have support for disabling "quirks", so gCR0.CD is currently hidden on SVM. I would like to include this series in 4.2, while for 4.3 I will disable the quirk a

Re: [PATCH 2/4] KVM: SVM: use NPT page attributes

2015-07-10 Thread Paolo Bonzini
On 10/07/2015 03:19, Xiao Guangrong wrote: >> yes, this is correct. QEMU still does not have support for disabling >> "quirks", so gCR0.CD is currently hidden on SVM. I would like to >> include this series in 4.2, while for 4.3 I will disable the quirk above >> altogether (it is superseded by t

Re: [PATCH 2/4] KVM: SVM: use NPT page attributes

2015-07-09 Thread Xiao Guangrong
On 07/09/2015 11:18 PM, Paolo Bonzini wrote: On 09/07/2015 04:30, Xiao Guangrong wrote: diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index 602b974a60a6..0f125c1860ec 100644 --- a/arch/x86/kvm/svm.c +++ b/arch/x86/kvm/svm.c @@ -1085,6 +1085,47 @@ static u64 svm_compute_tsc_offset(stru

Re: [PATCH 2/4] KVM: SVM: use NPT page attributes

2015-07-09 Thread Paolo Bonzini
On 09/07/2015 04:30, Xiao Guangrong wrote: diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index 602b974a60a6..0f125c1860ec 100644 --- a/arch/x86/kvm/svm.c +++ b/arch/x86/kvm/svm.c @@ -1085,6 +1085,47 @@ static u64 svm_compute_tsc_offset(struct kvm_vcpu *vcpu, u

Re: [PATCH 2/4] KVM: SVM: use NPT page attributes

2015-07-08 Thread Xiao Guangrong
On 07/08/2015 07:19 PM, Paolo Bonzini wrote: On 08/07/2015 07:59, Xiao Guangrong wrote: On 07/07/2015 09:45 PM, Paolo Bonzini wrote: Right now, NPT page attributes are not used, and the final page attribute depends solely on gPAT (which however is not synced correctly), the guest MTRRs an

Re: [PATCH 2/4] KVM: SVM: use NPT page attributes

2015-07-08 Thread Paolo Bonzini
On 08/07/2015 07:59, Xiao Guangrong wrote: > > > On 07/07/2015 09:45 PM, Paolo Bonzini wrote: >> Right now, NPT page attributes are not used, and the final page >> attribute depends solely on gPAT (which however is not synced >> correctly), the guest MTRRs and the guest page attributes. >> >> H

Re: [PATCH 2/4] KVM: SVM: use NPT page attributes

2015-07-07 Thread Xiao Guangrong
On 07/07/2015 09:45 PM, Paolo Bonzini wrote: Right now, NPT page attributes are not used, and the final page attribute depends solely on gPAT (which however is not synced correctly), the guest MTRRs and the guest page attributes. However, we can do better by mimicking what is done for VMX. In