Re: [PATCH 2/2] pci-assign: Fix MSI-X registration

2011-10-10 Thread Avi Kivity
On 09/22/2011 12:04 PM, Jan Kiszka wrote: > goto out; > > +if (!kvm_check_extension(kvm_state, KVM_CAP_ASSIGN_DEV_IRQ)&& > +(dev->cap.available& ASSIGNED_DEVICE_CAP_MSIX || > + dev->cap.available& ASSIGNED_DEVICE_CAP_MSI || > + assigned_dev_pci_read_byt

Re: [PATCH 2/2] pci-assign: Fix MSI-X registration

2011-09-22 Thread Jan Kiszka
On 2011-09-22 05:12, Alex Williamson wrote: > Commit c4525754 added a capability check for KVM_CAP_DEVICE_MSIX, > which is unfortunately not exposed, resulting in MSIX never > being listed as a capability. Oops. Should we fix this nevertheless in the kernel? > This breaks anything depending on >