RE: [PATCH 2/2] KVM: PPC: booke: Add watchdog emulation

2012-07-19 Thread Bhushan Bharat-R65777
Please ignore this as I forget to get [v5] is subject.. Thanks -Bharat > -Original Message- > From: Bhushan Bharat-R65777 > Sent: Friday, July 20, 2012 10:29 AM > To: kvm-...@vger.kernel.org; kvm@vger.kernel.org; ag...@suse.de > Cc: Bhushan Bharat-R65777 > Subject: [PATCH 2/2] KVM: PPC:

Re: [PATCH 2/2] KVM: PPC: booke: Add watchdog emulation

2012-07-09 Thread Alexander Graf
On 09.07.2012, at 19:09, Scott Wood wrote: > On 07/07/2012 02:50 AM, Alexander Graf wrote: >> >> On 07.07.2012, at 01:37, Scott Wood wrote: >> >>> On 07/06/2012 08:17 AM, Alexander Graf wrote: On 28.06.2012, at 08:17, Bharat Bhushan wrote: > +/* > + * The timer system can almost de

Re: [PATCH 2/2] KVM: PPC: booke: Add watchdog emulation

2012-07-09 Thread Scott Wood
On 07/07/2012 02:50 AM, Alexander Graf wrote: > > On 07.07.2012, at 01:37, Scott Wood wrote: > >> On 07/06/2012 08:17 AM, Alexander Graf wrote: >>> On 28.06.2012, at 08:17, Bharat Bhushan wrote: +/* + * The timer system can almost deal with LONG_MAX timeouts, except that + * when y

RE: [PATCH 2/2] KVM: PPC: booke: Add watchdog emulation

2012-07-09 Thread Bhushan Bharat-R65777
; kvm@vger.kernel.org > Subject: Re: [PATCH 2/2] KVM: PPC: booke: Add watchdog emulation > > > On 09.07.2012, at 16:28, Scott Wood wrote: > > > On 07/09/2012 12:13 AM, Bhushan Bharat-R65777 wrote: > >> > >> > >>> -Original Message- > &g

Re: [PATCH 2/2] KVM: PPC: booke: Add watchdog emulation

2012-07-09 Thread Alexander Graf
ood Scott-B07421 >>> Cc: Bhushan Bharat-R65777; kvm-...@vger.kernel.org; kvm@vger.kernel.org; >>> Bhushan >>> Bharat-R65777 >>> Subject: Re: [PATCH 2/2] KVM: PPC: booke: Add watchdog emulation >>> >>> >>> Ah, being 2 bits wide, the above c

Re: [PATCH 2/2] KVM: PPC: booke: Add watchdog emulation

2012-07-09 Thread Scott Wood
rg; kvm@vger.kernel.org; >> Bhushan >> Bharat-R65777 >> Subject: Re: [PATCH 2/2] KVM: PPC: booke: Add watchdog emulation >> >> >> Ah, being 2 bits wide, the above code suddenly makes more sense :). How about >> >> /* WRC is a 2-bit field that is supposed to

Re: [PATCH 2/2] KVM: PPC: booke: Add watchdog emulation

2012-07-09 Thread Alexander Graf
On 09.07.2012, at 08:43, Bhushan Bharat-R65777 wrote: >>> + >>> +/* >>> + * Return the number of jiffies until the next timeout. If the >>> +timeout is >>> + * longer than the MAX_TIMEOUT, that we return MAX_TIMEOUT instead. >>> + */ >>> +static unsigned long watchdog_next_timeout(struct kvm_vcp

Re: [PATCH 2/2] KVM: PPC: booke: Add watchdog emulation

2012-07-09 Thread Alexander Graf
rg; kvm@vger.kernel.org; >> Bhushan >> Bharat-R65777 >> Subject: Re: [PATCH 2/2] KVM: PPC: booke: Add watchdog emulation >> >> >> On 07.07.2012, at 01:37, Scott Wood wrote: >> >>> On 07/06/2012 08:17 AM, Alexander Graf wrote: >>>> On 28

RE: [PATCH 2/2] KVM: PPC: booke: Add watchdog emulation

2012-07-08 Thread Bhushan Bharat-R65777
> > + > > +/* > > + * Return the number of jiffies until the next timeout. If the > > +timeout is > > + * longer than the MAX_TIMEOUT, that we return MAX_TIMEOUT instead. > > + */ > > +static unsigned long watchdog_next_timeout(struct kvm_vcpu *vcpu) { > > + unsigned long long tb, mask, nr_jiffi

RE: [PATCH 2/2] KVM: PPC: booke: Add watchdog emulation

2012-07-08 Thread Bhushan Bharat-R65777
> -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Saturday, July 07, 2012 1:21 PM > To: Wood Scott-B07421 > Cc: Bhushan Bharat-R65777; kvm-...@vger.kernel.org; kvm@vger.kernel.org; > Bhushan > Bharat-R65777 > Subject: Re: [PATCH 2

Re: [PATCH 2/2] KVM: PPC: booke: Add watchdog emulation

2012-07-07 Thread Alexander Graf
On 07.07.2012, at 01:37, Scott Wood wrote: > On 07/06/2012 08:17 AM, Alexander Graf wrote: >> On 28.06.2012, at 08:17, Bharat Bhushan wrote: >>> +/* >>> + * The timer system can almost deal with LONG_MAX timeouts, except that >>> + * when you get very close to LONG_MAX, the slack added can cause

Re: [PATCH 2/2] KVM: PPC: booke: Add watchdog emulation

2012-07-06 Thread Scott Wood
On 07/06/2012 08:17 AM, Alexander Graf wrote: > On 28.06.2012, at 08:17, Bharat Bhushan wrote: >> +/* >> + * The timer system can almost deal with LONG_MAX timeouts, except that >> + * when you get very close to LONG_MAX, the slack added can cause overflow. >> + * >> + * LONG_MAX/2 is a conservativ

Re: [PATCH 2/2] KVM: PPC: booke: Add watchdog emulation

2012-07-06 Thread Alexander Graf
On 28.06.2012, at 08:17, Bharat Bhushan wrote: > This patch adds the watchdog emulation in KVM. The watchdog > emulation is enabled by KVM_ENABLE_CAP(KVM_CAP_PPC_WDT) ioctl. > The kernel timer are used for watchdog emulation and emulates > h/w watchdog state machine. On watchdog timer expiry, it