Re: [PATCH 13/13] KVM: arm64: enable ITS emulation as a virtual MSI controller

2015-06-18 Thread Andre Przywara
On 06/18/2015 04:03 PM, Pavel Fedin wrote: > Hello! > >> But that fails compilation on ARM (which uses this file as well), >> because we have a dummy fail function in the header if >> CONFIG_HAVE_KVM_MSI is not defined. > > May be then remove that fail function too? Too many #ifdef's are not go

RE: [PATCH 13/13] KVM: arm64: enable ITS emulation as a virtual MSI controller

2015-06-18 Thread Pavel Fedin
Hello! > But that fails compilation on ARM (which uses this file as well), > because we have a dummy fail function in the header if > CONFIG_HAVE_KVM_MSI is not defined. May be then remove that fail function too? Too many #ifdef's are not good... Kind regards, Pavel Fedin Expert Engineer Samsu

Re: [PATCH 13/13] KVM: arm64: enable ITS emulation as a virtual MSI controller

2015-06-18 Thread Andre Przywara
Hi Eric, On 06/18/2015 09:43 AM, Eric Auger wrote: > On 05/29/2015 11:53 AM, Andre Przywara wrote: >> If userspace has provided a base address for the ITS register frame, >> we enable the bits that advertise LPIs in the GICv3. >> When the guest has enabled LPIs and the ITS, we enable the emulation

Re: [PATCH 13/13] KVM: arm64: enable ITS emulation as a virtual MSI controller

2015-06-18 Thread Eric Auger
On 05/29/2015 11:53 AM, Andre Przywara wrote: > If userspace has provided a base address for the ITS register frame, > we enable the bits that advertise LPIs in the GICv3. > When the guest has enabled LPIs and the ITS, we enable the emulation > part by initializing the ITS data structures and trapp

Re: [PATCH 13/13] KVM: arm64: enable ITS emulation as a virtual MSI controller

2015-06-12 Thread Eric Auger
On 05/29/2015 11:53 AM, Andre Przywara wrote: > If userspace has provided a base address for the ITS register frame, > we enable the bits that advertise LPIs in the GICv3. > When the guest has enabled LPIs and the ITS, we enable the emulation > part by initializing the ITS data structures and trapp