Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-04-14 Thread Gleb Natapov
On Sun, Apr 14, 2013 at 04:47:48PM +0300, Abel Gordon wrote: > > > Gleb Natapov wrote on 14/04/2013 02:16:02 PM: > > > On Sun, Apr 14, 2013 at 01:49:44PM +0300, Abel Gordon wrote: > > > > > > > > > Gleb Natapov wrote on 14/04/2013 01:34:52 PM: > > > > > > > On Sun, Apr 14, 2013 at 12:27:10PM +

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-04-14 Thread Abel Gordon
Gleb Natapov wrote on 14/04/2013 02:16:02 PM: > On Sun, Apr 14, 2013 at 01:49:44PM +0300, Abel Gordon wrote: > > > > > > Gleb Natapov wrote on 14/04/2013 01:34:52 PM: > > > > > On Sun, Apr 14, 2013 at 12:27:10PM +0200, Jan Kiszka wrote: > > > > On 2013-04-14 12:07, Gleb Natapov wrote: > > > >

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-04-14 Thread Gleb Natapov
On Sun, Apr 14, 2013 at 01:49:44PM +0300, Abel Gordon wrote: > > > Gleb Natapov wrote on 14/04/2013 01:34:52 PM: > > > On Sun, Apr 14, 2013 at 12:27:10PM +0200, Jan Kiszka wrote: > > > On 2013-04-14 12:07, Gleb Natapov wrote: > > > > On Sun, Apr 14, 2013 at 01:00:10PM +0300, Gleb Natapov wrote:

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-04-14 Thread Abel Gordon
Gleb Natapov wrote on 14/04/2013 01:34:52 PM: > On Sun, Apr 14, 2013 at 12:27:10PM +0200, Jan Kiszka wrote: > > On 2013-04-14 12:07, Gleb Natapov wrote: > > > On Sun, Apr 14, 2013 at 01:00:10PM +0300, Gleb Natapov wrote: > > >> On Sun, Apr 14, 2013 at 12:51:34PM +0300, Abel Gordon wrote: > > >>

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-04-14 Thread Gleb Natapov
On Sun, Apr 14, 2013 at 12:27:10PM +0200, Jan Kiszka wrote: > On 2013-04-14 12:07, Gleb Natapov wrote: > > On Sun, Apr 14, 2013 at 01:00:10PM +0300, Gleb Natapov wrote: > >> On Sun, Apr 14, 2013 at 12:51:34PM +0300, Abel Gordon wrote: > >>> > >>> > >>> Gleb Natapov wrote on 12/04/2013 01:48:04 PM:

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-04-14 Thread Abel Gordon
Jan Kiszka wrote on 14/04/2013 01:27:10 PM: > On 2013-04-14 12:07, Gleb Natapov wrote: > > On Sun, Apr 14, 2013 at 01:00:10PM +0300, Gleb Natapov wrote: > >> On Sun, Apr 14, 2013 at 12:51:34PM +0300, Abel Gordon wrote: > >>> > >>> > >>> Gleb Natapov wrote on 12/04/2013 01:48:04 PM: > >>> > >>

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-04-14 Thread Jan Kiszka
On 2013-04-14 12:07, Gleb Natapov wrote: > On Sun, Apr 14, 2013 at 01:00:10PM +0300, Gleb Natapov wrote: >> On Sun, Apr 14, 2013 at 12:51:34PM +0300, Abel Gordon wrote: >>> >>> >>> Gleb Natapov wrote on 12/04/2013 01:48:04 PM: >>> On Fri, Apr 12, 2013 at 01:44:14PM +0300, Abel Gordon wrote: >

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-04-14 Thread Gleb Natapov
On Sun, Apr 14, 2013 at 01:00:10PM +0300, Gleb Natapov wrote: > On Sun, Apr 14, 2013 at 12:51:34PM +0300, Abel Gordon wrote: > > > > > > Gleb Natapov wrote on 12/04/2013 01:48:04 PM: > > > > > On Fri, Apr 12, 2013 at 01:44:14PM +0300, Abel Gordon wrote: > > > > > > > > Ok, so then you prefer to

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-04-14 Thread Gleb Natapov
On Sun, Apr 14, 2013 at 12:51:34PM +0300, Abel Gordon wrote: > > > Gleb Natapov wrote on 12/04/2013 01:48:04 PM: > > > On Fri, Apr 12, 2013 at 01:44:14PM +0300, Abel Gordon wrote: > > > > > > Ok, so then you prefer to add the inline functions to read/write to the > > > vmcs12 > > > fields, (to

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-04-14 Thread Abel Gordon
Gleb Natapov wrote on 12/04/2013 01:48:04 PM: > On Fri, Apr 12, 2013 at 01:44:14PM +0300, Abel Gordon wrote: > > > > Ok, so then you prefer to add the inline functions to read/write to the > > vmcs12 > > fields, (to set the request bit if shadowed field changed) and you are not > > concerned >

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-04-12 Thread Gleb Natapov
rnel.org, "Nadav Har'El" , > > owass...@redhat.com > > Date: 12/04/2013 01:31 PM > > Subject: Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content > > with the shadow vmcs > > Sent by: kvm-ow...@vger.kernel.org > > > > On Fri, Apr 12, 201

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-04-12 Thread Abel Gordon
> Subject: Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content > with the shadow vmcs > Sent by: kvm-ow...@vger.kernel.org > > On Fri, Apr 12, 2013 at 01:26:32PM +0300, Abel Gordon wrote: > > > > > > Gleb Natapov wrote on 11/04/2013 09:54:11 AM: >

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-04-12 Thread Gleb Natapov
On Fri, Apr 12, 2013 at 01:26:32PM +0300, Abel Gordon wrote: > > > Gleb Natapov wrote on 11/04/2013 09:54:11 AM: > > > On Wed, Apr 10, 2013 at 10:15:37PM +0300, Abel Gordon wrote: > > > > > > > > > Gleb Natapov wrote on 09/04/2013 04:14:35 PM: > > > > I think the patch already miss some fields

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-04-12 Thread Abel Gordon
Gleb Natapov wrote on 11/04/2013 09:54:11 AM: > On Wed, Apr 10, 2013 at 10:15:37PM +0300, Abel Gordon wrote: > > > > > > Gleb Natapov wrote on 09/04/2013 04:14:35 PM: > > > I think the patch already miss some fields. What if nested_vmx_run() > > > fails and calls nested_vmx_entry_failure(). ne

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-04-10 Thread Gleb Natapov
On Wed, Apr 10, 2013 at 10:15:37PM +0300, Abel Gordon wrote: > > > Gleb Natapov wrote on 09/04/2013 04:14:35 PM: > > > On Mon, Mar 11, 2013 at 09:54:47AM +0200, Abel Gordon wrote: > > > "Nadav Har'El" wrote on 11/03/2013 12:43:35 > AM: > > > > > > > > > > On Sun, Mar 10, 2013, Abel Gordon wrot

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-04-10 Thread Abel Gordon
Gleb Natapov wrote on 09/04/2013 04:14:35 PM: > On Mon, Mar 11, 2013 at 09:54:47AM +0200, Abel Gordon wrote: > > "Nadav Har'El" wrote on 11/03/2013 12:43:35 AM: > > > > > > > On Sun, Mar 10, 2013, Abel Gordon wrote about "[PATCH 10/11] KVM: > > > nVMX: Synchronize VMCS12 content with the shado

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-04-09 Thread Gleb Natapov
On Mon, Mar 11, 2013 at 09:54:47AM +0200, Abel Gordon wrote: > "Nadav Har'El" wrote on 11/03/2013 12:43:35 AM: > > > > On Sun, Mar 10, 2013, Abel Gordon wrote about "[PATCH 10/11] KVM: > > nVMX: Synchronize VMCS12 content with the shadow vmcs": > > > nested_vmx_vmexit(vcpu); > > > + if (en

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-03-11 Thread Abel Gordon
"Nadav Har'El" wrote on 11/03/2013 12:43:35 AM: > On Sun, Mar 10, 2013, Abel Gordon wrote about "[PATCH 10/11] KVM: > nVMX: Synchronize VMCS12 content with the shadow vmcs": > > nested_vmx_vmexit(vcpu); > > + if (enable_shadow_vmcs) > > + copy_vmcs12_to_shadow(to_vmx(vcpu)); > > I was

Re: [PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs

2013-03-10 Thread Nadav Har'El
Hi Abel, very nice patches. On Sun, Mar 10, 2013, Abel Gordon wrote about "[PATCH 10/11] KVM: nVMX: Synchronize VMCS12 content with the shadow vmcs": > nested_vmx_vmexit(vcpu); > + if (enable_shadow_vmcs) > + copy_vmcs12_to_shadow(to_vmx(vcpu)); I was curious why your patch