Re: [PATCH 1/4] Move irq routing data structure to rcu locking

On Mon, Jul 13, 2009 at 01:45:07PM -0300, Marcelo Tosatti wrote: > On Mon, Jul 13, 2009 at 07:44:38PM +0300, Gleb Natapov wrote: > > > > I don't get it. The point for RCU is to get rid of reader's lock. If > > > > I'll have to take slot_lock on each EOI I achieved nothing. > > > > > > You already

Re: [PATCH 1/4] Move irq routing data structure to rcu locking

On Mon, Jul 13, 2009 at 07:44:38PM +0300, Gleb Natapov wrote: > > > I don't get it. The point for RCU is to get rid of reader's lock. If > > > I'll have to take slot_lock on each EOI I achieved nothing. > > > > You already take slots_lock for read on every exit. > > > We should fix that, not add

Re: [PATCH 1/4] Move irq routing data structure to rcu locking

On Mon, Jul 13, 2009 at 01:42:13PM -0300, Marcelo Tosatti wrote: > On Mon, Jul 13, 2009 at 07:33:30PM +0300, Gleb Natapov wrote: > > On Mon, Jul 13, 2009 at 01:27:38PM -0300, Marcelo Tosatti wrote: > > > On Mon, Jul 13, 2009 at 07:24:53PM +0300, Gleb Natapov wrote: > > > > On Mon, Jul 13, 2009 at 1

Re: [PATCH 1/4] Move irq routing data structure to rcu locking

On Mon, Jul 13, 2009 at 07:33:30PM +0300, Gleb Natapov wrote: > On Mon, Jul 13, 2009 at 01:27:38PM -0300, Marcelo Tosatti wrote: > > On Mon, Jul 13, 2009 at 07:24:53PM +0300, Gleb Natapov wrote: > > > On Mon, Jul 13, 2009 at 12:55:31PM -0300, Marcelo Tosatti wrote: > > > > On Mon, Jul 13, 2009 at 0

Re: [PATCH 1/4] Move irq routing data structure to rcu locking

On Mon, Jul 13, 2009 at 01:27:38PM -0300, Marcelo Tosatti wrote: > On Mon, Jul 13, 2009 at 07:24:53PM +0300, Gleb Natapov wrote: > > On Mon, Jul 13, 2009 at 12:55:31PM -0300, Marcelo Tosatti wrote: > > > On Mon, Jul 13, 2009 at 04:15:34PM +0300, Gleb Natapov wrote: > > > > On Mon, Jul 13, 2009 at 0

Re: [PATCH 1/4] Move irq routing data structure to rcu locking

On Mon, Jul 13, 2009 at 07:24:53PM +0300, Gleb Natapov wrote: > On Mon, Jul 13, 2009 at 12:55:31PM -0300, Marcelo Tosatti wrote: > > On Mon, Jul 13, 2009 at 04:15:34PM +0300, Gleb Natapov wrote: > > > On Mon, Jul 13, 2009 at 09:01:33AM -0400, Gregory Haskins wrote: > > > > Gleb Natapov wrote: > > >

Re: [PATCH 1/4] Move irq routing data structure to rcu locking

On Mon, Jul 13, 2009 at 12:55:31PM -0300, Marcelo Tosatti wrote: > On Mon, Jul 13, 2009 at 04:15:34PM +0300, Gleb Natapov wrote: > > On Mon, Jul 13, 2009 at 09:01:33AM -0400, Gregory Haskins wrote: > > > Gleb Natapov wrote: > > > > Signed-off-by: Gleb Natapov > > > > --- > > > > include/linux/kvm

Re: [PATCH 1/4] Move irq routing data structure to rcu locking

On Mon, Jul 13, 2009 at 04:15:34PM +0300, Gleb Natapov wrote: > On Mon, Jul 13, 2009 at 09:01:33AM -0400, Gregory Haskins wrote: > > Gleb Natapov wrote: > > > Signed-off-by: Gleb Natapov > > > --- > > > include/linux/kvm_host.h |2 +- > > > virt/kvm/irq_comm.c | 55 > > > +

Re: [PATCH 1/4] Move irq routing data structure to rcu locking

Gleb Natapov wrote: > On Mon, Jul 13, 2009 at 09:16:47AM -0400, Gregory Haskins wrote: > >> Gleb Natapov wrote: >> >>> On Mon, Jul 13, 2009 at 09:01:33AM -0400, Gregory Haskins wrote: >>> >>> Gleb Natapov wrote: > Signed-off-by: Gleb Natapov >

Re: [PATCH 1/4] Move irq routing data structure to rcu locking

On Mon, Jul 13, 2009 at 04:23:49PM +0300, Gleb Natapov wrote: > > resource. Maybe it's a good idea to use an array instead of a list. All > > I'm saying, RCU does not force you to do this. > > > It doesn't, but list shouldn't be used here in the first place. OK, but I think the change and the rea

Re: [PATCH 1/4] Move irq routing data structure to rcu locking

On Mon, Jul 13, 2009 at 09:16:47AM -0400, Gregory Haskins wrote: > Gleb Natapov wrote: > > On Mon, Jul 13, 2009 at 09:01:33AM -0400, Gregory Haskins wrote: > > > >> Gleb Natapov wrote: > >> > >>> Signed-off-by: Gleb Natapov > >>> --- > >>> include/linux/kvm_host.h |2 +- > >>> virt/kv

Re: [PATCH 1/4] Move irq routing data structure to rcu locking

On Mon, Jul 13, 2009 at 04:15:30PM +0300, Michael S. Tsirkin wrote: > On Mon, Jul 13, 2009 at 04:03:10PM +0300, Gleb Natapov wrote: > > On Mon, Jul 13, 2009 at 03:55:07PM +0300, Michael S. Tsirkin wrote: > > > On Sun, Jul 12, 2009 at 03:03:50PM +0300, Gleb Natapov wrote: > > > > > > > > Signed-off

Re: [PATCH 1/4] Move irq routing data structure to rcu locking

Gleb Natapov wrote: > On Mon, Jul 13, 2009 at 09:01:33AM -0400, Gregory Haskins wrote: > >> Gleb Natapov wrote: >> >>> Signed-off-by: Gleb Natapov >>> --- >>> include/linux/kvm_host.h |2 +- >>> virt/kvm/irq_comm.c | 55 >>> +- >>> v

Re: [PATCH 1/4] Move irq routing data structure to rcu locking

On Mon, Jul 13, 2009 at 04:03:10PM +0300, Gleb Natapov wrote: > On Mon, Jul 13, 2009 at 03:55:07PM +0300, Michael S. Tsirkin wrote: > > On Sun, Jul 12, 2009 at 03:03:50PM +0300, Gleb Natapov wrote: > > > > > > Signed-off-by: Gleb Natapov > > > --- > > > include/linux/kvm_host.h |2 +- > > >

Re: [PATCH 1/4] Move irq routing data structure to rcu locking

On Mon, Jul 13, 2009 at 09:01:33AM -0400, Gregory Haskins wrote: > Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov > > --- > > include/linux/kvm_host.h |2 +- > > virt/kvm/irq_comm.c | 55 > > +- > > virt/kvm/kvm_main.c |1 - > >

Re: [PATCH 1/4] Move irq routing data structure to rcu locking

On Mon, Jul 13, 2009 at 03:55:07PM +0300, Michael S. Tsirkin wrote: > On Sun, Jul 12, 2009 at 03:03:50PM +0300, Gleb Natapov wrote: > > > > Signed-off-by: Gleb Natapov > > --- > > include/linux/kvm_host.h |2 +- > > virt/kvm/irq_comm.c | 55 > > +--

Re: [PATCH 1/4] Move irq routing data structure to rcu locking

Gleb Natapov wrote: > Signed-off-by: Gleb Natapov > --- > include/linux/kvm_host.h |2 +- > virt/kvm/irq_comm.c | 55 > +- > virt/kvm/kvm_main.c |1 - > 3 files changed, 26 insertions(+), 32 deletions(-) > > diff --git a/include/lin

Re: [PATCH 1/4] Move irq routing data structure to rcu locking

On Sun, Jul 12, 2009 at 03:03:50PM +0300, Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov > --- > include/linux/kvm_host.h |2 +- > virt/kvm/irq_comm.c | 55 > +- > virt/kvm/kvm_main.c |1 - > 3 files changed, 26 insertions(+),