Re: [PATCH] simplify creation of kernel irqchip and pit

2009-07-29 Thread Avi Kivity
On 07/29/2009 04:50 PM, Glauber Costa wrote: On Wed, Jul 29, 2009 at 03:01:56PM +0300, Avi Kivity wrote: On 07/24/2009 08:57 AM, Glauber Costa wrote: Creation of those devices can be a lot simpler. In particular, if we start by assuming they will be on, and disabling later if anything

Re: [PATCH] simplify creation of kernel irqchip and pit

2009-07-29 Thread Glauber Costa
On Wed, Jul 29, 2009 at 03:01:56PM +0300, Avi Kivity wrote: > On 07/24/2009 08:57 AM, Glauber Costa wrote: >> Creation of those devices can be a lot simpler. In particular, >> if we start by assuming they will be on, and disabling later if >> anything fails (user request counts as failing here), we

Re: [PATCH] simplify creation of kernel irqchip and pit

2009-07-29 Thread Avi Kivity
On 07/24/2009 08:57 AM, Glauber Costa wrote: Creation of those devices can be a lot simpler. In particular, if we start by assuming they will be on, and disabling later if anything fails (user request counts as failing here), we can remove two variables that really serves no reason. The pat