Re: [KVM PATCH v8 1/3] KVM: Fix races in irqfd using new eventfd_kref_get interface

2009-07-02 Thread Avi Kivity
On 07/02/2009 05:27 PM, Gregory Haskins wrote: Please split the eventfd.c hunk into a separate patch. When preparing the 2.6.32 submission, I'll fold that into the patch into its antipatch and they'll disappear. Ok, but note that that means I should probably split 1/3 back out into

Re: [KVM PATCH v8 1/3] KVM: Fix races in irqfd using new eventfd_kref_get interface

2009-07-02 Thread Gregory Haskins
Avi Kivity wrote: > On 07/01/2009 07:09 PM, Gregory Haskins wrote: >> eventfd currently emits a POLLHUP wakeup on f_ops->release() to >> generate a >> "release" callback. This lets eventfd clients know if the eventfd is >> about >> to go away and is very useful particularly for in-kernel clients.

Re: [KVM PATCH v8 1/3] KVM: Fix races in irqfd using new eventfd_kref_get interface

2009-07-02 Thread Avi Kivity
On 07/01/2009 07:09 PM, Gregory Haskins wrote: eventfd currently emits a POLLHUP wakeup on f_ops->release() to generate a "release" callback. This lets eventfd clients know if the eventfd is about to go away and is very useful particularly for in-kernel clients. However, until recently it is no

Re: [KVM PATCH v8 1/3] KVM: Fix races in irqfd using new eventfd_kref_get interface

2009-07-01 Thread Gregory Haskins
Gregory Haskins wrote: > > + eventfd = eventfd_ctx_fileget(file); > + if (IS_ERR(file)) { > + ret = PTR_ERR(file); > + goto fail; > + } > + > + irqfd->eventfd = eventfd; > + > Just noticed the typo (return "eventfd" but error-check "file"). Looks lik