On 07/17/2015 12:21 PM, Pavel Fedin wrote:
> Hello!
>
> + } else if (!msi->flags)
> + return -EINVAL;
>>> Did you mean "if (msg->flags)" here (inverted condition)?
Yes thanks for spotting this.
Thanks
Eric
>>
>> Indeed, and also you need { } around the return for the QEMU codin
Hello!
> >> > +} else if (!msi->flags)
> >> > +return -EINVAL;
> > Did you mean "if (msg->flags)" here (inverted condition)?
>
> Indeed, and also you need { } around the return for the QEMU coding
> standard.
It's kernel and not qemu :)
Kind regards,
Pavel Fedin
Exper
On 17/07/2015 09:27, Pavel Fedin wrote:
>> > + } else if (!msi->flags)
>> > + return -EINVAL;
> Did you mean "if (msg->flags)" here (inverted condition)?
Indeed, and also you need { } around the return for the QEMU coding
standard.
Paolo
>> > +
>> > + /* historically the route.type
> -Original Message-
> From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On Behalf
> Of Eric Auger
> Sent: Thursday, July 09, 2015 11:22 AM
> To: eric.au...@st.com; eric.au...@linaro.org;
> linux-arm-ker...@lists.infradead.org;
> marc.zyng...@arm.com; christoffer.d...@lin
On 09/07/15 09:22, Eric Auger wrote:
> on ARM, a devid field is populated in kvm_msi struct in case the
> flag is set to KVM_MSI_VALID_DEVID. Let's populate the corresponding
> kvm_kernel_irq_routing_entry devid field and set the msi type to
> KVM_IRQ_ROUTING_EXTENDED_MSI.
>
> Signed-off-by: Eric
