RE: [PATCH 2/2] Expose tsc deadline timer cpuid to guest

2012-02-28 Thread Liu, Jinsong
> > My point is that > > qemu-version-A [-cpu whatever] > > should provide the same VM as > > qemu-version-B -machine pc-A [-cpu whatever] > > specifically if you leave out the cpu specification. > > So the compat machine could establish a feature mask (e.g. append some > "-tsc_deadline"

Re: [PATCH 2/2] Expose tsc deadline timer cpuid to guest

2012-02-27 Thread Jan Kiszka
On 2012-02-27 17:05, Liu, Jinsong wrote: > Jan Kiszka wrote: >> On 2012-01-07 19:23, Liu, Jinsong wrote: >>> Jan Kiszka wrote: On 2012-01-05 18:07, Liu, Jinsong wrote: >> Sorry, it remains bogus to expose the tsc deadline timer feature >> on machines < pc-1.1. That's just like we intro

RE: [PATCH 2/2] Expose tsc deadline timer cpuid to guest

2012-02-27 Thread Liu, Jinsong
Jan Kiszka wrote: > On 2012-01-07 19:23, Liu, Jinsong wrote: >> Jan Kiszka wrote: >>> On 2012-01-05 18:07, Liu, Jinsong wrote: > Sorry, it remains bogus to expose the tsc deadline timer feature > on machines < pc-1.1. That's just like we introduced kvmclock > only to pc-0.14 onward. The

Re: [PATCH 2/2] Expose tsc deadline timer cpuid to guest

2012-01-08 Thread Jan Kiszka
On 2012-01-07 19:23, Liu, Jinsong wrote: > Jan Kiszka wrote: >> On 2012-01-05 18:07, Liu, Jinsong wrote: Sorry, it remains bogus to expose the tsc deadline timer feature on machines < pc-1.1. That's just like we introduced kvmclock only to pc-0.14 onward. The reason is that guest OSe

RE: [PATCH 2/2] Expose tsc deadline timer cpuid to guest

2012-01-07 Thread Liu, Jinsong
Jan Kiszka wrote: > On 2012-01-05 18:07, Liu, Jinsong wrote: >>> Sorry, it remains bogus to expose the tsc deadline timer feature on >>> machines < pc-1.1. That's just like we introduced kvmclock only to >>> pc-0.14 onward. The reason is that guest OSes so far running on >>> qemu-1.0 or older witho

Re: [PATCH 2/2] Expose tsc deadline timer cpuid to guest

2012-01-05 Thread Jan Kiszka
On 2012-01-05 18:07, Liu, Jinsong wrote: >> Sorry, it remains bogus to expose the tsc deadline timer feature on >> machines < pc-1.1. That's just like we introduced kvmclock only to >> pc-0.14 onward. The reason is that guest OSes so far running on >> qemu-1.0 or older without deadline timer suppor

RE: [PATCH 2/2] Expose tsc deadline timer cpuid to guest

2012-01-05 Thread Liu, Jinsong
> This requires some logic change and then rewording: > > - enable TSC deadline timer support by default if in-kernel irqchip is > used > - disable it on user request via a cpu feature flag Yes, the logic has been implemented by the former patch as: +if (env->tsc_deadline_timer_enabled) {

Re: [PATCH 2/2] Expose tsc deadline timer cpuid to guest

2012-01-04 Thread Jan Kiszka
On 2011-12-28 19:55, Liu, Jinsong wrote: >>From 3a78adf8006ec6189bfe2f55f7ae213e75bf3815 Mon Sep 17 00:00:00 2001 > From: Liu Jinsong > Date: Thu, 29 Dec 2011 05:28:12 +0800 > Subject: [PATCH 2/2] Expose tsc deadline timer cpuid to guest > > Depend on several factors: > 1. Considering live migrat