oh，yeah. Thanks for your reply. It's a good lesson for me. :)
I will update soon.
On 二, 2011-12-13 at 16:57 +0800, Kevin Wolf wrote:
> Am 13.12.2011 04:41, schrieb lan,Tianyu:
> > On 一, 2011-12-12 at 19:15 +0800, Kevin Wolf wrote:
> >> Am 12.12.2011 11:58, schrieb Pekka Enberg:
> >>> On Mon, 12 Dec
On Tue, Dec 13, 2011 at 10:57 AM, Kevin Wolf wrote:
>> So the ENOSPEC should be specially dealt with.
>>
>> Does this make sense? :)
>
> I'm not saying that your code won't work today, just that it's brittle.
> If someone adds a different error return code somewhere and doesn't
> check if all call
On Tue, Dec 13, 2011 at 5:16 AM, lan,Tianyu wrote:
> I have tried to use ERR_PTR(). But when I included linux/err.h, a
> compile error was following.
>
> CC disk/qcow.o
> In file included from disk/qcow.c:20:
> ../../include/linux/err.h:22: error: expected '=', ',', ';', 'asm' or
> '__attr
Am 13.12.2011 04:05, schrieb lan,Tianyu:
> Thanks for your review.
> On 一, 2011-12-12 at 17:55 +0800, Kevin Wolf wrote:
>> Am 12.12.2011 03:03, schrieb Lan Tianyu:
>>> This patch enables allocating new refcount blocks and so then kvm tools
>>> could expand qcow2 image much larger.
>>>
>>> Signed-of
Am 13.12.2011 04:41, schrieb lan,Tianyu:
> On 一, 2011-12-12 at 19:15 +0800, Kevin Wolf wrote:
>> Am 12.12.2011 11:58, schrieb Pekka Enberg:
>>> On Mon, 12 Dec 2011, Kevin Wolf wrote:
> @@ -667,14 +722,11 @@ static struct qcow_refcount_block
> *qcow_read_refcount_block(struct qcow *q, u64
>
On 一, 2011-12-12 at 19:15 +0800, Kevin Wolf wrote:
> Am 12.12.2011 11:58, schrieb Pekka Enberg:
> > On Mon, 12 Dec 2011, Kevin Wolf wrote:
> >>> @@ -667,14 +722,11 @@ static struct qcow_refcount_block
> >>> *qcow_read_refcount_block(struct qcow *q, u64
> >>>
> >>> rft_idx = clust_idx >> (header-
On 一, 2011-12-12 at 18:58 +0800, Pekka Enberg wrote:
> On Mon, 12 Dec 2011, Kevin Wolf wrote:
> >> @@ -667,14 +722,11 @@ static struct qcow_refcount_block
> >> *qcow_read_refcount_block(struct qcow *q, u64
> >>
> >>rft_idx = clust_idx >> (header->cluster_bits -
> >> QCOW_REFCOUNT_BLOCK_SHIFT)
Thanks for your review.
On 一, 2011-12-12 at 17:55 +0800, Kevin Wolf wrote:
> Am 12.12.2011 03:03, schrieb Lan Tianyu:
> > This patch enables allocating new refcount blocks and so then kvm tools
> > could expand qcow2 image much larger.
> >
> > Signed-off-by: Lan Tianyu
> > ---
> > tools/kvm/disk
Am 12.12.2011 12:15, schrieb Kevin Wolf:
> Am 12.12.2011 11:58, schrieb Pekka Enberg:
>> On Mon, 12 Dec 2011, Kevin Wolf wrote:
@@ -667,14 +722,11 @@ static struct qcow_refcount_block
*qcow_read_refcount_block(struct qcow *q, u64
rft_idx = clust_idx >> (header->cluster_bits
Am 12.12.2011 11:58, schrieb Pekka Enberg:
> On Mon, 12 Dec 2011, Kevin Wolf wrote:
>>> @@ -667,14 +722,11 @@ static struct qcow_refcount_block
>>> *qcow_read_refcount_block(struct qcow *q, u64
>>>
>>> rft_idx = clust_idx >> (header->cluster_bits -
>>> QCOW_REFCOUNT_BLOCK_SHIFT);
>>> if (
On Mon, 12 Dec 2011, Kevin Wolf wrote:
@@ -667,14 +722,11 @@ static struct qcow_refcount_block
*qcow_read_refcount_block(struct qcow *q, u64
rft_idx = clust_idx >> (header->cluster_bits -
QCOW_REFCOUNT_BLOCK_SHIFT);
if (rft_idx >= rft->rf_size)
- return NULL;
+
Am 12.12.2011 03:03, schrieb Lan Tianyu:
> This patch enables allocating new refcount blocks and so then kvm tools
> could expand qcow2 image much larger.
>
> Signed-off-by: Lan Tianyu
> ---
> tools/kvm/disk/qcow.c | 105 +---
> 1 files changed, 89 in
This patch enables allocating new refcount blocks and so then kvm tools
could expand qcow2 image much larger.
Signed-off-by: Lan Tianyu
---
tools/kvm/disk/qcow.c | 105 +---
1 files changed, 89 insertions(+), 16 deletions(-)
diff --git a/tools/kvm/di
13 matches
Mail list logo
