Re: [Qemu-devel] [PATCH 04/11] qemu: helper routines for pci access.

2009-05-26 Thread Michael S. Tsirkin
On Tue, May 26, 2009 at 11:07:33AM +0300, Avi Kivity wrote: > Michael S. Tsirkin wrote: >> On Tue, May 26, 2009 at 11:33:37AM +0900, Isaku Yamahata wrote: >> >>> On Mon, May 25, 2009 at 03:25:33PM +0300, Michael S. Tsirkin wrote: >>> Add inline routines for convenient access to pci dev

Re: [Qemu-devel] [PATCH 04/11] qemu: helper routines for pci access.

2009-05-26 Thread Avi Kivity
Michael S. Tsirkin wrote: On Tue, May 26, 2009 at 11:33:37AM +0900, Isaku Yamahata wrote: On Mon, May 25, 2009 at 03:25:33PM +0300, Michael S. Tsirkin wrote: Add inline routines for convenient access to pci devices with correct (little) endianness. Will be used by MSI-X support.

Re: [Qemu-devel] [PATCH 04/11] qemu: helper routines for pci access.

2009-05-25 Thread Michael S. Tsirkin
On Tue, May 26, 2009 at 11:33:37AM +0900, Isaku Yamahata wrote: > On Mon, May 25, 2009 at 03:25:33PM +0300, Michael S. Tsirkin wrote: > > Add inline routines for convenient access to pci devices > > with correct (little) endianness. Will be used by MSI-X support. > > Just a minor comment. > How abo

Re: [Qemu-devel] [PATCH 04/11] qemu: helper routines for pci access.

2009-05-25 Thread Isaku Yamahata
Just a minor comment. How about to add pci_[sg]et_byte() for consistency? On Mon, May 25, 2009 at 03:25:33PM +0300, Michael S. Tsirkin wrote: > Add inline routines for convenient access to pci devices > with correct (little) endianness. Will be used by MSI-X support. > > Signed-off-by: Michael S.