Re: [PATCHv2 1/2] virtio: fix double free_irq on device removal

2009-07-24 Thread Rusty Russell
On Thu, 23 Jul 2009 09:27:31 pm Michael S. Tsirkin wrote: > msix_user_vectors counted both per-vq and shared/config vectors. > This causes BUG_ON when device is removed, as > free_vectors tries to free per-vq vectors. OK, I looked at this patch, then looked at this code (after it was applied). I'

[PATCHv2 1/2] virtio: fix double free_irq on device removal

2009-07-23 Thread Michael S. Tsirkin
msix_user_vectors counted both per-vq and shared/config vectors. This causes BUG_ON when device is removed, as free_vectors tries to free per-vq vectors. Count per-vq vectors separately so they are only freed by del_vq. Signed-off-by: Michael S. Tsirkin --- drivers/virtio/virtio_pci.c | 38 ++