Re: [PATCH v3 4/7] KVM: VMX: dynamise PLE window

2014-08-21 Thread Radim Krčmář
2014-08-22 00:40+0530, Raghavendra K T: > On 08/21/2014 09:38 PM, Radim Krčmář wrote: > Thanks for the nice patch. > default of grow = 2 and shrink = 0 is very good, which aids fast > clamping in overcommit and less ple_exits in undercommit. > with a small concern over modifier (shrinker) value in

Re: [PATCH v3 4/7] KVM: VMX: dynamise PLE window

2014-08-21 Thread Paolo Bonzini
Il 21/08/2014 21:10, Raghavendra K T ha scritto: > 2. can we consider min_ple_window value of 2k. tracing showed that in > overcommit there were several occations of 4k <- 4k situations. Yes, that could be good now that we have adaptive exits. Perhaps even 1k. > 3. Do you think using ( << and >>

Re: [PATCH v3 4/7] KVM: VMX: dynamise PLE window

2014-08-21 Thread Raghavendra K T
On 08/21/2014 09:38 PM, Radim Krčmář wrote: Window is increased on every PLE exit and decreased on every sched_in. The idea is that we don't want to PLE exit if there is no preemption going on. We do this with sched_in() because it does not hold rq lock. There are two new kernel parameters for c

[PATCH v3 4/7] KVM: VMX: dynamise PLE window

2014-08-21 Thread Radim Krčmář
Window is increased on every PLE exit and decreased on every sched_in. The idea is that we don't want to PLE exit if there is no preemption going on. We do this with sched_in() because it does not hold rq lock. There are two new kernel parameters for changing the window: ple_window_grow and ple_w