Re: [PATCH v2 2/6] reuse env stop and stopped states

2009-07-28 Thread Avi Kivity
On 07/28/2009 09:17 AM, Avi Kivity wrote: I found out that doing kill -38 makes it run again, so we're likely hanging somewhere while holding qemu_mutex. The state of the process is "D", so we're holding qemu_mutex, and then calling something that can block. Sounds like we call a vcpu ioctl

Re: [PATCH v2 2/6] reuse env stop and stopped states

2009-07-27 Thread Avi Kivity
On 07/28/2009 09:29 AM, Gleb Natapov wrote: On Tue, Jul 28, 2009 at 09:28:26AM +0300, Avi Kivity wrote: On 07/28/2009 09:24 AM, Gleb Natapov wrote: What are backtraces of all threads when it happens? I wasn't able to attach with gdb. But I thought you reproduced it?

Re: [PATCH v2 2/6] reuse env stop and stopped states

2009-07-27 Thread Gleb Natapov
On Tue, Jul 28, 2009 at 09:28:26AM +0300, Avi Kivity wrote: > On 07/28/2009 09:24 AM, Gleb Natapov wrote: >> >> What are backtraces of all threads when it happens? >> > > I wasn't able to attach with gdb. But I thought you reproduced it? > Glauber may be yes. Me not even tried :) --

Re: [PATCH v2 2/6] reuse env stop and stopped states

2009-07-27 Thread Avi Kivity
On 07/28/2009 09:24 AM, Gleb Natapov wrote: What are backtraces of all threads when it happens? I wasn't able to attach with gdb. But I thought you reproduced it? -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. -- To unsubscribe from this list: sen

Re: [PATCH v2 2/6] reuse env stop and stopped states

2009-07-27 Thread Gleb Natapov
On Tue, Jul 28, 2009 at 09:17:05AM +0300, Avi Kivity wrote: > On 07/28/2009 03:48 AM, Glauber Costa wrote: >> On Mon, Jul 27, 2009 at 06:43:47PM +0300, Avi Kivity wrote: >> >>> On 07/22/2009 01:13 AM, Glauber Costa wrote: >>> qemu CPUState already provides "stop" and "stopped" states

Re: [PATCH v2 2/6] reuse env stop and stopped states

2009-07-27 Thread Avi Kivity
On 07/28/2009 03:48 AM, Glauber Costa wrote: On Mon, Jul 27, 2009 at 06:43:47PM +0300, Avi Kivity wrote: On 07/22/2009 01:13 AM, Glauber Costa wrote: qemu CPUState already provides "stop" and "stopped" states. And they mean exactly that. There is no need for us to provide our own.

Re: [PATCH v2 2/6] reuse env stop and stopped states

2009-07-27 Thread Glauber Costa
On Mon, Jul 27, 2009 at 06:43:47PM +0300, Avi Kivity wrote: > On 07/22/2009 01:13 AM, Glauber Costa wrote: >> qemu CPUState already provides "stop" and "stopped" states. And they >> mean exactly that. There is no need for us to provide our own. >> >> > > This patch (known as dd0e1c1a589 in qemu

Re: [PATCH v2 2/6] reuse env stop and stopped states

2009-07-27 Thread Avi Kivity
On 07/22/2009 01:13 AM, Glauber Costa wrote: qemu CPUState already provides "stop" and "stopped" states. And they mean exactly that. There is no need for us to provide our own. This patch (known as dd0e1c1a589 in qemu-kvm.git) breaks reboot. My test case is FC6 i386 -smp 2, running the r

[PATCH v2 2/6] reuse env stop and stopped states

2009-07-21 Thread Glauber Costa
qemu CPUState already provides "stop" and "stopped" states. And they mean exactly that. There is no need for us to provide our own. Signed-off-by: Glauber Costa --- cpu-defs.h |2 -- qemu-kvm.c | 30 -- vl.c |2 +- 3 files changed, 13 insertions(+), 21