RE: [PATCH v2] KVM: x86: keep eoi exit bitmap accurate before loading it.

2014-09-03 Thread Wang, Wei W
ng, Wei W; Zhang, Yang Z; kvm@vger.kernel.org > > Cc: alex.william...@redhat.com > > Subject: Re: [PATCH v2] KVM: x86: keep eoi exit bitmap accurate before > > loading it. > > > > Il 28/08/2014 12:14, Wang, Wei W ha scritto: > > > We will do some more tests on

RE: [PATCH v2] KVM: x86: keep eoi exit bitmap accurate before loading it.

2014-08-28 Thread Wang, Wei W
nel.org > Cc: alex.william...@redhat.com > Subject: Re: [PATCH v2] KVM: x86: keep eoi exit bitmap accurate before > loading it. > > Il 28/08/2014 12:14, Wang, Wei W ha scritto: > > We will do some more tests on it to make sure there are no problems. > > No, I don't think ther

Re: [PATCH v2] KVM: x86: keep eoi exit bitmap accurate before loading it.

2014-08-28 Thread Paolo Bonzini
Il 28/08/2014 12:14, Wang, Wei W ha scritto: > We will do some more tests on it to make sure there are no problems. No, I don't think there are any easily-detected practical problems with the patch. But I'm not sure I understand all the theoretical problems and whether possible races are benign.

RE: [PATCH v2] KVM: x86: keep eoi exit bitmap accurate before loading it.

2014-08-28 Thread Wang, Wei W
...@redhat.com Subject: Re: [PATCH v2] KVM: x86: keep eoi exit bitmap accurate before loading it. Il 28/08/2014 08:17, Zhang, Yang Z ha scritto: > > Program edge-triggered MSI for vector 123 > > Interrupt comes in, ISR[123]=1 > > Mask MSI > > Program level-trigge

Re: [PATCH v2] KVM: x86: keep eoi exit bitmap accurate before loading it.

2014-08-28 Thread Paolo Bonzini
Il 28/08/2014 08:17, Zhang, Yang Z ha scritto: > > Program edge-triggered MSI for vector 123 > > Interrupt comes in, ISR[123]=1 > > Mask MSI > > Program level-triggered IOAPIC interrupt for vector 123 > > You cannot assign the vector 123 to another trigger mode interrupt > before p

RE: [PATCH v2] KVM: x86: keep eoi exit bitmap accurate before loading it.

2014-08-27 Thread Zhang, Yang Z
Paolo Bonzini wrote on 2014-08-27: > Il 27/08/2014 16:05, Wei Wang ha scritto: > > Guest may mask the IOAPIC entry before issue EOI. In such case, EOI > > will not be intercepted by the hypervisor, since the corresponding bit > > in eoi_exit_bitmap is not set after the masking of IOAPIC entry. > >

Re: [PATCH v2] KVM: x86: keep eoi exit bitmap accurate before loading it.

2014-08-27 Thread Paolo Bonzini
Il 27/08/2014 16:05, Wei Wang ha scritto: > Guest may mask the IOAPIC entry before issue EOI. In such case, > EOI will not be intercepted by the hypervisor, since the corresponding > bit in eoi_exit_bitmap is not set after the masking of IOAPIC entry. > > The solution here is to OR eoi_exit_bitmap

[PATCH v2] KVM: x86: keep eoi exit bitmap accurate before loading it.

2014-08-26 Thread Wei Wang
Guest may mask the IOAPIC entry before issue EOI. In such case, EOI will not be intercepted by the hypervisor, since the corresponding bit in eoi_exit_bitmap is not set after the masking of IOAPIC entry. The solution here is to OR eoi_exit_bitmap with tmr to make sure that all level-triggered inte