Re: [PATCH RFC v2 3/4] Break dependency between vcpu index in vcpus array and vcpu_id.

2009-05-26 Thread Avi Kivity
Gleb Natapov wrote: Don't the vcpu ioctls need to be updated? They get the vcpu id as a parameter. Are you sure they do? vcpu ioctls are issued on vcpu fd, no need to pass vcpu id as a parameter. You're right, I was confused with an earlier version of the interface, and with

Re: [PATCH RFC v2 3/4] Break dependency between vcpu index in vcpus array and vcpu_id.

2009-05-26 Thread Gleb Natapov
On Tue, May 26, 2009 at 11:34:01AM +0300, Avi Kivity wrote: > Gleb Natapov wrote: >> Archs are free to use vcpu_id as they see fit. For x86 it is used as >> vcpu's apic id. >> >> > > You need a KVM_CAP to inform userspace that the vcpu id has changed meaning. > Will add. >> inline int kvm_is_m

Re: [PATCH RFC v2 3/4] Break dependency between vcpu index in vcpus array and vcpu_id.

2009-05-26 Thread Avi Kivity
Gleb Natapov wrote: Archs are free to use vcpu_id as they see fit. For x86 it is used as vcpu's apic id. You need a KVM_CAP to inform userspace that the vcpu id has changed meaning. inline int kvm_is_mmio_pfn(pfn_t pfn) { if (pfn_valid(pfn)) { @@ -1713,15 +1708,12 @@ static int

[PATCH RFC v2 3/4] Break dependency between vcpu index in vcpus array and vcpu_id.

2009-05-25 Thread Gleb Natapov
Archs are free to use vcpu_id as they see fit. For x86 it is used as vcpu's apic id. Signed-off-by: Gleb Natapov --- include/linux/kvm_host.h |1 + virt/kvm/kvm_main.c | 45 - 2 files changed, 25 insertions(+), 21 deletions(-) diff --git a/