Re: [PATCH RFC] virtio-pci: share config interrupt between virtio devices

2014-09-23 Thread Stefan Fritsch
On Sunday 21 September 2014 13:21:06, Michael S. Tsirkin wrote: > On Sun, Sep 21, 2014 at 11:36:44AM +0200, Stefan Fritsch wrote: > > On Sunday 21 September 2014 11:09:14, Michael S. Tsirkin wrote: > > > On Thu, Sep 18, 2014 at 09:18:37PM +0200, Stefan Fritsch wrote: > > > > On Monday 01 September

Re: [PATCH RFC] virtio-pci: share config interrupt between virtio devices

2014-09-21 Thread Michael S. Tsirkin
On Sun, Sep 21, 2014 at 11:19:36AM -0400, Sasha Levin wrote: > On 09/21/2014 11:02 AM, Michael S. Tsirkin wrote: > > On Sun, Sep 21, 2014 at 09:47:51AM -0400, Sasha Levin wrote: > >> > On 09/21/2014 04:09 AM, Michael S. Tsirkin wrote: > > >> The virtio 0.9.5 spec says that ISR is "unused" when

Re: [PATCH RFC] virtio-pci: share config interrupt between virtio devices

2014-09-21 Thread Sasha Levin
On 09/21/2014 11:02 AM, Michael S. Tsirkin wrote: > On Sun, Sep 21, 2014 at 09:47:51AM -0400, Sasha Levin wrote: >> > On 09/21/2014 04:09 AM, Michael S. Tsirkin wrote: > >> The virtio 0.9.5 spec says that ISR is "unused" when in MSI-X mode. I > > >> > don't think that you can depend on th

Re: [PATCH RFC] virtio-pci: share config interrupt between virtio devices

2014-09-21 Thread Michael S. Tsirkin
On Sun, Sep 21, 2014 at 09:47:51AM -0400, Sasha Levin wrote: > On 09/21/2014 04:09 AM, Michael S. Tsirkin wrote: > >> The virtio 0.9.5 spec says that ISR is "unused" when in MSI-X mode. I > >> > don't think that you can depend on the device to set the configuration > >> > changed bit. > >> > The

Re: [PATCH RFC] virtio-pci: share config interrupt between virtio devices

2014-09-21 Thread Sasha Levin
On 09/21/2014 04:09 AM, Michael S. Tsirkin wrote: >> The virtio 0.9.5 spec says that ISR is "unused" when in MSI-X mode. I >> > don't think that you can depend on the device to set the configuration >> > changed bit. >> > The virtio 1.0 spec seems to have fixed that. > Yes, virtio 0.9.5 has this

Re: [PATCH RFC] virtio-pci: share config interrupt between virtio devices

2014-09-21 Thread Michael S. Tsirkin
On Sun, Sep 21, 2014 at 11:36:44AM +0200, Stefan Fritsch wrote: > On Sunday 21 September 2014 11:09:14, Michael S. Tsirkin wrote: > > On Thu, Sep 18, 2014 at 09:18:37PM +0200, Stefan Fritsch wrote: > > > On Monday 01 September 2014 09:37:30, Michael S. Tsirkin wrote: > > > > Why do we need INT#x? >

Re: [PATCH RFC] virtio-pci: share config interrupt between virtio devices

2014-09-21 Thread Stefan Fritsch
On Sunday 21 September 2014 11:09:14, Michael S. Tsirkin wrote: > On Thu, Sep 18, 2014 at 09:18:37PM +0200, Stefan Fritsch wrote: > > On Monday 01 September 2014 09:37:30, Michael S. Tsirkin wrote: > > > Why do we need INT#x? > > > How about setting IRQF_SHARED for the config interrupt > > > while

Re: [PATCH RFC] virtio-pci: share config interrupt between virtio devices

2014-09-21 Thread Michael S. Tsirkin
On Thu, Sep 18, 2014 at 09:18:37PM +0200, Stefan Fritsch wrote: > On Monday 01 September 2014 09:37:30, Michael S. Tsirkin wrote: > > Why do we need INT#x? > > How about setting IRQF_SHARED for the config interrupt > > while using MSI-X? You'd have to read ISR to check that the > > interrupt was in

Re: [PATCH RFC] virtio-pci: share config interrupt between virtio devices

2014-09-18 Thread Stefan Fritsch
On Monday 01 September 2014 09:37:30, Michael S. Tsirkin wrote: > Why do we need INT#x? > How about setting IRQF_SHARED for the config interrupt > while using MSI-X? You'd have to read ISR to check that the > interrupt was intended for your device. The virtio 0.9.5 spec says that ISR is "unused" w

Re: [PATCH RFC] virtio-pci: share config interrupt between virtio devices

2014-09-01 Thread Michael S. Tsirkin
On Mon, Sep 01, 2014 at 03:58:02PM +0800, Amos Kong wrote: > On Mon, Sep 01, 2014 at 09:37:30AM +0300, Michael S. Tsirkin wrote: > > > > Hi Michael, > > > On Mon, Sep 01, 2014 at 01:41:54PM +0800, Amos Kong wrote: > > > One VM only has 128 msix interrupt, virtio-config interrupt > > > has less wo

Re: [PATCH RFC] virtio-pci: share config interrupt between virtio devices

2014-09-01 Thread Amos Kong
On Mon, Sep 01, 2014 at 09:37:30AM +0300, Michael S. Tsirkin wrote: > Hi Michael, > On Mon, Sep 01, 2014 at 01:41:54PM +0800, Amos Kong wrote: > > One VM only has 128 msix interrupt, virtio-config interrupt > > has less workload. This patch shares one normal interrupt Thanks for your quick reply

Re: [PATCH RFC] virtio-pci: share config interrupt between virtio devices

2014-08-31 Thread Michael S. Tsirkin
On Mon, Sep 01, 2014 at 01:41:54PM +0800, Amos Kong wrote: > One VM only has 128 msix interrupt, virtio-config interrupt > has less workload. This patch shares one normal interrupt normal == INT#x? Please don't call it normal. The proper name is "legacy INT#x". So you are trying to use legacy INT

[PATCH RFC] virtio-pci: share config interrupt between virtio devices

2014-08-31 Thread Amos Kong
One VM only has 128 msix interrupt, virtio-config interrupt has less workload. This patch shares one normal interrupt for configuration between virtio devices. Signed-off-by: Amos Kong --- drivers/virtio/virtio_pci.c | 41 - 1 file changed, 16 insertions(+