Re: [PATCH 6/8] KVM: PPC: E500: Implement MMU notifiers

2012-08-08 Thread Alexander Graf
On 08.08.2012, at 05:31, Paul Mackerras wrote: > On Tue, Aug 07, 2012 at 12:57:14PM +0200, Alexander Graf wrote: >> The e500 target has lived without mmu notifiers ever since it got >> introduced, but fails for the user space check on them with hugetlbfs. > > Ironically that user space check i

Re: [PATCH 6/8] KVM: PPC: E500: Implement MMU notifiers

2012-08-08 Thread Paul Mackerras
On Tue, Aug 07, 2012 at 12:57:14PM +0200, Alexander Graf wrote: > The e500 target has lived without mmu notifiers ever since it got > introduced, but fails for the user space check on them with hugetlbfs. Ironically that user space check isn't necessary any more since David Gibson's fix for the hu

Re: [PATCH 6/8] KVM: PPC: E500: Implement MMU notifiers

2012-08-07 Thread Alexander Graf
On 07.08.2012, at 16:14, Avi Kivity wrote: > On 08/07/2012 04:52 PM, Alexander Graf wrote: +/* MMU Notifiers */ + +int kvm_unmap_hva(struct kvm *kvm, unsigned long hva) +{ +/* Is this a guest page? */ +if (!hva_to_memslot(kvm,

Re: [PATCH 6/8] KVM: PPC: E500: Implement MMU notifiers

2012-08-07 Thread Avi Kivity
On 08/07/2012 04:52 PM, Alexander Graf wrote: >>> >>> +/* MMU Notifiers */ >>> + >>> +int kvm_unmap_hva(struct kvm *kvm, unsigned long hva) >>> +{ >>> +/* Is this a guest page? */ >>> +if (!hva_to_memslot(kvm, hva)) >>> +return 0; >>> + >>> +/* >>> +

Re: [PATCH 6/8] KVM: PPC: E500: Implement MMU notifiers

2012-08-07 Thread Alexander Graf
On 07.08.2012, at 15:30, Avi Kivity wrote: > On 08/07/2012 01:57 PM, Alexander Graf wrote: >> The e500 target has lived without mmu notifiers ever since it got >> introduced, but fails for the user space check on them with hugetlbfs. >> >> So in order to get that one working, implement mmu not

Re: [PATCH 6/8] KVM: PPC: E500: Implement MMU notifiers

2012-08-07 Thread Avi Kivity
On 08/07/2012 01:57 PM, Alexander Graf wrote: > The e500 target has lived without mmu notifiers ever since it got > introduced, but fails for the user space check on them with hugetlbfs. > > So in order to get that one working, implement mmu notifiers in a > reasonably dumb fashion and be happy. O

[PATCH 6/8] KVM: PPC: E500: Implement MMU notifiers

2012-08-07 Thread Alexander Graf
The e500 target has lived without mmu notifiers ever since it got introduced, but fails for the user space check on them with hugetlbfs. So in order to get that one working, implement mmu notifiers in a reasonably dumb fashion and be happy. On embedded hardware, we almost never end up with mmu not