Re: [PATCH 5/5] KVM: assigned dev: MSI-X mask support

2010-11-09 Thread Marcelo Tosatti
On Mon, Nov 08, 2010 at 01:41:40PM +0800, Sheng Yang wrote: > On Saturday 06 November 2010 08:24:51 Marcelo Tosatti wrote: > > On Fri, Nov 05, 2010 at 06:53:50PM +0800, Sheng Yang wrote: > > > On Friday 05 November 2010 16:43:33 Michael S. Tsirkin wrote: > > > > On Fri, Nov 05, 2010 at 10:44:19AM +

Re: [PATCH 5/5] KVM: assigned dev: MSI-X mask support

2010-11-07 Thread Michael S. Tsirkin
On Mon, Nov 08, 2010 at 11:18:34AM +0800, Sheng Yang wrote: > On Friday 05 November 2010 21:27:42 Michael S. Tsirkin wrote: > > On Fri, Nov 05, 2010 at 06:53:50PM +0800, Sheng Yang wrote: > > > On Friday 05 November 2010 16:43:33 Michael S. Tsirkin wrote: > > > > On Fri, Nov 05, 2010 at 10:44:19AM

Re: [PATCH 5/5] KVM: assigned dev: MSI-X mask support

2010-11-07 Thread Sheng Yang
On Saturday 06 November 2010 08:24:51 Marcelo Tosatti wrote: > On Fri, Nov 05, 2010 at 06:53:50PM +0800, Sheng Yang wrote: > > On Friday 05 November 2010 16:43:33 Michael S. Tsirkin wrote: > > > On Fri, Nov 05, 2010 at 10:44:19AM +0800, Sheng Yang wrote: > > > > > > +}; > > > > > > + > > > > > > +T

Re: [PATCH 5/5] KVM: assigned dev: MSI-X mask support

2010-11-07 Thread Sheng Yang
On Friday 05 November 2010 21:27:42 Michael S. Tsirkin wrote: > On Fri, Nov 05, 2010 at 06:53:50PM +0800, Sheng Yang wrote: > > On Friday 05 November 2010 16:43:33 Michael S. Tsirkin wrote: > > > On Fri, Nov 05, 2010 at 10:44:19AM +0800, Sheng Yang wrote: > > > > > > +}; > > > > > > + > > > > > > +

Re: [PATCH 5/5] KVM: assigned dev: MSI-X mask support

2010-11-05 Thread Marcelo Tosatti
On Fri, Nov 05, 2010 at 06:53:50PM +0800, Sheng Yang wrote: > On Friday 05 November 2010 16:43:33 Michael S. Tsirkin wrote: > > On Fri, Nov 05, 2010 at 10:44:19AM +0800, Sheng Yang wrote: > > > > > +}; > > > > > + > > > > > +This ioctl would enable in-kernel MSI-X emulation, which would > > > > > h

Re: [PATCH 5/5] KVM: assigned dev: MSI-X mask support

2010-11-05 Thread Michael S. Tsirkin
On Fri, Nov 05, 2010 at 08:01:53PM +0800, Sheng Yang wrote: > > Go back to me if someone want to implement MSI device assignment on > > big-endian machine. > > Sorry, just realized it's very likely that I don't have an big endian machine > to > test it even at that time... > > I think it's real

Re: [PATCH 5/5] KVM: assigned dev: MSI-X mask support

2010-11-05 Thread Michael S. Tsirkin
On Fri, Nov 05, 2010 at 06:53:50PM +0800, Sheng Yang wrote: > On Friday 05 November 2010 16:43:33 Michael S. Tsirkin wrote: > > On Fri, Nov 05, 2010 at 10:44:19AM +0800, Sheng Yang wrote: > > > > > +}; > > > > > + > > > > > +This ioctl would enable in-kernel MSI-X emulation, which would > > > > > h

Re: [PATCH 5/5] KVM: assigned dev: MSI-X mask support

2010-11-05 Thread Sheng Yang
On Friday 05 November 2010 18:53:50 Sheng Yang wrote: > On Friday 05 November 2010 16:43:33 Michael S. Tsirkin wrote: > > On Fri, Nov 05, 2010 at 10:44:19AM +0800, Sheng Yang wrote: > > > > > +}; > > > > > + > > > > > +This ioctl would enable in-kernel MSI-X emulation, which would > > > > > handle

Re: [PATCH 5/5] KVM: assigned dev: MSI-X mask support

2010-11-05 Thread Sheng Yang
On Friday 05 November 2010 16:51:33 Michael S. Tsirkin wrote: > On Fri, Nov 05, 2010 at 03:16:23PM +0800, Sheng Yang wrote: > > This patch enable per-vector mask for assigned devices using MSI-X. > > > > This patch provided two new APIs: one is for guest to specific device's > > MSI-X table addres

Re: [PATCH 5/5] KVM: assigned dev: MSI-X mask support

2010-11-05 Thread Sheng Yang
On Friday 05 November 2010 16:43:33 Michael S. Tsirkin wrote: > On Fri, Nov 05, 2010 at 10:44:19AM +0800, Sheng Yang wrote: > > > > +}; > > > > + > > > > +This ioctl would enable in-kernel MSI-X emulation, which would > > > > handle MSI-X +mask bit in the kernel. > > > > > > What happens on repeat

Re: [PATCH 5/5] KVM: assigned dev: MSI-X mask support

2010-11-05 Thread Michael S. Tsirkin
On Fri, Nov 05, 2010 at 03:16:23PM +0800, Sheng Yang wrote: > This patch enable per-vector mask for assigned devices using MSI-X. > > This patch provided two new APIs: one is for guest to specific device's MSI-X > table address in MMIO, the other is for userspace to get information about > mask >

Re: [PATCH 5/5] KVM: assigned dev: MSI-X mask support

2010-11-05 Thread Michael S. Tsirkin
On Fri, Nov 05, 2010 at 10:44:19AM +0800, Sheng Yang wrote: > > > +}; > > > + > > > +This ioctl would enable in-kernel MSI-X emulation, which would handle > > > MSI-X +mask bit in the kernel. > > > > What happens on repeated calls when it's already enabled? > > How does one disable after it's enab

[PATCH 5/5] KVM: assigned dev: MSI-X mask support

2010-11-05 Thread Sheng Yang
This patch enable per-vector mask for assigned devices using MSI-X. This patch provided two new APIs: one is for guest to specific device's MSI-X table address in MMIO, the other is for userspace to get information about mask bit. All the mask bit operation are kept in kernel, in order to acceler

Re: [PATCH 5/5] KVM: assigned dev: MSI-X mask support

2010-11-04 Thread Sheng Yang
On Friday 05 November 2010 10:44:19 Sheng Yang wrote: > On Thursday 04 November 2010 18:43:22 Michael S. Tsirkin wrote: > > On Thu, Nov 04, 2010 at 02:15:21PM +0800, Sheng Yang wrote: > > > This patch enable per-vector mask for assigned devices using MSI-X. > > > > > > This patch provided two new

Re: [PATCH 5/5] KVM: assigned dev: MSI-X mask support

2010-11-04 Thread Sheng Yang
On Thursday 04 November 2010 18:43:22 Michael S. Tsirkin wrote: > On Thu, Nov 04, 2010 at 02:15:21PM +0800, Sheng Yang wrote: > > This patch enable per-vector mask for assigned devices using MSI-X. > > > > This patch provided two new APIs: one is for guest to specific device's > > MSI-X table addr

Re: [PATCH 5/5] KVM: assigned dev: MSI-X mask support

2010-11-04 Thread Michael S. Tsirkin
On Thu, Nov 04, 2010 at 02:15:21PM +0800, Sheng Yang wrote: > This patch enable per-vector mask for assigned devices using MSI-X. > > This patch provided two new APIs: one is for guest to specific device's MSI-X > table address in MMIO, the other is for userspace to get information about > mask >

[PATCH 5/5] KVM: assigned dev: MSI-X mask support

2010-11-03 Thread Sheng Yang
This patch enable per-vector mask for assigned devices using MSI-X. This patch provided two new APIs: one is for guest to specific device's MSI-X table address in MMIO, the other is for userspace to get information about mask bit. All the mask bit operation are kept in kernel, in order to acceler