Re: [PATCH 4/7] KVM: arm64: guest debug, add SW break point support

2014-12-01 Thread Alex Bennée
Christoffer Dall writes: > On Tue, Nov 25, 2014 at 04:10:02PM +, Alex Bennée wrote: >> This adds support for SW breakpoints inserted by userspace. >> >> First we need to trap all BKPT exceptions in the hypervisor (ELS). This >> in controlled through the MDCR_EL2 register. I've added a new f

Re: [PATCH 4/7] KVM: arm64: guest debug, add SW break point support

2014-11-29 Thread Christoffer Dall
On Tue, Nov 25, 2014 at 04:10:02PM +, Alex Bennée wrote: > This adds support for SW breakpoints inserted by userspace. > > First we need to trap all BKPT exceptions in the hypervisor (ELS). This > in controlled through the MDCR_EL2 register. I've added a new field to this is ? > the vcpu str

Re: [PATCH 4/7] KVM: arm64: guest debug, add SW break point support

2014-11-29 Thread Christoffer Dall
On Wed, Nov 26, 2014 at 05:07:20PM +0100, Andrew Jones wrote: > On Tue, Nov 25, 2014 at 04:10:02PM +, Alex Bennée wrote: > > This adds support for SW breakpoints inserted by userspace. > > > > First we need to trap all BKPT exceptions in the hypervisor (ELS). This > > in controlled through the

Re: [PATCH 4/7] KVM: arm64: guest debug, add SW break point support

2014-11-26 Thread Peter Maydell
On 26 November 2014 at 16:07, Andrew Jones wrote: > There appears to be a typo in the ARM ARM. Subsection "Software > Breakpoint Instruction exception" of D1.10.4 says BRK (ESR_EL2_EC_BRK64) > is 0x39, but the table above that has it correctly as 0x3c. Thanks for pointing out this typo -- I've re

Re: [PATCH 4/7] KVM: arm64: guest debug, add SW break point support

2014-11-26 Thread Andrew Jones
On Tue, Nov 25, 2014 at 04:10:02PM +, Alex Bennée wrote: > This adds support for SW breakpoints inserted by userspace. > > First we need to trap all BKPT exceptions in the hypervisor (ELS). This > in controlled through the MDCR_EL2 register. I've added a new field to > the vcpu structure to ho

[PATCH 4/7] KVM: arm64: guest debug, add SW break point support

2014-11-25 Thread Alex Bennée
This adds support for SW breakpoints inserted by userspace. First we need to trap all BKPT exceptions in the hypervisor (ELS). This in controlled through the MDCR_EL2 register. I've added a new field to the vcpu structure to hold this value. There should be scope to rationlise this with the VCPU_D