Re: [PATCH 3/9] change order of kvm_init call.

2009-07-27 Thread Glauber Costa
On Mon, Jul 27, 2009 at 07:44:27PM +0100, Daniel P. Berrange wrote: > On Mon, Jul 27, 2009 at 03:38:57PM -0300, Glauber Costa wrote: > > On Mon, Jul 27, 2009 at 07:28:17PM +0100, Daniel P. Berrange wrote: > > > On Mon, Jul 27, 2009 at 03:20:08PM -0300, Glauber Costa wrote: > > > > On Mon, Jul 27, 2

Re: [PATCH 3/9] change order of kvm_init call.

2009-07-27 Thread Daniel P. Berrange
On Mon, Jul 27, 2009 at 03:38:57PM -0300, Glauber Costa wrote: > On Mon, Jul 27, 2009 at 07:28:17PM +0100, Daniel P. Berrange wrote: > > On Mon, Jul 27, 2009 at 03:20:08PM -0300, Glauber Costa wrote: > > > On Mon, Jul 27, 2009 at 08:10:24PM +0200, Jan Kiszka wrote: > > > > > > > > I think we shoul

Re: [PATCH 3/9] change order of kvm_init call.

2009-07-27 Thread Anthony Liguori
Glauber Costa wrote: we're not. The issue happens exactly when the kvm modules are not loaded, then we're failing to initialize kvm. However, in the patch that raised this issue, I'm moving KVM initialization to after this code path. And in qemu-kvm.git, kvm is enabled-by-default. So tcg code w

Re: [PATCH 3/9] change order of kvm_init call.

2009-07-27 Thread Glauber Costa
On Mon, Jul 27, 2009 at 07:28:17PM +0100, Daniel P. Berrange wrote: > On Mon, Jul 27, 2009 at 03:20:08PM -0300, Glauber Costa wrote: > > On Mon, Jul 27, 2009 at 08:10:24PM +0200, Jan Kiszka wrote: > > > > > > I think we should simply resolves this the way upstream does: Do not > > > start if modul

Re: [PATCH 3/9] change order of kvm_init call.

2009-07-27 Thread Daniel P. Berrange
On Mon, Jul 27, 2009 at 03:20:08PM -0300, Glauber Costa wrote: > On Mon, Jul 27, 2009 at 08:10:24PM +0200, Jan Kiszka wrote: > > > > I think we should simply resolves this the way upstream does: Do not > > start if modules are missing and -no-kvm is omitted - or even switch > > over to -enable-kvm

Re: [PATCH 3/9] change order of kvm_init call.

2009-07-27 Thread Glauber Costa
On Mon, Jul 27, 2009 at 08:10:24PM +0200, Jan Kiszka wrote: > Glauber Costa wrote: > > On Mon, Jul 27, 2009 at 12:49:06PM -0500, Anthony Liguori wrote: > >> Glauber Costa wrote: > >>> On Sun, Jul 26, 2009 at 08:59:44PM +0200, Jan Kiszka wrote: > >>> > Glauber Costa wrote: > >

Re: [PATCH 3/9] change order of kvm_init call.

2009-07-27 Thread Jan Kiszka
Glauber Costa wrote: > On Mon, Jul 27, 2009 at 12:49:06PM -0500, Anthony Liguori wrote: >> Glauber Costa wrote: >>> On Sun, Jul 26, 2009 at 08:59:44PM +0200, Jan Kiszka wrote: >>> Glauber Costa wrote: > The goal is to get rid of the call to kvm_init. But those things > are

Re: [PATCH 3/9] change order of kvm_init call.

2009-07-27 Thread Glauber Costa
On Mon, Jul 27, 2009 at 12:49:06PM -0500, Anthony Liguori wrote: > Glauber Costa wrote: >> On Sun, Jul 26, 2009 at 08:59:44PM +0200, Jan Kiszka wrote: >> >>> Glauber Costa wrote: >>> The goal is to get rid of the call to kvm_init. But those things are subtle, and often break. So d

Re: [PATCH 3/9] change order of kvm_init call.

2009-07-27 Thread Anthony Liguori
Glauber Costa wrote: On Sun, Jul 26, 2009 at 08:59:44PM +0200, Jan Kiszka wrote: Glauber Costa wrote: The goal is to get rid of the call to kvm_init. But those things are subtle, and often break. So do it in a separate patch, to help finding potential issues in future bisections.

Re: [PATCH 3/9] change order of kvm_init call.

2009-07-27 Thread Glauber Costa
On Sun, Jul 26, 2009 at 08:59:44PM +0200, Jan Kiszka wrote: > Glauber Costa wrote: > > The goal is to get rid of the call to kvm_init. But those things > > are subtle, and often break. So do it in a separate patch, to help > > finding potential issues in future bisections. > > Found such an issued

Re: [PATCH 3/9] change order of kvm_init call.

2009-07-26 Thread Jan Kiszka
Glauber Costa wrote: > The goal is to get rid of the call to kvm_init. But those things > are subtle, and often break. So do it in a separate patch, to help > finding potential issues in future bisections. Found such an issued: This patch triggers a segfault if no kvm modules are loaded and you st

[PATCH 3/9] change order of kvm_init call.

2009-07-20 Thread Glauber Costa
The goal is to get rid of the call to kvm_init. But those things are subtle, and often break. So do it in a separate patch, to help finding potential issues in future bisections. Signed-off-by: Glauber Costa --- vl.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) di