Re: [PATCH 2/5] KVM: MMU: audit: replace mmu audit tracepoint with jump-lable

2011-12-01 Thread Avi Kivity
On 11/30/2011 11:43 AM, Xiao Guangrong wrote: > Subject: [PATCH] KVM: MMU: audit: inline audit function > > inline audit function and little cleanup > > Thanks, applied. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe k

Re: [PATCH 2/5] KVM: MMU: audit: replace mmu audit tracepoint with jump-lable

2011-11-30 Thread Xiao Guangrong
On 11/29/2011 06:02 PM, Avi Kivity wrote: > On 11/29/2011 05:56 AM, Xiao Guangrong wrote: >> Subject: [PATCH v2 2/5] KVM: MMU: audit: replace mmu audit tracepoint with >> jump-lable >> >> The tracepoint is only used to audit mmu code, it should not be exposed to >> user, let us replace it with ju

Re: [PATCH 2/5] KVM: MMU: audit: replace mmu audit tracepoint with jump-lable

2011-11-29 Thread Avi Kivity
On 11/29/2011 05:56 AM, Xiao Guangrong wrote: > Subject: [PATCH v2 2/5] KVM: MMU: audit: replace mmu audit tracepoint with > jump-lable > > The tracepoint is only used to audit mmu code, it should not be exposed to > user, let us replace it with jump-lable > > > static bool mmu_audit; > +static s

Re: [PATCH 2/5] KVM: MMU: audit: replace mmu audit tracepoint with jump-lable

2011-11-28 Thread Xiao Guangrong
On 11/29/2011 06:33 AM, Jason Baron wrote: > hmmm..this always going to do a call to 'kvm_mmu_audit' and then return. > I think you want to avoid the function call altogether. You could do > something like: > > #define kvm_mmu_audit() > if (static_branch((&mmu_audit_key))) { >

Re: [PATCH 2/5] KVM: MMU: audit: replace mmu audit tracepoint with jump-lable

2011-11-28 Thread Jason Baron
On Mon, Nov 28, 2011 at 08:41:00PM +0800, Xiao Guangrong wrote: > +static void kvm_mmu_audit(struct kvm_vcpu *vcpu, int point) > { > static DEFINE_RATELIMIT_STATE(ratelimit_state, 5 * HZ, 10); > > - if (!__ratelimit(&ratelimit_state)) > - return; > + if (static_branch((&

[PATCH 2/5] KVM: MMU: audit: replace mmu audit tracepoint with jump-lable

2011-11-28 Thread Xiao Guangrong
The tracepoint is only used to audit mmu code, it should not be exposed to user, let us replace it with jump-lable Signed-off-by: Xiao Guangrong --- arch/x86/kvm/mmu.c | 16 +++- arch/x86/kvm/mmu_audit.c | 28 +--- arch/x86/kvm/mmutrace.h|