Re: [PATCH 1/5] vfio-pci: Allow PCI IDs to be specified as module options

2015-03-11 Thread Bjorn Helgaas
On Wed, Mar 11, 2015 at 3:14 PM, Alex Williamson wrote: > On Fri, 2015-03-06 at 16:11 -0600, Bjorn Helgaas wrote: >> On Wed, Mar 04, 2015 at 01:02:43PM -0700, Alex Williamson wrote: >> > This copies the same support from pci-stub for exactly the same >> > purpose, enabling a set of PCI IDs to be a

Re: [PATCH 1/5] vfio-pci: Allow PCI IDs to be specified as module options

2015-03-11 Thread Alex Williamson
On Fri, 2015-03-06 at 16:11 -0600, Bjorn Helgaas wrote: > On Wed, Mar 04, 2015 at 01:02:43PM -0700, Alex Williamson wrote: > > This copies the same support from pci-stub for exactly the same > > purpose, enabling a set of PCI IDs to be automatically added to the > > driver's dynamic ID table at mod

Re: [PATCH 1/5] vfio-pci: Allow PCI IDs to be specified as module options

2015-03-06 Thread Bjorn Helgaas
On Wed, Mar 04, 2015 at 01:02:43PM -0700, Alex Williamson wrote: > This copies the same support from pci-stub for exactly the same > purpose, enabling a set of PCI IDs to be automatically added to the > driver's dynamic ID table at module load time. The code here is > pretty simple and both vfio-p

Re: [PATCH 1/5] vfio-pci: Allow PCI IDs to be specified as module options

2015-03-04 Thread Alex Williamson
On Wed, 2015-03-04 at 17:32 -0500, Bandan Das wrote: > Alex Williamson writes: > > > On Wed, 2015-03-04 at 15:49 -0500, Bandan Das wrote: > >> Hi Alex, > >> > >> Alex Williamson writes: > >> ... > >> > +if (fields < 2) { > >> > +pr_warn("vfio-pci: invalid

Re: [PATCH 1/5] vfio-pci: Allow PCI IDs to be specified as module options

2015-03-04 Thread Bandan Das
Alex Williamson writes: > On Wed, 2015-03-04 at 15:49 -0500, Bandan Das wrote: >> Hi Alex, >> >> Alex Williamson writes: >> ... >> > + if (fields < 2) { >> > + pr_warn("vfio-pci: invalid id string \"%s\"\n", id); >> > + continue; >> > + } >> >

Re: [PATCH 1/5] vfio-pci: Allow PCI IDs to be specified as module options

2015-03-04 Thread Alex Williamson
On Wed, 2015-03-04 at 15:49 -0500, Bandan Das wrote: > Hi Alex, > > Alex Williamson writes: > ... > > + if (fields < 2) { > > + pr_warn("vfio-pci: invalid id string \"%s\"\n", id); > > + continue; > > + } > > + > > + pr_info("vfio-

Re: [PATCH 1/5] vfio-pci: Allow PCI IDs to be specified as module options

2015-03-04 Thread Bandan Das
Hi Alex, Alex Williamson writes: ... > + if (fields < 2) { > + pr_warn("vfio-pci: invalid id string \"%s\"\n", id); > + continue; > + } > + > + pr_info("vfio-pci: add %04X:%04X sub=%04X:%04X cls=%08X/%08X\n", > +

[PATCH 1/5] vfio-pci: Allow PCI IDs to be specified as module options

2015-03-04 Thread Alex Williamson
This copies the same support from pci-stub for exactly the same purpose, enabling a set of PCI IDs to be automatically added to the driver's dynamic ID table at module load time. The code here is pretty simple and both vfio-pci and pci-stub are fairly unique in being meta drivers, capable of attac