Re: [PATCH 1/5] Protect irq_sources_bitmap by kvm->lock instead of kvm->irq_lock

2009-07-13 Thread Gleb Natapov
On Mon, Jul 13, 2009 at 11:03:56AM -0400, Gregory Haskins wrote: > Gleb Natapov wrote: > > On Mon, Jul 13, 2009 at 10:29:02AM -0400, Gregory Haskins wrote: > > > >> Gleb Natapov wrote: > >> > >>> diff --git a/virt/kvm/irq_comm.c b/virt/kvm/irq_comm.c > >>> index 6c57e46..ce8fcd3 100644 > >>

Re: [PATCH 1/5] Protect irq_sources_bitmap by kvm->lock instead of kvm->irq_lock

2009-07-13 Thread Gregory Haskins
Gregory Haskins wrote: > Gleb Natapov wrote: > >> On Mon, Jul 13, 2009 at 10:29:02AM -0400, Gregory Haskins wrote: >> >> >>> Gleb Natapov wrote: >>> >>> diff --git a/virt/kvm/irq_comm.c b/virt/kvm/irq_comm.c index 6c57e46..ce8fcd3 100644 --- a/virt/kvm/irq_comm

Re: [PATCH 1/5] Protect irq_sources_bitmap by kvm->lock instead of kvm->irq_lock

2009-07-13 Thread Gregory Haskins
Gleb Natapov wrote: > On Mon, Jul 13, 2009 at 10:29:02AM -0400, Gregory Haskins wrote: > >> Gleb Natapov wrote: >> >>> diff --git a/virt/kvm/irq_comm.c b/virt/kvm/irq_comm.c >>> index 6c57e46..ce8fcd3 100644 >>> --- a/virt/kvm/irq_comm.c >>> +++ b/virt/kvm/irq_comm.c >>> @@ -210,7 +210,8 @@

Re: [PATCH 1/5] Protect irq_sources_bitmap by kvm->lock instead of kvm->irq_lock

2009-07-13 Thread Gleb Natapov
On Mon, Jul 13, 2009 at 05:55:09PM +0300, Michael S. Tsirkin wrote: > On Mon, Jul 13, 2009 at 05:39:41PM +0300, Gleb Natapov wrote: > > On Mon, Jul 13, 2009 at 10:29:02AM -0400, Gregory Haskins wrote: > > > Gleb Natapov wrote: > > > > It is already protected by kvm->lock on device assignment path.

Re: [PATCH 1/5] Protect irq_sources_bitmap by kvm->lock instead of kvm->irq_lock

2009-07-13 Thread Michael S. Tsirkin
On Mon, Jul 13, 2009 at 05:39:41PM +0300, Gleb Natapov wrote: > On Mon, Jul 13, 2009 at 10:29:02AM -0400, Gregory Haskins wrote: > > Gleb Natapov wrote: > > > It is already protected by kvm->lock on device assignment path. Just > > > take the same lock in the PIT code. > > > > > > Signed-off-by: Gl

Re: [PATCH 1/5] Protect irq_sources_bitmap by kvm->lock instead of kvm->irq_lock

2009-07-13 Thread Gleb Natapov
On Mon, Jul 13, 2009 at 10:29:02AM -0400, Gregory Haskins wrote: > Gleb Natapov wrote: > > It is already protected by kvm->lock on device assignment path. Just > > take the same lock in the PIT code. > > > > Signed-off-by: Gleb Natapov > > --- > > arch/x86/kvm/i8254.c |2 ++ > > virt/kvm/irq_

Re: [PATCH 1/5] Protect irq_sources_bitmap by kvm->lock instead of kvm->irq_lock

2009-07-13 Thread Gregory Haskins
Gleb Natapov wrote: > It is already protected by kvm->lock on device assignment path. Just > take the same lock in the PIT code. > > Signed-off-by: Gleb Natapov > --- > arch/x86/kvm/i8254.c |2 ++ > virt/kvm/irq_comm.c |8 > 2 files changed, 6 insertions(+), 4 deletions(-) > > d

[PATCH 1/5] Protect irq_sources_bitmap by kvm->lock instead of kvm->irq_lock

2009-07-13 Thread Gleb Natapov
It is already protected by kvm->lock on device assignment path. Just take the same lock in the PIT code. Signed-off-by: Gleb Natapov --- arch/x86/kvm/i8254.c |2 ++ virt/kvm/irq_comm.c |8 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/arch/x86/kvm/i8254.c b/arc