[PATCH 1/4] i8254: Factor out base class for KVM reuse

2012-02-05 Thread Jan Kiszka
From: Jan Kiszka Applying the concept used for the *PICs once again: establish a base class for the i8254 that can be used both by the current user space emulation and the upcoming KVM in-kernel version. We share most of the public interface of the i8254, specifically to the pcspk, vmstate, reset

Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse

2012-02-01 Thread Anthony Liguori
On 02/01/2012 06:43 AM, Jan Kiszka wrote: On 2012-02-01 13:23, Paolo Bonzini wrote: On 01/31/2012 10:49 PM, Jan Kiszka wrote: Just make the methods that you want to override virtual with the default implementation and then make a KVMPIT that inherits from the PIT and then overrides whatev

Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse

2012-02-01 Thread Jan Kiszka
On 2012-02-01 14:10, Jan Kiszka wrote: > On 2012-02-01 13:55, Paolo Bonzini wrote: >> On 02/01/2012 01:43 PM, Jan Kiszka wrote: It looks good, besides the need to rebase to Anthony's "part 3" changes. >>> Given that this part is not upstream and that the relevant conversion is >>> scripted, I

Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse

2012-02-01 Thread Jan Kiszka
On 2012-02-01 13:55, Paolo Bonzini wrote: > On 02/01/2012 01:43 PM, Jan Kiszka wrote: >>> It looks good, besides the need to rebase to Anthony's "part 3" changes. >> Given that this part is not upstream and that the relevant conversion is >> scripted, I would leave this to Anthony so far. Or what

Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse

2012-02-01 Thread Paolo Bonzini
On 02/01/2012 01:43 PM, Jan Kiszka wrote: > It looks good, besides the need to rebase to Anthony's "part 3" changes. Given that this part is not upstream and that the relevant conversion is scripted, I would leave this to Anthony so far. Or what is the schedule? By the time your series is revi

Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse

2012-02-01 Thread Jan Kiszka
On 2012-02-01 13:23, Paolo Bonzini wrote: > On 01/31/2012 10:49 PM, Jan Kiszka wrote: >>> Just make the methods that you want to override virtual with the default >>> implementation and then make a KVMPIT that inherits from the PIT and >>> then overrides whatever virtual functions it needs to. >

Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse

2012-02-01 Thread Paolo Bonzini
On 01/31/2012 10:49 PM, Jan Kiszka wrote: > Just make the methods that you want to override virtual with the default > implementation and then make a KVMPIT that inherits from the PIT and > then overrides whatever virtual functions it needs to. That doesn't sound like the proper design for th

Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse

2012-01-31 Thread Anthony Liguori
On 01/31/2012 03:49 PM, Jan Kiszka wrote: On 2012-01-31 22:40, Anthony Liguori wrote: On 01/31/2012 12:46 PM, Jan Kiszka wrote: Applying the concept used for the *PICs once again: establish a base class for the i8254 that can be used both by the current user space emulation and the upcoming KVM

Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse

2012-01-31 Thread Jan Kiszka
On 2012-01-31 22:40, Anthony Liguori wrote: > On 01/31/2012 12:46 PM, Jan Kiszka wrote: >> Applying the concept used for the *PICs once again: establish a base >> class for the i8254 that can be used both by the current user space >> emulation and the upcoming KVM in-kernel version. We share most o

Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse

2012-01-31 Thread Anthony Liguori
On 01/31/2012 12:46 PM, Jan Kiszka wrote: Applying the concept used for the *PICs once again: establish a base class for the i8254 that can be used both by the current user space emulation and the upcoming KVM in-kernel version. We share most of the public interface of the i8254, specifically to

[PATCH 1/4] i8254: Factor out base class for KVM reuse

2012-01-31 Thread Jan Kiszka
Applying the concept used for the *PICs once again: establish a base class for the i8254 that can be used both by the current user space emulation and the upcoming KVM in-kernel version. We share most of the public interface of the i8254, specifically to the pcspk, vmstate, reset and certain init p