Re: [PATCH 01/12] Add kernel header update script

2011/6/8 Jan Kiszka : > On 2011-06-08 16:33, Peter Maydell wrote: >> On 8 June 2011 15:10, Jan Kiszka wrote: >>> +tmpdir=$TMPDIR/.tmp-hdrs-$$ >> >> Better (safer) to use mktemp, I think. > > Is that portable? I don't think so. We don't expect every random end user to run this script, though, righ

Re: [PATCH 01/12] Add kernel header update script

On 2011-06-08 16:33, Peter Maydell wrote: > On 8 June 2011 15:10, Jan Kiszka wrote: >> --- /dev/null >> +++ b/scripts/update-linux-headers.sh >> @@ -0,0 +1,55 @@ >> +#!/bin/sh -e >> +# > >> +if [ -z "$output" ]; then >> +output=$PWD >> +fi > >> +mkdir -p $output/linux-headers/asm-$arch >

Re: [PATCH 01/12] Add kernel header update script

On 8 June 2011 15:10, Jan Kiszka wrote: > --- /dev/null > +++ b/scripts/update-linux-headers.sh > @@ -0,0 +1,55 @@ > +#!/bin/sh -e > +# > +if [ -z "$output" ]; then > +    output=$PWD > +fi > +    mkdir -p $output/linux-headers/asm-$arch This script is rather lacking in quoting throughout. As a

[PATCH 01/12] Add kernel header update script

This helper pulls the required kernel headers for KVM and vhost into a specified directory. The update is triggered via scripts/update-linux-headers.sh LINUX_PATH and will place the output under linux-headers/linux and linux-headers/asm-*. It also imports the COPYING to care for headers witho