Re: [PATCH 2/2] seabios: fix mptable nmi entry (was: Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi)

2011-10-30 Thread Kevin O'Connor
On Mon, Oct 10, 2011 at 02:06:29PM +0800, Lai Jiangshan wrote: > From: Kenji Kaneshige > > In the current seabios MP table description, NMI is connected only to > BSP's LINT1. But usually NMI is connected to all the CPUs' LINT1 as > indicated in MP specification. This patch changes seabios MP tab

[PATCH 2/2] seabios: fix mptable nmi entry (was: Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi)

2011-10-09 Thread Lai Jiangshan
From: Kenji Kaneshige In the current seabios MP table description, NMI is connected only to BSP's LINT1. But usually NMI is connected to all the CPUs' LINT1 as indicated in MP specification. This patch changes seabios MP table to describe NMI is connected to all the CPUs' LINT1. Signed-off-by: K

[PATCH 1/2] seabios: Add Local APIC NMI Structure to ACPI MADT (was: Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi)

2011-10-09 Thread Lai Jiangshan
From: Kenji Kaneshige ACPI NMI Structure describes LINT pin (LINT0 or LINT1) information to which NMI is connected, and it is needed by OS to initialize local APIC. Signed-off-by: Kenji Kaneshige Reviewed-by: Lai Jiangshan --- src/acpi.c | 22 -- 1 file changed, 20 inser

[PATCH] qemu-kvm: fix improper nmi emulation (was: Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi)

2011-10-09 Thread Lai Jiangshan
From: Kenji Kaneshige Currently, NMI interrupt is blindly sent to all the vCPUs when NMI button event happens. This doesn't properly emulate real hardware on which NMI button event triggers LINT1. Because of this, NMI is sent to the processor even when LINT1 is maskied in LVT. For example, this c

[PATCH] kernel/kvm: fix improper nmi emulation (was: Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi)

2011-10-09 Thread Lai Jiangshan
From: Kenji Kaneshige Currently, NMI interrupt is blindly sent to all the vCPUs when NMI button event happens. This doesn't properly emulate real hardware on which NMI button event triggers LINT1. Because of this, NMI is sent to the processor even when LINT1 is maskied in LVT. For example, this c

Re: [PATCH] qemu: Fix inject-nmi

2011-10-09 Thread Lai Jiangshan
On 09/26/2011 04:21 PM, Avi Kivity wrote: > On 09/25/2011 08:22 PM, Jan Kiszka wrote: >> On 2011-09-25 16:07, Avi Kivity wrote: >> > On 09/23/2011 12:31 PM, Lai Jiangshan wrote: >> >> > Moreover: wrong indention. >> >> > >> >> > You know that this won't work for qemu-kvm with in-kernel irqc

Re: [PATCH] qemu: Fix inject-nmi

2011-09-26 Thread Avi Kivity
On 09/25/2011 08:22 PM, Jan Kiszka wrote: On 2011-09-25 16:07, Avi Kivity wrote: > On 09/23/2011 12:31 PM, Lai Jiangshan wrote: >> > Moreover: wrong indention. >> > >> > You know that this won't work for qemu-kvm with in-kernel irqchip? You >> > may want to provide a patch for that tre

Re: [PATCH] qemu: Fix inject-nmi

2011-09-25 Thread Jan Kiszka
On 2011-09-25 16:07, Avi Kivity wrote: > On 09/23/2011 12:31 PM, Lai Jiangshan wrote: >> > Moreover: wrong indention. >> > >> > You know that this won't work for qemu-kvm with in-kernel irqchip? You >> > may want to provide a patch for that tree, emulating the unavailable >> > LINT1 injection v

Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi

2011-09-25 Thread Avi Kivity
On 09/23/2011 12:31 PM, Lai Jiangshan wrote: > Moreover: wrong indention. > > You know that this won't work for qemu-kvm with in-kernel irqchip? You > may want to provide a patch for that tree, emulating the unavailable > LINT1 injection via testing the APIC configration and then raising an >

Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi

2011-09-23 Thread Jan Kiszka
On 2011-09-23 11:31, Lai Jiangshan wrote: > On 09/22/2011 10:51 PM, Jan Kiszka wrote: >> On 2011-09-22 11:50, Lai Jiangshan wrote: >>> >>> From: KAMEZAWA Hiroyuki >>> Subject: [PATCH] Fix inject-nmi >>> >>> Now, inject-nmi sends NMI to all cpus...but this doesn't emulate >>> pc hardware 'NMI butto

Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi

2011-09-23 Thread Lai Jiangshan
On 09/22/2011 10:51 PM, Jan Kiszka wrote: > On 2011-09-22 11:50, Lai Jiangshan wrote: >> >> From: KAMEZAWA Hiroyuki >> Subject: [PATCH] Fix inject-nmi >> >> Now, inject-nmi sends NMI to all cpus...but this doesn't emulate >> pc hardware 'NMI button', which triggers LINT1. >> >> So, now, LINT1 mask

Re: [PATCH] qemu: Fix inject-nmi

2011-09-22 Thread Jan Kiszka
On 2011-09-22 11:50, Lai Jiangshan wrote: > > From: KAMEZAWA Hiroyuki > Subject: [PATCH] Fix inject-nmi > > Now, inject-nmi sends NMI to all cpus...but this doesn't emulate > pc hardware 'NMI button', which triggers LINT1. > > So, now, LINT1 mask is ignored by inject-nmi and NMIs are sent to >

[PATCH] qemu: Fix inject-nmi

2011-09-22 Thread Lai Jiangshan
From: KAMEZAWA Hiroyuki Subject: [PATCH] Fix inject-nmi Now, inject-nmi sends NMI to all cpus...but this doesn't emulate pc hardware 'NMI button', which triggers LINT1. So, now, LINT1 mask is ignored by inject-nmi and NMIs are sent to all cpus without checking LINT1 mask. Because Linux masks L