Re: [PATCH] kvm-kmod: x86: Drop duplicate external-module-compat objects

2009-05-25 Thread Avi Kivity
Jan Kiszka wrote: Can you show the call to hash? It's more interesting than the aftermath of its failure. strace said eg.: execve("./scripts/basic/hash", ["./scripts/basic/hash", "djb2", "/data/kvm-kmod/x86/..kvm", "kvm-amd", "kvm-intel"], ... Tried to look what's going on. Never

Re: [PATCH] kvm-kmod: x86: Drop duplicate external-module-compat objects

2009-05-24 Thread Jan Kiszka
Avi Kivity wrote: > Jan Kiszka wrote: >> Chris Wright wrote: >> >>> * Jan Kiszka (jan.kis...@web.de) wrote: >>> This redundancy breaks subtly when building against recent OpenSUSE kernels. >>> What breaks? >>> >> >> When building external-module-compat.c, linux/scri

Re: [PATCH] kvm-kmod: x86: Drop duplicate external-module-compat objects

2009-05-24 Thread Avi Kivity
Jan Kiszka wrote: Chris Wright wrote: * Jan Kiszka (jan.kis...@web.de) wrote: This redundancy breaks subtly when building against recent OpenSUSE kernels. What breaks? When building external-module-compat.c, linux/scripts/basic/hash somehow gets called with a multi-word m

Re: [PATCH] kvm-kmod: x86: Drop duplicate external-module-compat objects

2009-05-24 Thread Avi Kivity
Jan Kiszka wrote: This redundancy breaks subtly when building against recent OpenSUSE kernels. Signed-off-by: Jan Kiszka --- x86/Kbuild |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/x86/Kbuild b/x86/Kbuild index e304c79..ade87fc 100644 --- a/x86/Kbuild +++ b/x86/

Re: [PATCH] kvm-kmod: x86: Drop duplicate external-module-compat objects

2009-05-23 Thread Jan Kiszka
Chris Wright wrote: > * Jan Kiszka (jan.kis...@web.de) wrote: >> This redundancy breaks subtly when building against recent OpenSUSE >> kernels. > > What breaks? When building external-module-compat.c, linux/scripts/basic/hash somehow gets called with a multi-word modname. It complains via its us

Re: [PATCH] kvm-kmod: x86: Drop duplicate external-module-compat objects

2009-05-22 Thread Chris Wright
* Jan Kiszka (jan.kis...@web.de) wrote: > This redundancy breaks subtly when building against recent OpenSUSE > kernels. What breaks? -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.o

[PATCH] kvm-kmod: x86: Drop duplicate external-module-compat objects

2009-05-22 Thread Jan Kiszka
This redundancy breaks subtly when building against recent OpenSUSE kernels. Signed-off-by: Jan Kiszka --- x86/Kbuild |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/x86/Kbuild b/x86/Kbuild index e304c79..ade87fc 100644 --- a/x86/Kbuild +++ b/x86/Kbuild @@ -13,7 +13,