Re: [PATCH] kvm: device-assignment: Add PCI option ROM support

2009-06-22 Thread Yang, Sheng
On Tuesday 23 June 2009 00:09:28 Alex Williamson wrote: > On Mon, 2009-06-22 at 13:32 +0800, Yang, Sheng wrote: > > On Friday 19 June 2009 21:44:40 Alex Williamson wrote: > > > On Fri, 2009-06-19 at 15:27 +0800, Yang, Sheng wrote: > > > > On Friday 19 June 2009 00:28:41 Alex Williamson wrote: > > >

Re: [PATCH] kvm: device-assignment: Add PCI option ROM support

2009-06-22 Thread Alex Williamson
On Mon, 2009-06-22 at 13:32 +0800, Yang, Sheng wrote: > On Friday 19 June 2009 21:44:40 Alex Williamson wrote: > > On Fri, 2009-06-19 at 15:27 +0800, Yang, Sheng wrote: > > > On Friday 19 June 2009 00:28:41 Alex Williamson wrote: > > > > The one oddity I noticed is that even when the enable bit is

Re: [PATCH] kvm: device-assignment: Add PCI option ROM support

2009-06-22 Thread Avi Kivity
On 06/15/2009 07:29 PM, Alex Williamson wrote: The PCI code already knows about option ROMs, so we just need to mmap some space for it, load it with a copy of the contents, and complete the plubming to the generic code. With this a Linux guest can get access to the ROM contents via /sys/bus/pci/

Re: [PATCH] kvm: device-assignment: Add PCI option ROM support

2009-06-21 Thread Yang, Sheng
On Friday 19 June 2009 21:44:40 Alex Williamson wrote: > On Fri, 2009-06-19 at 15:27 +0800, Yang, Sheng wrote: > > On Friday 19 June 2009 00:28:41 Alex Williamson wrote: > > > The one oddity I noticed is that even when the enable bit is clear, the > > > guest can read the ROM. I don't know that th

Re: [PATCH] kvm: device-assignment: Add PCI option ROM support

2009-06-19 Thread Alex Williamson
On Fri, 2009-06-19 at 15:27 +0800, Yang, Sheng wrote: > On Friday 19 June 2009 00:28:41 Alex Williamson wrote: > > The one oddity I noticed is that even when the enable bit is clear, the > > guest can read the ROM. I don't know that this is actually illegal, vs > > returning zeros or ones though.

Re: [PATCH] kvm: device-assignment: Add PCI option ROM support

2009-06-19 Thread Yang, Sheng
On Friday 19 June 2009 00:28:41 Alex Williamson wrote: > On Thu, 2009-06-18 at 13:30 +0800, Yang, Sheng wrote: > > On Tuesday 16 June 2009 00:29:17 Alex Williamson wrote: > > > The PCI code already knows about option ROMs, so we just need to > > > mmap some space for it, load it with a copy of the

Re: [PATCH] kvm: device-assignment: Add PCI option ROM support

2009-06-18 Thread Alex Williamson
On Thu, 2009-06-18 at 13:30 +0800, Yang, Sheng wrote: > On Tuesday 16 June 2009 00:29:17 Alex Williamson wrote: > > The PCI code already knows about option ROMs, so we just need to > > mmap some space for it, load it with a copy of the contents, and > > complete the plubming to the generic code. >

Re: [PATCH] kvm: device-assignment: Add PCI option ROM support

2009-06-17 Thread Yang, Sheng
On Tuesday 16 June 2009 00:29:17 Alex Williamson wrote: > The PCI code already knows about option ROMs, so we just need to > mmap some space for it, load it with a copy of the contents, and > complete the plubming to the generic code. > > With this a Linux guest can get access to the ROM contents v

[PATCH] kvm: device-assignment: Add PCI option ROM support

2009-06-15 Thread Alex Williamson
The PCI code already knows about option ROMs, so we just need to mmap some space for it, load it with a copy of the contents, and complete the plubming to the generic code. With this a Linux guest can get access to the ROM contents via /sys/bus/pci/devices//rom. This might also enable the BIOS to