Il 17/09/2014 12:45, Radim Krčmář ha scritto:
> a) count local KVM_REQ_TLB_FLUSH requests
> b) count all TLB flushes
> c) both (a) and (b)
>
> I was thinking that when you look at /sys/kernel/debug/kvm/tlb_flushes,
> you are interested in the number of TLB flushes that VMs did, not
> requests,
2014-09-17 08:15+0800, Wanpeng Li:
> Hi Radim,
> On Mon, Sep 15, 2014 at 09:33:52PM +0200, Radim Krčmář wrote:
> >Do you prefer the current behavior?
> >
> >--- 8< ---
> >KVM: x86: count actual tlb flushes
> >
> >- we count KVM_REQ_TLB_FLUSH requests, not actual flushes
>
> So there maybe multiple
Hi Radim,
On Mon, Sep 15, 2014 at 09:33:52PM +0200, Radim Krčmář wrote:
>2014-09-12 17:06-0400, Liang Chen:
>> Using kvm_mmu_flush_tlb as the other places to make sure vcpu
>> stat is incremented
>>
>> Signed-off-by: Liang Chen
>> ---
>
>Good catch.
>
>> arch/x86/kvm/vmx.c | 2 +-
>> 1 file cha
Il 16/09/2014 00:49, Liang Chen ha scritto:
>> > ---
>> > (And what about a possible followup patch that replaces
>> > kvm_mmu_flush_tlb() with kvm_make_request() again?
>> > It would free the namespace a bit and we could call something
>> > similarly named from vcpu_enter_guest() to do the job.
On 09/15/2014 03:33 PM, Radim Krčmář wrote:
> 2014-09-12 17:06-0400, Liang Chen:
>> Using kvm_mmu_flush_tlb as the other places to make sure vcpu
>> stat is incremented
>>
>> Signed-off-by: Liang Chen
>> ---
> Good catch.
>
>> arch/x86/kvm/vmx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 dele
2014-09-12 17:06-0400, Liang Chen:
> Using kvm_mmu_flush_tlb as the other places to make sure vcpu
> stat is incremented
>
> Signed-off-by: Liang Chen
> ---
Good catch.
> arch/x86/kvm/vmx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86
Using kvm_mmu_flush_tlb as the other places to make sure vcpu
stat is incremented
Signed-off-by: Liang Chen
---
arch/x86/kvm/vmx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index bfe11cf..439682e 100644
--- a/arch/x86/kvm/vmx.c
+