Re: [PATCH] Add kvm_set_boot_cpu_id() API.

2009-06-28 Thread Gleb Natapov
On Sun, Jun 28, 2009 at 01:31:28PM +0300, Avi Kivity wrote: > On 06/28/2009 12:33 PM, Gleb Natapov wrote: >> On Sun, Jun 28, 2009 at 12:29:26PM +0300, Avi Kivity wrote: >> >>> On 06/25/2009 03:21 PM, Gleb Natapov wrote: >>> Signed-off-by: Gleb Natapov >>> Why is it

Re: [PATCH] Add kvm_set_boot_cpu_id() API.

2009-06-28 Thread Avi Kivity
On 06/28/2009 12:33 PM, Gleb Natapov wrote: On Sun, Jun 28, 2009 at 12:29:26PM +0300, Avi Kivity wrote: On 06/25/2009 03:21 PM, Gleb Natapov wrote: Signed-off-by: Gleb Natapov Why is it needed? (good changelog material). OK. Well, why? } - + +kvm_

Re: [PATCH] Add kvm_set_boot_cpu_id() API.

2009-06-28 Thread Gleb Natapov
On Sun, Jun 28, 2009 at 12:29:26PM +0300, Avi Kivity wrote: > On 06/25/2009 03:21 PM, Gleb Natapov wrote: >> Signed-off-by: Gleb Natapov >> > > Why is it needed? (good changelog material). > OK. >> } >> - >> + >> +kvm_set_boot_cpu_id(0); >> > > You're not testing for failure. Do

Re: [PATCH] Add kvm_set_boot_cpu_id() API.

2009-06-28 Thread Avi Kivity
On 06/25/2009 03:21 PM, Gleb Natapov wrote: Signed-off-by: Gleb Natapov Why is it needed? (good changelog material). } - + +kvm_set_boot_cpu_id(0); You're not testing for failure. Doesn't matter here because it's the default, but then you can omit the call entirely. -

[PATCH] Add kvm_set_boot_cpu_id() API.

2009-06-25 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- hw/pc.c|3 ++- qemu-kvm.c | 17 + qemu-kvm.h |1 + 3 files changed, 20 insertions(+), 1 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index cb5b4d0..9ef245d 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -901,7 +901,8 @@ static void pc_init1(ra