On Wed, 2009-06-03 at 02:14 -0400, Michael Goldish wrote:
> - "Avi Kivity" wrote:
>
> > David Huff wrote:
> > > This patch will run pre and post scripts
> > > defined in config file with the parameter pre_command
> > > and post_command post_command.
> > >
> > > Also exports all the prameters
- "Avi Kivity" wrote:
> Michael Goldish wrote:
> >> I think it's very rare to want to let the test continue even if
> some
> >> command fails.
> >>
> >> Can you give examples?
> >>
> >
> > Some commands are not critical, like one that converts the
> screendumps
> > from PPM to PNG form
Michael Goldish wrote:
I think it's very rare to want to let the test continue even if some
command fails.
Can you give examples?
Some commands are not critical, like one that converts the screendumps
from PPM to PNG format. We don't want to fail the test if you don't have
ImageMagick in
- "Avi Kivity" wrote:
> Michael Goldish wrote:
>
>
> >>> - What if we're interested in the status for some reason? Its
> value
> >>> may indicate what went wrong with the child process.
> >>>
> >>>
> >> Put it in the exception string.
> >>
> >
> > But I
Michael Goldish wrote:
- What if we're interested in the status for some reason? Its value
may indicate what went wrong with the child process.
Put it in the exception string.
But I want its value to be examined programmatically in the code.
It's less comfortable t
- "Avi Kivity" wrote:
> Michael Goldish wrote:
> > - "Avi Kivity" wrote:
> >
> >
> >> David Huff wrote:
> >>
> >>> This patch will run pre and post scripts
> >>> defined in config file with the parameter pre_command
> >>> and post_command post_command.
> >>>
> >>> Also exports a
Michael Goldish wrote:
- "Avi Kivity" wrote:
David Huff wrote:
This patch will run pre and post scripts
defined in config file with the parameter pre_command
and post_command post_command.
Also exports all the prameters in preprocess for passing
arguments to the script.
+ #ex
- "Avi Kivity" wrote:
> David Huff wrote:
> > This patch will run pre and post scripts
> > defined in config file with the parameter pre_command
> > and post_command post_command.
> >
> > Also exports all the prameters in preprocess for passing
> > arguments to the script.
> >
> > + #exe
David Huff wrote:
This patch will run pre and post scripts
defined in config file with the parameter pre_command
and post_command post_command.
Also exports all the prameters in preprocess for passing
arguments to the script.
+ #execute any pre_commands
+pre_command = params.get("pre_co
On Tue, May 26, 2009 at 9:37 PM, David Huff wrote:
> Michael Goldish wrote:
>> Looks good to me. See some comments below.
>>
>> - "David Huff" wrote:
>>
>>> This patch will run pre and post scripts
>>> defined in config file with the parameter pre_command
>>> and post_command post_command.
>>
This patch will run pre and post scripts
defined in config file with the parameter pre_command
and post_command post_command.
Also exports all the prameters in preprocess for passing
arguments to the script.
---
client/tests/kvm_runtest_2/kvm_preprocessing.py | 34 +++
1 fil
Michael Goldish wrote:
> Looks good to me. See some comments below.
>
> - "David Huff" wrote:
>
>> This patch will run pre and post scripts
>> defined in config file with the parameter pre_command
>> and post_command post_command.
>>
>> Also exports all the prameters in preprocess for passin
Looks good to me. See some comments below.
- "David Huff" wrote:
> This patch will run pre and post scripts
> defined in config file with the parameter pre_command
> and post_command post_command.
>
> Also exports all the prameters in preprocess for passing
> arguments to the script.
Why n
This patch will run pre and post scripts
defined in config file with the parameter pre_command
and post_command post_command.
Also exports all the prameters in preprocess for passing
arguments to the script.
---
client/tests/kvm_runtest_2/kvm_preprocessing.py | 31 +-
1 file
14 matches
Mail list logo
