Re: [Autotest] [KVM_AUTOTEST] add kvm hugepage variant

2009-07-27 Thread Lucas Meneghel Rodrigues
On Tue, Jul 21, 2009 at 1:04 PM, Lukáš Doktor wrote: > Well, thank you for notifications, I'll keep them in my mind. Ok Lukáš, I have reviewed your patch and have some comments to make: diff --git a/client/tests/kvm/kvm_tests.cfg.sample b/client/tests/kvm/kvm_tests.cfg.sample index 5bd6eb8..70e29

Re: [Autotest] [KVM_AUTOTEST] add kvm hugepage variant

2009-07-21 Thread sudhir kumar
The patch looks to be pretty clean to me. I was running a small hugetlbfs script doing the same, but its good now as the script is being incorporated in the test. On Tue, Jul 21, 2009 at 9:34 PM, Lukáš Doktor wrote: > Well, thank you for notifications, I'll keep them in my mind. > > Also the probl

Re: [KVM_AUTOTEST] add kvm hugepage variant

2009-07-21 Thread Lukáš Doktor
Well, thank you for notifications, I'll keep them in my mind. Also the problem with mempath vs. mem-path is solved. It was just a misspell in one version of KVM. * fixed patch attached Dne 20.7.2009 14:58, Lucas Meneghel Rodrigues napsal(a): On Fri, 2009-07-10 at 12:01 +0200, Lukáš Doktor wr

Re: [KVM_AUTOTEST] add kvm hugepage variant

2009-07-20 Thread Lucas Meneghel Rodrigues
On Fri, 2009-07-10 at 12:01 +0200, Lukáš Doktor wrote: > After discussion I split the patches. Hi Lukáš, sorry for the delay answering your patch. Looks good to me in general, I have some remarks to make: 1) When posting patches to the autotest kvm tests, please cross post the autotest mailing li

[KVM_AUTOTEST] add kvm hugepage variant

2009-07-10 Thread Lukáš Doktor
After discussion I split the patches. This patch adds kvm_hugepage variant. It prepares the host system and start vm with -mem-path option. It does not clean after itself, because it's impossible to unmount and free hugepages before all guests are destroyed. I need to ask you what to do with

Re: [KVM_AUTOTEST] add kvm hugepage variant and test

2009-07-10 Thread Lukáš Doktor
I'm sorry this patch has a bug. hugepage variant doesn't allocate enough memory with stress_boot (stress_boot uses different method to define VMS). Attached the fixed patch. Dne 9.7.2009 11:24, Lukáš Doktor napsal(a): This patch adds kvm_hugepage variant. It prepares the host system and start v

Re: [KVM_AUTOTEST] add kvm hugepage variant and test

2009-07-09 Thread Lukáš Doktor
- kvm_hugepages variant enables us to test if (host) kvm use of hugepages works - libhugetlbfs test inside of guest prove, that (guest) system is able to handle hugepages (independently of whether guest uses hugepages). This function is necessarily eg. if you want to run Oracle server inside th

Re: [KVM_AUTOTEST] add kvm hugepage variant and test

2009-07-09 Thread sudhir kumar
Why do you want to use a control file and put the libhugetlbfs as a variant of autotest in kvm? Just keeping the kvm_hugepages variant will not serve the same purpose ? I have been using hugetlbfs variant for a long but yes without pre script(I have done that manually)? Am I missing something here?

Re: [KVM_AUTOTEST] add kvm hugepage variant and test

2009-07-09 Thread Lukáš Doktor
Hi Michael, actually it's necessarily. qemu-kvm only put this message into the output and continue booting the guest without hugepage support. Autotest than runs all the test. Later in the output is no mention about this. You have to predict that this happend and look at debug output of all p

Re: [KVM_AUTOTEST] add kvm hugepage variant and test

2009-07-09 Thread Michael Goldish
I don't think you need to explicitly check for a memory allocation failure in VM.create() ("qemu produced some output ..."). VM.create() already makes sure the VM is started successfully, and prints informative failure messages if there's any problem. - "Lukáš Doktor" wrote: > This patch add

[KVM_AUTOTEST] add kvm hugepage variant and test

2009-07-09 Thread Lukáš Doktor
This patch adds kvm_hugepage variant. It prepares the host system and start vm with -mem-path option. It does not clean after itself, because it's impossible to unmount and free hugepages before all guests are destroyed. There is also added autotest.libhugetlbfs test. I need to ask you what t