[PATCH] [Autotest PATCH v2] KVM-test: Add a subtest 'qemu_img'

2010-03-31 Thread Yolkfull Chow
not support 'rebase' subcommand GOOD1392 [r...@afu kvm]# shows only 'rebase' subtest is not supported currently. Others runs good from my side. Signed-off-by: Yolkfull Chow --- client/tests/k

Re: [Autotest] [Autotest PATCH] KVM-test: Add a subtest 'qemu_img'

2010-03-29 Thread Yolkfull Chow
parameter say 'ignore_vm_config = yes' to config file which let a test ignore all configurations combination. Another method is ugly adding following block into config file: --- qemu_img: only ide only qcow2 only up only ... (use 'only' to filter all configurations co

[PATCH] KVM test: Put os.kill in kvm_stat into try block to avoid traceback

2010-03-29 Thread Yolkfull Chow
Sometimes it tried to kill an already terminated process which can cause a traceback. This patch fixes the problem. Signed-off-by: Yolkfull Chow --- client/profilers/kvm_stat/kvm_stat.py |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/client/profilers/kvm_stat

[PATCH] KVM-test: SR-IOV: Fix a bug that wrongly check VFs count

2010-03-10 Thread Yolkfull Chow
hus get the total number of VFs. Signed-off-by: Yolkfull Chow --- client/tests/kvm/kvm_utils.py | 19 +-- 1 files changed, 13 insertions(+), 6 deletions(-) diff --git a/client/tests/kvm/kvm_utils.py b/client/tests/kvm/kvm_utils.py index 4565dc1..1813ed1 100644 --- a/client/t

Re: How to disable KVM start at boot

2010-02-25 Thread Yolkfull Chow
On Thu, Feb 25, 2010 at 05:23:15PM +0800, sati...@pacific.net.hk wrote: > Quoting Yolkfull Chow : > > > >>$ lsmod | grep kvm > >>kvm_amd38452 0 > >>kvm 163952 1 kvm_amd > >> > >> > >># chkconfig

Re: How to disable KVM start at boot

2010-02-24 Thread Yolkfull Chow
On Thu, Feb 25, 2010 at 12:25:07PM +0800, sati...@pacific.net.hk wrote: > Quoting "Hao, Xudong" : > > >That's right. > >I run it on RHEL system, F12 should be same, you can have a try. > > Hi Hao, > > $ lsmod | grep kvm > kvm_amd38452 0 > kvm 163952 1 kvm_amd

[PATCH] KVM-test: SR-IOV: fix a bug that misplaced parameters location

2010-02-08 Thread Yolkfull Chow
Reverse both parameters of utils.open_write_close() that was misplaced. Signed-off-by: Yolkfull Chow --- client/tests/kvm/kvm_utils.py |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/client/tests/kvm/kvm_utils.py b/client/tests/kvm/kvm_utils.py index 08af99b

Re: [KVM-AUTOTEST PATCH 1/1] KVM test: kvm_vm.py: shorten VM.destroy()

2010-02-03 Thread Yolkfull Chow
On Wed, Feb 03, 2010 at 01:21:12PM +0200, Michael Goldish wrote: > Call self.pci_assignable.release_devs() in the finally block. Looks good for me. Thanks, Michael, for this cleanup. > > Signed-off-by: Michael Goldish > --- > client/tests/kvm/kvm_vm.py | 11 ++- > 1 files changed, 2

[PATCH] KVM-test: Log the output of failed executed command 'pre/post-command'

2010-02-03 Thread Yolkfull Chow
Sometimes we need the output of failed command 'pre/post-command' when raising error.TestError. Take an example that using post-command to check images of qcow2 format, it will simply tell command failed rather than show '%d errors were found on the image'. Signed-o

Re: [Autotest] [RFC] KVM test: Ship rss.exe and finish.exe binaries with KVM test

2010-02-02 Thread Yolkfull Chow
>On Tue, Feb 02, 2010 at 09:48:34AM -0200, Lucas Meneghel Rodrigues wrote: > Hi folks: > > We're on an effort of streamlining the KVM test experience, by choosing > sane defaults and helper scripts that can overcome the initial barrier > with getting the KVM test running. On one of the conversatio

Re: [Autotest PATCH] KVM-test: Add a subtest 'qemu_img'

2010-01-28 Thread Yolkfull Chow
On Fri, Jan 29, 2010 at 03:00:09PM +0800, Yolkfull Chow wrote: > This is designed to test all subcommands of 'qemu-img' however > so far 'commit' is not implemented. > > * For 'check' subcommand test, it will 'dd' to create a file with specified

[Autotest PATCH] KVM-test: Add a subtest 'qemu_img'

2010-01-28 Thread Yolkfull Chow
ared to the old one, or corruption may occur. Safe Mode: Both the current and the new backing file need to exist, and after the rebase, the COW image is guaranteed to have the same guest visible content as before. To achieve this, old and new backing file are co

Re: [Autotest] [Autotest PATCH] KVM-test: Add a subtest 'qemu_img'

2010-01-28 Thread Yolkfull Chow
37 AM, Yolkfull Chow wrote: > > On Wed, Jan 27, 2010 at 07:37:46AM -0500, Michael Goldish wrote: > >> > >> - "Yolkfull Chow" wrote: > >> > >> > On Tue, Jan 26, 2010 at 03:11:34PM -0200, Lucas Meneghel Rodrigues > >> > wrote: &

Re: [Autotest] [Autotest PATCH] KVM-test: Add a subtest 'qemu_img'

2010-01-28 Thread Yolkfull Chow
On Tue, Jan 26, 2010 at 03:11:34PM -0200, Lucas Meneghel Rodrigues wrote: > On Tue, 2010-01-26 at 11:25 +0800, Yolkfull Chow wrote: > > This is designed to test all subcommands of 'qemu-img' however > > so far 'commit' is not implemented. > > Hi Yolkful,

Re: [Autotest] [Autotest PATCH] KVM-test: Add a subtest 'qemu_img'

2010-01-27 Thread Yolkfull Chow
On Wed, Jan 27, 2010 at 07:37:46AM -0500, Michael Goldish wrote: > > - "Yolkfull Chow" wrote: > > > On Tue, Jan 26, 2010 at 03:11:34PM -0200, Lucas Meneghel Rodrigues > > wrote: > > > On Tue, 2010-01-26 at 11:25 +0800, Yolkfull Chow wrote: > > &

Re: [Autotest] [Autotest PATCH] KVM-test: Add a subtest 'qemu_img'

2010-01-27 Thread Yolkfull Chow
On Tue, Jan 26, 2010 at 03:11:34PM -0200, Lucas Meneghel Rodrigues wrote: > On Tue, 2010-01-26 at 11:25 +0800, Yolkfull Chow wrote: > > This is designed to test all subcommands of 'qemu-img' however > > so far 'commit' is not implemented. > > Hi Yolkful,

Re: [Autotest] [Autotest PATCH] KVM-test: Add a subtest image_copy

2010-01-26 Thread Yolkfull Chow
our test sets), but > your team could look at the possibility of 1st trying to do the actual > OS install, then resorting to image copy only if the test fails. > > That said, the actual review of the test follows: > > On Wed, 2010-01-06 at 11:32 +0800, Yolkfull Chow wrote:

[Autotest PATCH] KVM-test: Add a subtest 'qemu_img'

2010-01-25 Thread Yolkfull Chow
7;snapshot' subcommand test, it will create two snapshots and list them. Finally delete them if no errors found. * For 'info' subcommand test, it simply get output from specified image file. Signed-off-by: Yolkfull Chow --- client/tests/kvm/tests/qemu_img.py | 155 +++

Re: [Autotest] [AUTOTEST PATCH 1/2] KVM-test: Fix a bug that about list slice in scan_results.py

2010-01-24 Thread Yolkfull Chow
rily skip this patch now and look into it if find it again in future. Thanks for your analysis. :) > > - "Yolkfull Chow" wrote: > > > If 'info_list' is empty slice operation can result in traceback: > > > > ... > > inf

Re: PCI Passthrough Problem

2010-01-21 Thread Yolkfull Chow
On Thu, Jan 21, 2010 at 09:24:36PM -0800, Aaron Clausen wrote: > I'm trying once again to get PCI passthrough working (KVM 84 on Ubuntu > 9.10), and I'm getting this error : > > LC_ALL=C PATH=/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin > /usr/bin/kvm -S -M pc-0.11 -m 4096 -smp 4 -

[Autotest PATCH] KVM-test: subtest migrate: Use 'wait_for_login' to log into migrated guest

2010-01-20 Thread Yolkfull Chow
Using 'wait_for' for logging into migrated guest repeats the work of 'wait_for_login' which exists already. We just need to change the name of 'dest_vm'. Signed-off-by: Yolkfull Chow --- client/tests/kvm/kvm_test_utils.py |1 + client/tests/kvm/tests/migrat

[Autotest PATCH] KVM-test: Fix a bug that pci_assignable type name mismatch

2010-01-18 Thread Yolkfull Chow
The pci_assignable type name is nic_vf/nic_pf in kvm_utils.py whereas in kvm_vm.py they are vf/pf. Weird that why I tested it pass last week. Hope that it will not bring in any trouble before this patch applied. Signed-off-by: Yolkfull Chow --- client/tests/kvm/kvm_utils.py | 10 +- 1

Re: [Autotest] [PATCH] KVM test: Add PCI device assignment support

2010-01-18 Thread Yolkfull Chow
On Wed, Jan 13, 2010 at 12:19 AM, Yolkfull Chow wrote: > > On Tue, Jan 12, 2010 at 04:28:13PM -0200, Lucas Meneghel Rodrigues wrote: > >> Add support to PCI device assignment on the kvm test. It supports > >> both SR-IOV virtual functions and physical NIC card devi

[Autotest PATCH 2/2] KVM-test: subtest guest_s4: Add check of if there's enough space left for S4

2010-01-12 Thread Yolkfull Chow
If disk has no enough space left, check S4 support will fail. Also use 'TestNAError' as error type if guest really doesn't support S4. (Thanks Jason for pointing this out. :) Signed-off-by: Yolkfull Chow --- client/tests/kvm/tests/guest_s4.py | 10 +- 1 files change

[Autotest PATCH 1/2] KVM-test: Move two 'remote_login' out of try block in kvm_vm.py

2010-01-12 Thread Yolkfull Chow
'self.remote_login()' should be outside of try block. And as suggested by Michael, we need fix the problem that if self.remote_login() fails, session will be None. Signed-off-by: Yolkfull Chow --- client/tests/kvm/kvm_vm.py | 49 ++- 1 fil

Re: [Autotest] [AUTOTEST PATCH 2/2] KVM-test: Move two 'remote_login' out of try block in kvm_vm.py

2010-01-12 Thread Yolkfull Chow
On Tue, Jan 12, 2010 at 08:37:25PM -0200, Lucas Meneghel Rodrigues wrote: > On Thu, Dec 31, 2009 at 8:03 AM, Michael Goldish wrote: > > > > - "Yolkfull Chow" wrote: > > > >> If vm.remote_login failed 'session.close()' can result in exception

Re: [AUTOTEST PATCH 2/2] KVM-test: Move two 'remote_login' out of try block in kvm_vm.py

2010-01-12 Thread Yolkfull Chow
On Thu, Dec 31, 2009 at 05:03:21AM -0500, Michael Goldish wrote: > > - "Yolkfull Chow" wrote: > > > If vm.remote_login failed 'session.close()' can result in exception > > in finally clause. This patch fix the problem. > > > > Signed

Re: [PATCH] KVM test: Add PCI device assignment support

2010-01-12 Thread Yolkfull Chow
* For SR-IOV virtual functions passthrough, we could specify the > module parameter 'max_vfs' in config file. > * For physical NIC card pass through, we should specify the device > name(s). Looks good for me. Lucas, thank you so much for improving this patch. :-) > &

Re: [PATCH] KVM test: Add PCI device assignment support

2010-01-12 Thread Yolkfull Chow
On Sun, Dec 27, 2009 at 09:55:56PM -0200, Lucas Meneghel Rodrigues wrote: > Add support to PCI device assignment on the kvm test. It supports > both SR-IOV virtual functions and physical NIC card device > assignment. > > Single Root I/O Virtualization (SR-IOV) allows a single PCI device to > be sh

[Autotest PATCH] KVM-test: Add a subtest image_copy

2010-01-05 Thread Yolkfull Chow
Add image_copy subtest for convenient KVM functional testing. The target image will be copied into the linked directory if link 'images' is created, and copied to the directory specified in config file otherwise. Signed-off-by: Yolkfull Chow --- client/tests/kvm/kvm_utils.py

[Autotest PATCH 2/2] KVM-test: guest_s4 subtest: Tune up timeout value for `set_s4_cmd' command

2010-01-05 Thread Yolkfull Chow
Signed-off-by: Yolkfull Chow --- client/tests/kvm/tests/guest_s4.py |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm/tests/guest_s4.py b/client/tests/kvm/tests/guest_s4.py index f08b9d2..82572f6 100644 --- a/client/tests/kvm/tests/guest_s4.py +++ b

[Autotest PATCH 1/2] KVM-test: linux_s3 subtest: Tune up timeout for suspend command

2010-01-05 Thread Yolkfull Chow
As suggested by Jason, timeout value can be various if different guest CPU number specified. This patch fixs the problem. Signed-off-by: Yolkfull Chow --- client/tests/kvm/tests/linux_s3.py |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm/tests

Re: [Autotest] [Autotest PATCH] KVM-test: Add a subtest image_copy

2010-01-04 Thread Yolkfull Chow
On Mon, Jan 04, 2010 at 10:52:13PM +0800, Amos Kong wrote: > On Mon, Jan 04, 2010 at 05:30:21PM +0800, Yolkfull Chow wrote: > > Add image_copy subtest for convenient KVM functional testing. > > > > The target image will be copied into the linked directory if link 'i

[Autotest PATCH] KVM-test: Add a subtest image_copy

2010-01-04 Thread Yolkfull Chow
Add image_copy subtest for convenient KVM functional testing. The target image will be copied into the linked directory if link 'images' is created, and copied to the directory specified in config file otherwise. Signed-off-by: Yolkfull Chow --- client/tests/kvm/kvm_utils.py

Re: [Autotest] [Autotest PATCH] KVM test: Add a subtest vnc via which interacts with guest

2009-12-30 Thread Yolkfull Chow
On Fri, Dec 18, 2009 at 09:25:24AM -0600, Ryan Harper wrote: > * Yolkfull Chow [2009-12-17 22:51]: > > Signed-off-by: Yolkfull Chow > > --- > > client/tests/kvm/tests/vnc.py | 24 > > client/tests/kvm/tests_base.cfg.sample |3 +

[AUTOTEST PATCH 2/2] KVM-test: Move two 'remote_login' out of try block in kvm_vm.py

2009-12-30 Thread Yolkfull Chow
If vm.remote_login failed 'session.close()' can result in exception in finally clause. This patch fix the problem. Signed-off-by: Yolkfull Chow --- client/tests/kvm/kvm_vm.py | 51 +-- 1 files changed, 25 insertions(+), 26 deletions(-) di

[AUTOTEST PATCH 1/2] KVM-test: Fix a bug that about list slice in scan_results.py

2009-12-30 Thread Yolkfull Chow
If 'info_list' is empty slice operation can result in traceback: ... info_list[-1] = parts[5] IndexError: list assignment index out of range Signed-off-by: Yolkfull Chow --- client/tests/kvm/scan_results.py |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --gi

Re: [Autotest] [Autotest PATCH] KVM test: No need close session when login timeout

2009-12-28 Thread Yolkfull Chow
On Sat, Dec 26, 2009 at 10:07:58AM -0500, Michael Goldish wrote: > > - "Amos Kong" wrote: > > > On Fri, Dec 25, 2009 at 08:28:18AM -0500, Michael Goldish wrote: > > > > > > - "Amos Kong" wrote: > > > > > > > If login timeout, wait_for() returned 'None' and assigned to > > > > 'session

[Autotest PATCH] KVM test: Fixup memory size shown in 'GB' in get_memory_size

2009-12-24 Thread Yolkfull Chow
In guest RHEL-3.9 $mem_chk_cmd will catch memory size in GB which will be computed wrongly in get_memory_size. This patch fix the problem. Thanks akong for pointing this out. Signed-off-by: Yolkfull Chow --- client/tests/kvm/kvm_vm.py |6 +- 1 files changed, 5 insertions(+), 1

[Autotest PATCH] KVM test: physical_resources_check subtest:Fixup `mem_chk_cmd' for rhel3.9

2009-12-23 Thread Yolkfull Chow
Signed-off-by: Yolkfull Chow --- client/tests/kvm/tests_base.cfg.sample |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/tests_base.cfg.sample b/client/tests/kvm/tests_base.cfg.sample index a403399..f5a55a0 100644 --- a/client/tests/kvm

[Autotest PATCH] KVM test: Add a subtest vnc via which interacts with guest

2009-12-17 Thread Yolkfull Chow
Signed-off-by: Yolkfull Chow --- client/tests/kvm/tests/vnc.py | 24 client/tests/kvm/tests_base.cfg.sample |3 +++ 2 files changed, 27 insertions(+), 0 deletions(-) create mode 100644 client/tests/kvm/tests/vnc.py diff --git a/client/tests/kvm/tests

[Autotest] [PATCH] KVM test: subtest stress_boot: Fix a bug that cloned VMs are not screendumped

2009-12-10 Thread Yolkfull Chow
We just used vm.create() to create those cloned VMs whereas ignored catching screendumps of them. This patch fix this problem. Signed-off-by: Yolkfull Chow --- client/tests/kvm/tests/stress_boot.py |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/client/tests/kvm

[AUTOTEST PATCH 2/2] KVM test: subtest migration: Add rem_host and rem_port for migrate()

2009-12-08 Thread Yolkfull Chow
Since kvm_test_utils.migrate() adds two arguments to adopt server-side migration. This client side test also needs update. Signed-off-by: Yolkfull Chow --- client/tests/kvm/tests/migration.py |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm/tests

[AUTOTEST PATCH 1/2 - V3] Add a server-side test - kvm_migration

2009-12-08 Thread Yolkfull Chow
e 'rem_port' to 'mig_port'. I also rename 'rem_host' to be 'dest_host'. Signed-off-by: Yolkfull Chow --- client/tests/kvm/kvm_migration.py | 170 client/tests/kvm/kvm_test_utils.py | 27 +++--- client/tests/kvm/kvm

Re: [Autotest] [PATCH] Add a server-side test - kvm_migration

2009-12-07 Thread Yolkfull Chow
;> +        dest_vm = vm.clone() > >> +        dest_vm.create(for_migration=True) > >> > >>     try: > >>         # Define the migration command > >> -        cmd = "migrate -d tcp:localhost:%d" % dest_vm.migration_port > >> +      

[AUTOTEST PATCH] KVM test: subtest block_hotplug: Fixup pci_test_cmd in config file

2009-12-07 Thread Yolkfull Chow
RHEL-4.8 is still using 'hd[a-z]' as harddisk device name. This patch adds 'h' to regular expression in command `pci_test_cmd'. Signed-off-by: Yolkfull Chow --- client/tests/kvm/kvm_tests.cfg.sample |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

Re: [PATCH 1/2] Adds a test to verify resources inside a VM

2009-12-04 Thread Yolkfull Chow
On Sun, Nov 29, 2009 at 11:04:55AM +0200, Yaniv Kaul wrote: > On 11/29/2009 9:20 AM, Yolkfull Chow wrote: > >On Wed, Nov 25, 2009 at 11:35:02AM +0530, sudhir kumar wrote: > >>This patch adds a test for verifying whether the number of cpus and amount > >>of memory as see

[PATCH 2/2] KVM test: subtest migration: Add rem_host and rem_port for migrate().

2009-12-04 Thread Yolkfull Chow
Since kvm_test_utils.migrate() adds two arguments to adopt server-side migration. This client side test also needs update. Signed-off-by: Yolkfull Chow --- client/tests/kvm/tests/migration.py |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm/tests

[PATCH 1/2] Add a server-side test - kvm_migration

2009-12-04 Thread Yolkfull Chow
tion' into dict cloned from original test dict for dest machine. * In order to run this test so far, we need to setup NFS for both source and dest machines. Signed-off-by: Yolkfull Chow --- client/tests/kvm/kvm_migration.py | 165 client/tests/k

[PATCH V2] Add a server-side test - kvm_migration

2009-12-04 Thread Yolkfull Chow
, and then add 'start_vm_for_migration' into dict cloned from original test dict for dest machine. * In order to run this test so far, we need to setup NFS for both source and dest machines. Signed-off-by: Yolkfull Chow --- client/tests/kvm/kvm_migr

[PATCH] Add a server-side test: kvm_migration

2009-12-01 Thread Yolkfull Chow
Add -incoming option to the qemu command qemu_command += " -incoming tcp:0:%d" % self.migration_port diff --git a/client/tests/kvm/tests/migration.py b/client/tests/kvm/tests/migration.py index b8f171c..3fd8d5f 100644 --- a/client/tests/kvm/tests/migration.py +++ b/client

Re: [Autotest] [PATCH 1/2] Adds a test to verify resources inside a VM

2009-12-01 Thread Yolkfull Chow
ed it, works quite well. A > patch was sent to the mailing list a couple of minutes ago, please let > me know what you guys think. Looks good for me. Thanks Lucas for improving this test. Sudhir, what do you think about this? :) Cheers, Yolkfull > > Cheers, > > On Sun, Nov 2

About implementation of KVM server-side migration in autotest

2009-11-30 Thread Yolkfull Chow
s(self, params, env) logging.debug("Contents of environment: %s", str(env)) kvm_utils.dump_env(env, env_filename) But there will be a problem: where can we edit the config file to generate differnt dicts for migration test? Hard code

Re: [PATCH] KVM test: Add PCI device assignment support

2009-11-30 Thread Yolkfull Chow
ble class), so we don't have to bother dumping this >info to a file. > * Code simplified to avoid duplication > > As it's a fairly involved feature, the more reviews we get the better. Hi Lucas, I have some ideas about devices_requested parameter, please see commen

[PATCH] KVM test: Add a subtest params_verify

2009-11-29 Thread Yolkfull Chow
This patch will test following parameters of a VM: 1) count of CPU, hard disks and NICs 2) memory size 3) model of hard disks and NICs 4) NICs' mac address 5) UUID and serial number (if defined the command in config file) Signed-off-by: Yolkfull Chow --- client/bin/harness_standalo

Re: [PATCH 1/2] Adds a test to verify resources inside a VM

2009-11-29 Thread Yolkfull Chow
On Sun, Nov 29, 2009 at 02:22:40PM +0530, sudhir kumar wrote: > On Sun, Nov 29, 2009 at 12:50 PM, Yolkfull Chow wrote: > > On Wed, Nov 25, 2009 at 11:35:02AM +0530, sudhir kumar wrote: > >> This patch adds a test for verifying whether the number of cpus and amount > >>

Re: [PATCH 1/2] Adds a test to verify resources inside a VM

2009-11-28 Thread Yolkfull Chow
On Wed, Nov 25, 2009 at 11:35:02AM +0530, sudhir kumar wrote: > This patch adds a test for verifying whether the number of cpus and amount > of memory as seen inside a guest is same as allocated to it on the qemu > command line. Hello Sudhir, Please see embedded comments as below: > > Signed-o

[PATCH] KVM test: Fix two typos in config file

2009-11-18 Thread Yolkfull Chow
Signed-off-by: Yolkfull Chow --- client/tests/kvm/kvm_tests.cfg.sample |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/client/tests/kvm/kvm_tests.cfg.sample b/client/tests/kvm/kvm_tests.cfg.sample index ac9ef66..7f37994 100644 --- a/client/tests/kvm

Re: [Autotest] [KVM-AUTOTEST PATCH 7/7] KVM test: remove monitor socket file when destroying a VM

2009-11-05 Thread Yolkfull Chow
On Thu, Nov 05, 2009 at 12:01:12PM +0200, Michael Goldish wrote: > This should slow the rate of accumulation of monitor files in /tmp. Hi Michael, I recommend we use TCP as monitor dev of VM. Two reasons: 1) we don't need to add extra code to remove monitor files 2) it's necessary for some user

Re: [Autotest] [KVM-AUTOTEST PATCH 5/7] KVM test: minor pci_hotplug fixes

2009-11-05 Thread Yolkfull Chow
On Thu, Nov 05, 2009 at 12:01:10PM +0200, Michael Goldish wrote: > - Put the PCI device removal code in a finally clause. Hi Michael, I have a little concern with the removal procedure. Thinking about if pci_add failed, the output will not contain right information including PCI ID. The slice ope

Re: [Autotest] [PATCH] [RFC] KVM test: Major control file cleanup

2009-11-03 Thread Yolkfull Chow
On Wed, Oct 28, 2009 at 02:04:59PM -0400, Michael Goldish wrote: > > - "Lucas Meneghel Rodrigues" wrote: > > > On Wed, Oct 28, 2009 at 1:43 PM, Michael Goldish > > wrote: > > > Sounds great, except it won't allow you to debug your configuration > > > using kvm_config.py.  So the question no

[PATCH] Seperate smp from extra_params and add into default VM params

2009-11-02 Thread Yolkfull Chow
We may need leave smp as standalone parameter of VM. Reasons I can proposal: 1) memory is a standalone parameter, so is smp 2) smp parameter is needed in some test case, say VM params_verify Signed-off-by: Yolkfull Chow --- client/tests/kvm/kvm_tests.cfg.sample |3 ++- client/tests/kvm

Re: GDB Debugging

2009-10-24 Thread Yolkfull Chow
On Fri, Oct 23, 2009 at 09:19:40AM -0700, Saksena, Abhishek wrote: > > Hi Guys, > > Any help will be appreciated on following issue. I have been struggling on > this for quite some time... > > > -Abhishek > > > > -Original Message- > From: Saksena, Abhishek > Sent: Tuesday, October

[PATCH] Add 'downscript=no' into kvm command line

2009-10-20 Thread Yolkfull Chow
If no downscript is assigned, add 'downscript=no' to avoid error: /etc/qemu-ifdown: could not launch network script Signed-off-by: Yolkfull Chow --- client/tests/kvm/kvm_vm.py |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/cl

Re: [Autotest] [PATCH] Add pass through feature test (support SR-IOV)

2009-10-14 Thread Yolkfull Chow
the features being tested > are fairly complex. > > Thanks! Lucas, thank you very much for adding a detailed explanation and improving for this test. I had reviewed the new patch and some new consideration came to my mind. I had added them on the email, please reviewed. :) > > On Mon,

Re: [PATCH] KVM test: Add PCI pass through test

2009-10-14 Thread Yolkfull Chow
max_vfs' in config file. > * For physical NIC card pass through, we should specify the device > name(s). > > Signed-off-by: Yolkfull Chow > --- > client/tests/kvm/kvm_tests.cfg.sample | 11 ++- > client/tests/kvm/kvm_utils.py | 278 >

Re: [Autotest] [PATCH] Add a kvm test guest_s4 which supports both Linux and Windows platform

2009-10-14 Thread Yolkfull Chow
On Wed, Oct 14, 2009 at 06:58:01AM -0300, Lucas Meneghel Rodrigues wrote: > On Tue, Oct 13, 2009 at 11:54 PM, Yolkfull Chow wrote: > > On Tue, Oct 13, 2009 at 05:29:40PM -0300, Lucas Meneghel Rodrigues wrote: > >> Hi Yolkfull and Chen: > >> > >> Thanks for

Re: [Autotest] [PATCH] Add a kvm test guest_s4 which supports both Linux and Windows platform

2009-10-13 Thread Yolkfull Chow
Sep 27, 2009 at 6:11 AM, Yolkfull Chow wrote: > > For this case, Ken Cao wrote the linux part previously and I did extensive > > modifications on Windows platform support. > > > > Signed-off-by: Ken Cao > > Signed-off-by: Yolkfull Chow > > --- > >  c

[PATCH] Little bug fix in pci_hotplug.py

2009-10-13 Thread Yolkfull Chow
If command executed timeout, the return value of status could be None, which is missed in judge statement: if s: ... Thanks Jason Wang for pointing this out. Signed-off-by: Yolkfull Chow --- client/tests/kvm/tests/pci_hotplug.py |2 +- 1 files changed, 1 insertions(+), 1 deletions

Re: [Autotest] [PATCH] Fix a bug in function create in kvm_vm

2009-10-12 Thread Yolkfull Chow
On Sun, Oct 11, 2009 at 08:53:05PM -0300, Lucas Meneghel Rodrigues wrote: > On Sat, 2009-10-10 at 16:48 +0800, Yolkfull Chow wrote: > > On Sat, Oct 10, 2009 at 04:24:45PM +0800, Yolkfull Chow wrote: > > > On Mon, Oct 05, 2009 at 04:03:22PM -0300, Lucas Meneghel Rodrigues wrote: &

Re: [Autotest] [PATCH] Fix a bug in function create in kvm_vm

2009-10-10 Thread Yolkfull Chow
On Sat, Oct 10, 2009 at 04:24:45PM +0800, Yolkfull Chow wrote: > On Mon, Oct 05, 2009 at 04:03:22PM -0300, Lucas Meneghel Rodrigues wrote: > > Hi Yolkfull! I've checked your patch, but it turns out that the comma > > is valid syntax for the logging module. By any chance you

Re: [Autotest] [PATCH] Fix a bug in function create in kvm_vm

2009-10-10 Thread Yolkfull Chow
rop code readability. Anyway, thanks for checking. > > On Mon, Sep 28, 2009 at 4:45 AM, Yolkfull Chow wrote: > > > > Signed-off-by: Yolkfull Chow > > --- > >  client/tests/kvm/kvm_vm.py |    2 +- > >  1 files changed, 1 insertions(+), 1 deletions(-) &

[PATCH] Add two parameters for wait_for_login

2009-09-30 Thread Yolkfull Chow
Sometimes we need login to guest using different start_time and step_time. Signed-off-by: Yolkfull Chow --- client/tests/kvm/kvm_test_utils.py |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/client/tests/kvm/kvm_test_utils.py b/client/tests/kvm/kvm_test_utils.py

[PATCH] Fix a bug in function create in kvm_vm

2009-09-28 Thread Yolkfull Chow
Signed-off-by: Yolkfull Chow --- client/tests/kvm/kvm_vm.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py index 55220f9..8ae 100755 --- a/client/tests/kvm/kvm_vm.py +++ b/client/tests/kvm/kvm_vm.py @@ -406,7

[PATCH] Change log message of VM login

2009-09-27 Thread Yolkfull Chow
We may use this function 'wait_for_login' for several times in a case, only the first time login could be "Waiting guest to be up". Signed-off-by: Yolkfull Chow --- client/tests/kvm/kvm_test_utils.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --gi

[PATCH] Add a kvm test guest_s4 which supports both Linux and Windows platform

2009-09-27 Thread Yolkfull Chow
For this case, Ken Cao wrote the linux part previously and I did extensive modifications on Windows platform support. Signed-off-by: Ken Cao Signed-off-by: Yolkfull Chow --- client/tests/kvm/kvm_tests.cfg.sample | 14 +++ client/tests/kvm/tests/guest_s4.py| 66

Re: [Autotest] [KVM-AUTOTEST PATCH 2/4] KVM test: rss.cpp: send characters to the console window rather than directly to STDIN

2009-09-22 Thread Yolkfull Chow
On Mon, Sep 21, 2009 at 08:30:26AM -0400, Michael Goldish wrote: > > - "Yolkfull Chow" wrote: > > > On Sun, Sep 20, 2009 at 06:16:28PM +0300, Michael Goldish wrote: > > > Some Windows programs behave badly when their STDIN is redirected to > > a pi

Re: [Autotest] [KVM-AUTOTEST PATCH 2/4] KVM test: rss.cpp: send characters to the console window rather than directly to STDIN

2009-09-21 Thread Yolkfull Chow
On Sun, Sep 20, 2009 at 06:16:28PM +0300, Michael Goldish wrote: > Some Windows programs behave badly when their STDIN is redirected to a pipe > (most notably wmic). Therefore, keep STDIN unredirected, and send input to > the > console window as a series of WM_CHAR messages. Hi Michael, I just t

Re: [Autotest] [KVM-AUTOTEST PATCH 0/7] KVM test: support for the new remote shell server for Windows

2009-09-18 Thread Yolkfull Chow
On Thu, Sep 17, 2009 at 11:40:46AM -0400, Michael Goldish wrote: > > - "Michael Goldish" wrote: > > > - "Yolkfull Chow" wrote: > > > > > On Tue, Aug 18, 2009 at 06:30:14PM -0400, Michael Goldish wrote: > > > > > > &g

[PATCH] Add pass through feature test (support SR-IOV)

2009-09-14 Thread Yolkfull Chow
It supports both SR-IOV virtual functions' and physical NIC card pass through. * For SR-IOV virtual functions passthrough, we could specify the module parameter 'max_vfs' in config file. * For physical NIC card pass through, we should specify the device name(s). Signed-o

Re: [Autotest] [KVM-AUTOTEST PATCH 0/7] KVM test: support for the new remote shell server for Windows

2009-09-14 Thread Yolkfull Chow
On Tue, Aug 18, 2009 at 06:30:14PM -0400, Michael Goldish wrote: > > - "Lucas Meneghel Rodrigues" wrote: > > > On Tue, Aug 18, 2009 at 7:15 AM, Michael Goldish > > wrote: > > > > > > - "Lucas Meneghel Rodrigues" wrote: > > > > > >> Ok, very good, similarly to the previous patchset, I re

Re: [Autotest] [PATCH 12/19] KVM test: Add new module kvm_test_utils.py

2009-09-14 Thread Yolkfull Chow
On Mon, Sep 14, 2009 at 10:58:01AM +0300, Uri Lublin wrote: > On 09/14/2009 08:26 AM, Yolkfull Chow wrote: >> On Wed, Sep 09, 2009 at 09:12:05PM +0300, Michael Goldish wrote: >>> This module is meant to reduce code size by performing common test >>> procedures. >

Re: [Autotest] [PATCH 12/19] KVM test: Add new module kvm_test_utils.py

2009-09-13 Thread Yolkfull Chow
On Wed, Sep 09, 2009 at 09:12:05PM +0300, Michael Goldish wrote: > This module is meant to reduce code size by performing common test procedures. > Generally, code here should look like test code. > More specifically: > - Functions in this module should raise exceptions if things go wrong >

Re: [Autotest] [KVM-AUTOTEST PATCH v2 1/3] KVM test: add AutoIt test

2009-08-11 Thread Yolkfull Chow
On Tue, Aug 11, 2009 at 09:27:17AM -0400, Michael Goldish wrote: > > - "Yolkfull Chow" wrote: > > > On Tue, Aug 11, 2009 at 03:10:42PM +0300, Michael Goldish wrote: > > > Currently the test only logs in, runs a given script and fails if > > the scrip

Re: [Autotest] [KVM-AUTOTEST PATCH v2 1/3] KVM test: add AutoIt test

2009-08-11 Thread Yolkfull Chow
On Tue, Aug 11, 2009 at 03:10:42PM +0300, Michael Goldish wrote: > Currently the test only logs in, runs a given script and fails if the script > takes too long to exit or if its exit status is nonzero. > > The test expects these parameters: > autoit_binary: Path to AutoIt binary in the guest. > a

Re: [PATCH] Add a subtest pci_hotplug in kvm test

2009-08-04 Thread Yolkfull Chow
GOOD 953 Signed-off-by: Yolkfull Chow --- client/tests/kvm/kvm.py |1 + client/tests/kvm/kvm_tests.cfg.sample | 67 + client/tests/kvm/kvm_tests.py | 105 + client/tests/kvm/kvm_vm.py|2

Re: [PATCH] Add a subtest pci_hotplug in kvm test

2009-08-04 Thread Yolkfull Chow
.nic_hotplug.nic_virtio GOOD 99 completed successfully Win2008.32.block_hotplug.fmt_qcow2.block_scsi GOOD 90 completed successfully GOOD 953 Signed-off-by: Yolkfull Chow --- client/tests

Re: [KVM-AUTOTEST PATCH 12/12] KVM test: make stress_boot work properly with TAP networking

2009-08-04 Thread Yolkfull Chow
On Mon, Aug 03, 2009 at 04:00:45AM -0400, Michael Goldish wrote: > > - "Yolkfull Chow" wrote: > > > On Mon, Aug 03, 2009 at 02:45:23AM -0400, Michael Goldish wrote: > > > > > > - "Yolkfull Chow" wrote: > > > > &

Re: [PATCH] Add a subtest pci_hotplug in kvm test

2009-08-03 Thread Yolkfull Chow
On Mon, Aug 03, 2009 at 02:37:29PM +0300, Dor Laor wrote: > On 08/03/2009 12:19 PM, Yolkfull Chow wrote: >> On 06/30/2009 09:58 PM, Dor Laor wrote: >>> On 06/30/2009 02:11 PM, Yolkfull Chow wrote: >>>> Signed-off-by: Yolkfull Chow >>>> --- >>>&g

Re: [PATCH] Add a subtest pci_hotplug in kvm test

2009-08-03 Thread Yolkfull Chow
On 06/30/2009 09:58 PM, Dor Laor wrote: On 06/30/2009 02:11 PM, Yolkfull Chow wrote: Signed-off-by: Yolkfull Chow --- client/tests/kvm/kvm.py |1 + client/tests/kvm/kvm_tests.cfg.sample | 56 client/tests/kvm/kvm_tests.py | 93

Re: [KVM-AUTOTEST PATCH 12/12] KVM test: make stress_boot work properly with TAP networking

2009-08-03 Thread Yolkfull Chow
On Mon, Aug 03, 2009 at 02:45:23AM -0400, Michael Goldish wrote: > > - "Yolkfull Chow" wrote: > > > Hi Michael, I just have some comments on what you changed on > > stress_boot. :-) > > > > > > On Mon, Aug 03, 2009 at 02:58:21AM +0300

Re: [KVM-AUTOTEST PATCH 12/12] KVM test: make stress_boot work properly with TAP networking

2009-08-02 Thread Yolkfull Chow
Hi Michael, I just have some comments on what you changed on stress_boot. :-) On Mon, Aug 03, 2009 at 02:58:21AM +0300, Michael Goldish wrote: > Take an additional parameter 'clone_address_index_base' which indicates the > initial value for 'address_index' for the cloned VMs. This value is > inc

Re: [PATCH] Specify the system UUID for VM

2009-07-29 Thread Yolkfull Chow
On Wed, Jul 29, 2009 at 09:06:25PM +0800, Yolkfull Chow wrote: > On Wed, Jul 29, 2009 at 03:18:51PM +0300, Avi Kivity wrote: > > On 07/16/2009 01:26 PM, Yolkfull Chow wrote: > >> Signed-off-by: Yolkfull Chow > >> --- > >> client/tests/kvm/kvm_vm.py | 11 ++

Re: [PATCH] Specify the system UUID for VM

2009-07-29 Thread Yolkfull Chow
On Wed, Jul 29, 2009 at 03:18:51PM +0300, Avi Kivity wrote: > On 07/16/2009 01:26 PM, Yolkfull Chow wrote: >> Signed-off-by: Yolkfull Chow >> --- >> client/tests/kvm/kvm_vm.py | 11 +++ >> 1 files changed, 11 insertions(+), 0 deletions(-) >> >>

Re: [Autotest] [PATCH] Add a kvm subtest -- pci_hotplug, which supports both Windows OS and Linux OS.

2009-07-28 Thread Yolkfull Chow
On Tue, Jul 28, 2009 at 02:03:10AM -0300, Lucas Meneghel Rodrigues wrote: > On Thu, Jul 23, 2009 at 4:18 AM, Yolkfull Chow wrote: > >>> Hi Yaniv, following is the output from Windows guest: > >>> > >>> --- > >>> Microsoft DiskPart versi

Re: [PATCH] Add a kvm subtest -- pci_hotplug, which supports both Windows OS and Linux OS.

2009-07-23 Thread Yolkfull Chow
On Tue, Jul 21, 2009 at 10:45:31AM +0300, Yaniv Kaul wrote: > On 7/21/2009 9:11 AM, Yolkfull Chow wrote: > > >> >>>> >>>> >>>>>> Previously, I used 'create partition primary' to verify whether the disk >>>&g

Re: [Autotest] [KVM-AUTOTEST PATCH 12/17] KVM test: add simple timedrift test (mainly for Windows)

2009-07-21 Thread Yolkfull Chow
On Tue, Jul 21, 2009 at 11:29:56AM -0400, Michael Goldish wrote: > > - "Yolkfull Chow" wrote: > > > On Mon, Jul 20, 2009 at 06:07:19PM +0300, Michael Goldish wrote: > > > 1) Log into a guest. > > > 2) Take a time reading from the guest and ho

Re: [Autotest] [KVM-AUTOTEST PATCH 12/17] KVM test: add simple timedrift test (mainly for Windows)

2009-07-21 Thread Yolkfull Chow
On Mon, Jul 20, 2009 at 06:07:19PM +0300, Michael Goldish wrote: > 1) Log into a guest. > 2) Take a time reading from the guest and host. > 3) Run load on the guest and host. > 4) Take a second time reading. > 5) Stop the load and rest for a while. > 6) Take a third time reading. > 7) If the drift

Re: [PATCH] Add a kvm subtest -- pci_hotplug, which supports both Windows OS and Linux OS.

2009-07-21 Thread Yolkfull Chow
On Tue, Jul 21, 2009 at 10:45:31AM +0300, Yaniv Kaul wrote: > On 7/21/2009 9:11 AM, Yolkfull Chow wrote: > > >> >>>> >>>> >>>>>> Previously, I used 'create partition primary' to verify whether the disk >>>&g

Re: [PATCH] Add a kvm subtest -- pci_hotplug, which supports both Windows OS and Linux OS.

2009-07-21 Thread Yolkfull Chow
On Tue, Jul 21, 2009 at 10:45:31AM +0300, Yaniv Kaul wrote: > On 7/21/2009 9:11 AM, Yolkfull Chow wrote: > > >> >>>> >>>> >>>>>> Previously, I used 'create partition primary' to verify whether the disk >>>&g

  1   2   >