Re: [PATCH] uio: add irq control support to uio_pci_generic

2015-04-20 Thread Stephen Hemminger
On Mon, 20 Apr 2015 15:59:06 +0200 "Michael S. Tsirkin" wrote: > On Thu, Apr 16, 2015 at 02:21:10PM -0700, Stephen Hemminger wrote: > > On Thu, 16 Apr 2015 09:43:24 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Apr 15, 2015 at 09:5

Re: [PATCH] uio: add irq control support to uio_pci_generic

2015-04-16 Thread Stephen Hemminger
On Thu, 16 Apr 2015 09:43:24 +0200 "Michael S. Tsirkin" wrote: > On Wed, Apr 15, 2015 at 09:59:34AM -0700, Stephen Hemminger wrote: > > The driver already supported INTX interrupts but had no in kernel > > function to enable and disable them. > > > > It is

[PATCH] uio: add irq control support to uio_pci_generic

2015-04-15 Thread Stephen Hemminger
The driver already supported INTX interrupts but had no in kernel function to enable and disable them. It is possible for userspace to do this by accessing PCI config directly, but this racy and better handled by same mechanism that already exists in kernel. Signed-off-by: Stephen Hemminger

Re: [PATCH 1/3] bridge: preserve random init MAC address

2014-03-18 Thread Stephen Hemminger
On Wed, 12 Mar 2014 20:15:25 -0700 "Luis R. Rodriguez" wrote: > As it is now if you add create a bridge it gets started > with a random MAC address and if you then add a net_device > as a slave but later kick it out you end up with a zero > MAC address. Instead preserve the original random MAC >

Re: [PATCH 3/3] bridge: fix bridge root block on designated port

2014-03-13 Thread Stephen Hemminger
On Wed, 12 Mar 2014 20:15:27 -0700 "Luis R. Rodriguez" wrote: > --- a/net/bridge/br_private.h > +++ b/net/bridge/br_private.h > @@ -150,6 +150,7 @@ struct net_bridge_port > u8 priority; > u8 state; > u16

Re: [RFC v3 0/6] networking: address root block upon initialization

2014-03-03 Thread Stephen Hemminger
On Mon, 3 Mar 2014 17:05:18 -0800 "Luis R. Rodriguez" wrote: > On Mon, Mar 3, 2014 at 2:46 PM, Luis R. Rodriguez > wrote: > > From: "Luis R. Rodriguez" > > <-- snip --> > > > As I tested using the root block preference I noticed that if a net_device > > slave under the bridge gets the designa

Re: [RFC v3 4/6] bridge: enable root block during device registration

2014-03-03 Thread Stephen Hemminger
On Mon, 3 Mar 2014 15:58:50 -0800 "Luis R. Rodriguez" wrote: > On Mon, Mar 3, 2014 at 3:43 PM, Stephen Hemminger > wrote: > > Doing this in priv flags bloats what is a limited resource (# of bits). > > Agreed. I tried to avoid it but saw no other option

Re: [RFC v3 4/6] bridge: enable root block during device registration

2014-03-03 Thread Stephen Hemminger
er to do that properly we'd need to > evaluate all other types of master device implementations. > > [0] echo 1 > /sys/devices/vif-2-0/net/vif2.0/brport/root_block > > Cc: Stephen Hemminger > Cc: bri...@lists.linux-foundation.org > Cc: net...@vger.kernel.org > Cc:

Re: [Xen-devel] [RFC v2 1/4] bridge: enable interfaces to opt out from becoming the root bridge

2014-02-20 Thread Stephen Hemminger
On Wed, 19 Feb 2014 09:59:33 -0800 "Luis R. Rodriguez" wrote: > On Wed, Feb 19, 2014 at 9:08 AM, Stephen Hemminger > wrote: > > On Wed, 19 Feb 2014 09:02:06 -0800 > > "Luis R. Rodriguez" wrote: > > > >> Folks, what if I repurpose my pat

Re: [Xen-devel] [RFC v2 1/4] bridge: enable interfaces to opt out from becoming the root bridge

2014-02-19 Thread Stephen Hemminger
On Wed, 19 Feb 2014 09:02:06 -0800 "Luis R. Rodriguez" wrote: > Folks, what if I repurpose my patch to use the IFF_BRIDGE_NON_ROOT (or > relabel to IFF_ROOT_BLOCK_DEF) flag for a default driver preference > upon initialization so that root block will be used once the device > gets added to a brid

Re: [RFC v2 2/4] net: enables interface option to skip IP

2014-02-18 Thread Stephen Hemminger
On Tue, 18 Feb 2014 13:19:15 -0800 "Luis R. Rodriguez" wrote: > Sure, but note that the both disable_ipv6 and accept_dada sysctl > parameters are global. ipv4 and ipv6 interfaces are created upon > NETDEVICE_REGISTER, which will get triggered when a driver calls > register_netdev(). The goal of t

Re: [RFC v2 1/4] bridge: enable interfaces to opt out from becoming the root bridge

2014-02-16 Thread Stephen Hemminger
:FF. Instead > of using these hacks lets the interfaces annotate its intent and > generalizes a solution for multiple drivers, while letting the > drivers use a random MAC address or one prefixed with a proper OUI. > This sort of hack is used by both qemu and xen for their backend > interface

Re: 8% performance improved by change tap interact with kernel stack

2014-01-28 Thread Stephen Hemminger
On Tue, 28 Jan 2014 12:33:25 +0200 "Michael S. Tsirkin" wrote: > On Tue, Jan 28, 2014 at 06:19:02PM +0800, Qin Chuanyu wrote: > > On 2014/1/28 17:41, Michael S. Tsirkin wrote: > > >>>I think it's okay - IIUC this way we are processing xmit directly > > >>>instead of going through softirq. > > >>>

Re: [PATCH kvm-next 2/2] kvm: remove dead code

2013-12-30 Thread Stephen Hemminger
On Mon, 30 Dec 2013 09:37:15 +0200 Gleb Natapov wrote: > On Sun, Dec 29, 2013 at 12:13:08PM -0800, Stephen Hemminger wrote: > > The function kvm_io_bus_read_cookie is defined but never used > > in current in-tree code. > > > It was added recently by Cornelia (copied) w

[PATCH kvm-next 2/2] kvm: remove dead code

2013-12-29 Thread Stephen Hemminger
The function kvm_io_bus_read_cookie is defined but never used in current in-tree code. Signed-off-by: Stephen Hemminger --- a/include/linux/kvm_host.h 2013-12-27 13:12:19.409612858 -0800 +++ b/include/linux/kvm_host.h 2013-12-27 13:12:42.261259369 -0800 @@ -172,8 +172,6 @@ int

[PATCH kvm-next 1/2] kvm: make local functions static

2013-12-29 Thread Stephen Hemminger
Running 'make namespacecheck' found lots of functions that should be declared static, since only used in one file. Signed-off-by: Stephen Hemminger --- include/linux/kvm_host.h | 16 virt/kvm/ioapic.c|2 +- virt/kvm/ioapic.h|1 - virt/kvm/

Re: [RFC PATCH v2 1/1] Workqueue based vhost workers

2013-10-14 Thread Stephen Hemminger
On Sun, 13 Oct 2013 21:55:43 -0400 Bandan Das wrote: > + > + if (cmwq_worker) { > + ret = vhost_wq_init(); > + if (ret) { > + pr_info("Enabling wq based vhost workers failed! " > + "Switching to device based worker inste

Re: I/O port permission bit inheritance between threads

2013-05-21 Thread Stephen Hemminger
On Tue, 21 May 2013 13:01:18 +0300 Gleb Natapov wrote: > On Tue, May 21, 2013 at 11:50:30AM +0200, Joerg Roedel wrote: > > Hey Stephen, > > > > On Mon, May 20, 2013 at 02:24:31PM -0700, Stephen Hemminger wrote: > > > ioperm() inheritance across threads is different

I/O port permission bit inheritance between threads

2013-05-20 Thread Stephen Hemminger
ioperm() inheritance across threads is different in KVM then when run on physical hardware. The following program runs on physical hardware but get SEGV under KVM. It appears that the I/O permission bits are not shared between threads in the same way. /* Original Copyright 2011, Kees Cook , Lice

Locking problem in KVM (or MM)

2013-01-16 Thread Stephen Hemminger
Lockdep splat, appears to be KVM related with 3.8-rc1 [24428.429305] [24428.429308] = [24428.429309] [ INFO: possible recursive locking detected ] [24428.429312] 3.8.0-rc1-net-next+ #4 Tainted: GW [24428.429312] --

Re: [PATCH net-next v3 0/3] Multiqueue support in virtio-net

2012-12-07 Thread Stephen Hemminger
queues=2,... > > > > then enable the multiqueue through ethtool by: > > > > ethtool -L eth0 combined 2 > > It seems like most, if not all, of the feedback given for this series > has been addressed by Jason. > > Can I get some ACKs? Other than the minor

Re: [PATCH net-next v3 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info

2012-12-07 Thread Stephen Hemminger
Minor style issue reported by checkpatch which can be fixed after merge. Although sizeof is actually an operator in C, it is considered correct style to treat it as a function. WARNING: sizeof hdr->hdr should be sizeof(hdr->hdr) #293: FILE: drivers/net/virtio_net.c:395: + sg_set_buf(rq->sg,

Re: [Question]About KVM network zero-copy feature!

2012-08-11 Thread Stephen Hemminger
On Fri, 10 Aug 2012 11:34:32 +0800 "Peter Huang(Peng)" wrote: > Hi,All > > I searched from git-log, and found that until now we have vhost TX zero-copy > experiment feature, how > about RX zero-copy? > > For XEN, net-back also only has TX zero-copy, Is there any reason that RX > zero-copy sti

Re: [net-next RFC V5 5/5] virtio_net: support negotiating the number of queues through ctrl vq

2012-07-05 Thread Stephen Hemminger
On Fri, 06 Jul 2012 11:20:06 +0800 Jason Wang wrote: > On 07/05/2012 08:51 PM, Sasha Levin wrote: > > On Thu, 2012-07-05 at 18:29 +0800, Jason Wang wrote: > >> @@ -1387,6 +1404,10 @@ static int virtnet_probe(struct virtio_device *vdev) > >> if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_

Re: [PATCH RFC] tun: experimental zero copy tx support

2012-05-14 Thread Stephen Hemminger
On Sun, 13 May 2012 18:52:06 +0300 "Michael S. Tsirkin" wrote: > + /* Userspace may produce vectors with count greater than > + * MAX_SKB_FRAGS, so we need to linearize parts of the skb > + * to let the rest of data to be fit in the frags. > + */

Re: [net-next PATCH v0 0/5] Series short description

2012-03-19 Thread Stephen Hemminger
On Mon, 19 Mar 2012 19:49:50 -0700 John Fastabend wrote: > On 3/19/2012 5:35 PM, David Miller wrote: > > From: John Fastabend > > Date: Mon, 19 Mar 2012 17:27:00 -0700 > > > >> Dave, its probably fine to push this to 3.5 then. > > > > Fair enough. > > Stephen, please let me know if you see an

Re: [net-next PATCH v0 0/5] Series short description

2012-03-19 Thread Stephen Hemminger
On Mon, 19 Mar 2012 18:38:08 -0400 (EDT) David Miller wrote: > From: John Fastabend > Date: Sun, 18 Mar 2012 23:51:45 -0700 > > > This series is a follow up to this thread: > > > > http://www.spinics.net/lists/netdev/msg191360.html > > Can the interested parties please review this series? >

Re: [RFC PATCH v1 4/4] ixgbe: enable FDB netdevice ops

2012-03-09 Thread Stephen Hemminger
> Enable FDB ops on ixgbe when in SR-IOV mode. > > Signed-off-by: John Fastabend Will all this break anything on the vf client? What if the vf is running a bridge. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majord

Re: [RFC PATCH v0 1/2] net: bridge: propagate FDB table into hardware

2012-02-29 Thread Stephen Hemminger
On Wed, 29 Feb 2012 09:25:56 -0800 John Fastabend wrote: > On 2/29/2012 5:56 AM, Jamal Hadi Salim wrote: > > On Tue, 2012-02-28 at 20:40 -0800, John Fastabend wrote: > > > >> OK back to this. The last piece is where to put these messages... > >> we could take PF_ROUTE:RTM_*NEIGH > >> > >> P

Re: [RFC PATCH v0 1/2] net: bridge: propagate FDB table into hardware

2012-02-14 Thread Stephen Hemminger
On Tue, 14 Feb 2012 10:57:04 -0800 John Fastabend wrote: > On 2/14/2012 5:18 AM, jamal wrote: > > On Mon, 2012-02-13 at 07:13 -0800, John Fastabend wrote: > > > >> The use case here is multiple VFs but the same solution should work with > >> multiple PFs as well. FDB controls should be independe

Re: [RFC PATCH v0 1/2] net: bridge: propagate FDB table into hardware

2012-02-10 Thread Stephen Hemminger
On Fri, 10 Feb 2012 10:18:31 -0500 jamal wrote: > Hi John, > > I went backwards to summarize at the top after going through your email. > > TL;DR version 0.1: > you provide a good use case where it makes sense to do things in the > kernel. IMO, you could make the same arguement if your embedde

Re: [RFC PATCH v0 1/2] net: bridge: propagate FDB table into hardware

2012-02-09 Thread Stephen Hemminger
On Thu, 09 Feb 2012 09:36:47 -0800 John Fastabend wrote: > But the device features makes it easy for user space to learn that the device > supports this sort of offload. Now if all SR-IOV devices support this then it > doesn't matter but I thought there were SR-IOV devices that didn't do any > sw

Re: [RFC PATCH v0 1/2] net: bridge: propagate FDB table into hardware

2012-02-08 Thread Stephen Hemminger
On Wed, 08 Feb 2012 19:22:06 -0800 John Fastabend wrote: > Propagate software FDB table into hardware uc, mc lists when > the NETIF_F_HW_FDB is set. > > This resolves the case below where an embedded switch is used > in hardware to do inter-VF or VF-PF switching. This patch > pushes the FDB entr

Re: [PATCH] vhost-net: add module alias (v2.1)

2012-01-16 Thread Stephen Hemminger
ases, programs (or users) won't have to explicitly call modprobe. Vhost-net will always be available if built into the kernel. It does require assigning a permanent minor number for depmod to work. Also: - use C99 style initialization. - add missing entry in documentation for loop-control S

[PATCH] vhost-net: add module alias (v2.1)

2012-01-11 Thread Stephen Hemminger
style initialization. - add missing entry in documentation for loop-control Signed-off-by: Stephen Hemminger --- 2.1 - add missing documentation for loop control as well Documentation/devices.txt |3 +++ drivers/vhost/net.c|8 +--- include/linux/miscdevice.h |1 + 3

[PATCH] vhost-net: add module alias (v2)

2012-01-11 Thread Stephen Hemminger
style initialization. Signed-off-by: Stephen Hemminger --- v2 - document minor number and make sure to not overlap Documentation/devices.txt |2 ++ drivers/vhost/net.c|8 +--- include/linux/miscdevice.h |1 + 3 files changed, 8 insertions(+), 3 deletions(-) --- a/dr

Re: [PATCH] vhost-net: add module alias

2012-01-11 Thread Stephen Hemminger
On Wed, 11 Jan 2012 11:07:47 +0400 Michael Tokarev wrote: > On 11.01.2012 08:54, Stephen Hemminger wrote: > > By adding the a module alias, programs (or users) won't have to explicitly > > call modprobe. Vhost-net will always be available if built into the kernel. > > I

Re: [PATCH] vhost-net: add module alias

2012-01-11 Thread Stephen Hemminger
On Wed, 11 Jan 2012 15:43:42 +0800 Amos Kong wrote: > On Wed, Jan 11, 2012 at 12:54 PM, Stephen Hemminger > wrote: > > > By adding the a module alias, programs (or users) won't have to explicitly > > call modprobe. Vhost-net will always be available if built into the k

[PATCH] vhost-net: add module alias

2012-01-10 Thread Stephen Hemminger
e C99 style initialization. Signed-off-by: Stephen Hemminger --- drivers/vhost/net.c|8 +--- include/linux/miscdevice.h |1 + 2 files changed, 6 insertions(+), 3 deletions(-) --- a/drivers/vhost/net.c 2012-01-10 10:56:58.883179194 -0800 +++ b/drivers/vhost/net.c 20

Re: [RFC] kvm tools: Implement multiple VQ for virtio-net

2011-11-22 Thread Stephen Hemminger
I have been playing with userspace-rcu which has a number of neat lockless routines for queuing and hashing. But there aren't kernel versions and several of them may require cmpxchg to work. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vge

Re: Why does virtmanager (VNC) console get stuck in caps lock mode?

2010-07-30 Thread Stephen Hemminger
On Fri, 30 Jul 2010 16:11:50 -0500 Anthony Liguori wrote: > On 07/30/2010 03:39 PM, Stephen Hemminger wrote: > > As an emacs user, I remap caps-lock to CTRL key in normal usage. > > But often in KVM console VNC window, it gets stuck in caps lock mode. > > > > Try

Why does virtmanager (VNC) console get stuck in caps lock mode?

2010-07-30 Thread Stephen Hemminger
As an emacs user, I remap caps-lock to CTRL key in normal usage. But often in KVM console VNC window, it gets stuck in caps lock mode. This appears to be a new mis-feature, since it never used to get stuck before (not sure whether is kernel, virt-manager or QEMU). Any clues? -- To unsubscribe from

Re: KVM SMP guests won't work (2.6.35-rc2+)

2010-06-10 Thread Stephen Hemminger
On Thu, 10 Jun 2010 21:44:07 +0300 Avi Kivity wrote: > On 06/10/2010 09:28 PM, Stephen Hemminger wrote: > > With current 2.6.35-rc2 and following configuration, my build guest VM will > > not start (it was working previously). > > > > "Error starting domain

Re: [RFC PATCH v7 01/19] Add a new structure for skb buffer from external.

2010-06-06 Thread Stephen Hemminger
Still not sure this is a good idea for a couple of reasons: 1. We already have lots of special cases with skb's (frags and fraglist), and skb's travel through a lot of different parts of the kernel. So any new change like this creates lots of exposed points for new bugs. Look at cases li

Re: [RFC] [PATCH v2 3/3] Let host NIC driver to DMA to guest user space.

2010-04-08 Thread Stephen Hemminger
On Tue, 6 Apr 2010 14:26:29 +0800 "Xin, Xiaohui" wrote: > >How do you deal with the DoS problem of hostile user space app posting huge > >number of receives and never getting anything. > > That's a problem we are trying to deal with. It's critical for long term. > Currently, we tried to limit

Re: [RFC] [PATCH v2 3/3] Let host NIC driver to DMA to guest user space.

2010-04-02 Thread Stephen Hemminger
On Fri, 2 Apr 2010 15:30:10 +0800 xiaohui@intel.com wrote: > From: Xin Xiaohui > > The patch let host NIC driver to receive user space skb, > then the driver has chance to directly DMA to guest user > space buffers thru single ethX interface. > We want it to be more generic as a zero copy f

Re: [PATCH v1 3/3] Let host NIC driver to DMA to guest user space.

2010-03-06 Thread Stephen Hemminger
On Sat, 6 Mar 2010 17:38:38 +0800 xiaohui@intel.com wrote: > From: Xin Xiaohui > > The patch let host NIC driver to receive user space skb, > then the driver has chance to directly DMA to guest user > space buffers thru single ethX interface. > > Signed-off-by: Xin Xiaohui > Signed-off-by

Re: [RFC] Virtual Machine Device Queues(VMDq) support on KVM

2009-09-22 Thread Stephen Hemminger
On Tue, 22 Sep 2009 13:50:54 +0200 Arnd Bergmann wrote: > On Tuesday 22 September 2009, Michael S. Tsirkin wrote: > > > > More importantly, when virtualizations is used with multi-queue > > > > NIC's the virtio-net NIC is a single CPU bottleneck. The virtio-net > > > > NIC should preserve the par

Re: [RFC] Virtual Machine Device Queues(VMDq) support on KVM

2009-09-21 Thread Stephen Hemminger
On Mon, 21 Sep 2009 16:37:22 +0930 Rusty Russell wrote: > > > Actually this framework can apply to traditional network adapters which > > > have > > > just one tx/rx queue pair. And applications using the same user/kernel > > > interface > > > can utilize this framework to send/receive network

Re: [RFC] Virtual Machine Device Queues(VMDq) support on KVM

2009-09-01 Thread Stephen Hemminger
On Tue, 1 Sep 2009 14:58:19 +0800 "Xin, Xiaohui" wrote: > [RFC] Virtual Machine Device Queues (VMDq) support on KVM > > Network adapter with VMDq technology presents multiple pairs of tx/rx queues, > and renders network L2 sorting mechanism based on MAC addresses and VLAN tags > fo

Re: [RFC PATCH v2 09/19] net: Add vbus_enet driver

2009-04-09 Thread Stephen Hemminger
On Thu, 09 Apr 2009 12:31:29 -0400 Gregory Haskins wrote: > Signed-off-by: Gregory Haskins > --- > > drivers/net/Kconfig | 13 + > drivers/net/Makefile|1 > drivers/net/vbus-enet.c | 680 > +++ > 3 files changed, 694 insertions(+), 0

Re: [RFC PATCH 09/17] net: Add vbus_enet driver

2009-03-31 Thread Stephen Hemminger
On Tue, 31 Mar 2009 14:43:34 -0400 Gregory Haskins wrote: > Signed-off-by: Gregory Haskins > --- > > drivers/net/Kconfig | 13 + > drivers/net/Makefile|1 > drivers/net/vbus-enet.c | 706 > +++ > 3 files changed, 720 insertions(+), 0

Re: [PATCH] AF_VMCHANNEL address family for guest<->host communication.

2008-12-15 Thread Stephen Hemminger
On Mon, 15 Dec 2008 17:01:14 -0600 Anthony Liguori wrote: > David Miller wrote: > > From: Anthony Liguori > > Date: Mon, 15 Dec 2008 14:44:26 -0600 > > > > > >> We want this communication mechanism to be simple and reliable as we > >> want to implement the backends drivers in the host userspa