[PATCH] target-i386: Remove unused data from local array

2014-03-20 Thread Stefan Weil
Signed-off-by: Stefan Weil --- This patch is based on a previous patch for the same file, see http://patchwork.ozlabs.org/patch/330708/. Regards Stefan W. target-i386/kvm.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index

[PATCH] target-i386: Add missing 'static' and 'const' attributes

2014-03-16 Thread Stefan Weil
This fixes warnings from the static code analysis (smatch). Signed-off-by: Stefan Weil --- Why is array para_features in kvm.c terminated by a dummy entry? It is only used in a for loop with upper limit ARRAY_SIZE(para_features) - 1. Regards Stefan target-i386/cpu.c |2 +- target-i386

Re: [PATCH for 1.7] kvm: Fix uninitialized cpuid_data

2013-11-20 Thread Stefan Weil
Am 07.11.2013 12:15, schrieb Gleb Natapov: > On Wed, Nov 06, 2013 at 10:35:27PM +0100, Stefan Weil wrote: >> This error was reported by valgrind when running qemu-system-x86_64 >> with kvm: >> >> ==975== Conditional jump or move depends on uninitialised value(s

Re: [Qemu-devel] [PATCH v2 for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

2013-11-13 Thread Stefan Weil
out when CONFIG_KVM is not > + * defined. > + */ > +uint32_t q(KVMState *env, uint32_t function, > + uint32_t index, int reg) > +{ > +abort(); > +} > +#endif Reviewed-by: Stefan Weil If you happen to write a v3 patch, g_assert_not_reached would be even better than abort. It&

Re: [Qemu-devel] [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

2013-11-12 Thread Stefan Weil
Am 12.11.2013 19:57, schrieb Peter Maydell: > On 12 November 2013 18:54, Richard Henderson wrote: >> For what it's worth, I think BOTH of the patches that have been posted >> should be applied. That is, the patch that does (X || 1) -> (1 || X), >> and the patch that adds the stub. > I think that

[PATCH for 1.7] kvm: Fix uninitialized cpuid_data

2013-11-06 Thread Stefan Weil
) Instead of adding more memset calls for parts of cpuid_data, the existing calls were removed and cpuid_data is now initialized completely in one call. Signed-off-by: Stefan Weil --- I did not check whether older versions also need this fix. Stefan W. target-i386/kvm.c |9 ++--- 1 file

Re: [Qemu-devel] [PATCH] qemu-kvm bugfix for IA32_FEATURE_CONTROL

2013-08-18 Thread Stefan Weil
Am 18.08.2013 20:23, schrieb Liu, Jinsong: > From 1273f8b2e5464ec987facf9942fd3ccc0b69087e Mon Sep 17 00:00:00 2001 > From: Liu Jinsong > Date: Mon, 19 Aug 2013 09:33:30 +0800 > Subject: [PATCH] qemu-kvm bugfix for IA32_FEATURE_CONTROL > > This patch is to fix the bug https://bugs.launchpad.net/qe

[PATCH] kvm: Fix warning from static code analysis

2012-09-03 Thread Stefan Weil
Report from smatch: kvm-all.c:1373 kvm_init(135) warn: variable dereferenced before check 's' (see line 1360) 's' cannot by NULL (it was alloced using g_malloc0), so there is no need to check it here. Signed-off-by: Stefan Weil --- kvm-all.c | 12 +--- 1 file c

Re: [Qemu-devel] [PATCH 0/2] Lost VNC patches

2012-03-14 Thread Stefan Weil
http://patchwork.ozlabs.org/patch/87029/ for the original. Cheers, Stefan W. Thanks, Corentin Chary (1): vnc: don't mess up with iohandlers in the vnc thread Stefan Weil (1): vnc: Limit r/w access to size of allocated memory ui/vnc-jobs-async.c |

Re: [PATCH] Fix fallouts from Linux header inclusion

2011-06-23 Thread Stefan Weil
hosts - fix kvmclock for !CONFIG_KVM - fix s390 build on non-Linux hosts Signed-off-by: Jan Kiszka Tested-by: Stefan Weil The patch fixes the kvm related build errors for mingw32. Stefan -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message

Re: [PATCH 03/12] Switch build system to accompanied kernel headers

2011-06-22 Thread Stefan Weil
Am 22.06.2011 23:37, schrieb Jan Kiszka: On 2011-06-22 22:51, Stefan Weil wrote: If not, kvm="yes" should be restricted to platforms with kvm support. Otherwise, QEMU builds will fail very early: ERROR: Host kernel lacks signalfd() support, but KVM depends on it when the IO thread i

Re: [Qemu-devel] [PATCH 03/12] Switch build system to accompanied kernel headers

2011-06-22 Thread Stefan Weil
Am 08.06.2011 16:10, schrieb Jan Kiszka: This helps reducing our build-time checks for feature support in the available Linux kernel headers. And it helps users that do not have sufficiently recent headers installed on their build machine. Consequently, the patch removes and build-time checks fo

Re: [Qemu-devel] [RFC v1] Add declarations for hierarchical memory region API

2011-05-19 Thread Stefan Weil
Am 19.05.2011 16:12, schrieb Avi Kivity: The memory API separates the attributes of a memory region (its size, how reads or writes are handled, dirty logging, and coalescing) from where it is mapped and whether it is enabled. This allows a device to configure a memory region once, then hand it of

Re: [Qemu-devel] segmentation fault in qemu-kvm-0.14.0

2011-03-15 Thread Stefan Weil
Am 15.03.2011 13:53, schrieb Peter Lieven: On 09.03.2011 08:26, Stefan Weil wrote: Am 08.03.2011 23:53, schrieb Peter Lieven: Hi, during testing of qemu-kvm-0.14.0 i can reproduce the following segfault. i have seen similar crash already in 0.13.0, but had no time to debug. my guess is that

Re: [Qemu-devel] segmentation fault in qemu-kvm-0.14.0

2011-03-09 Thread Stefan Weil
Am 09.03.2011 08:39, schrieb Michael Tokarev: 09.03.2011 10:26, Stefan Weil wrote: Am 08.03.2011 23:53, schrieb Peter Lieven: Hi, during testing of qemu-kvm-0.14.0 i can reproduce the following segfault. i have seen similar crash already in 0.13.0, but had no time to debug. my guess is that

Re: [Qemu-devel] segmentation fault in qemu-kvm-0.14.0

2011-03-08 Thread Stefan Weil
Am 08.03.2011 23:53, schrieb Peter Lieven: Hi, during testing of qemu-kvm-0.14.0 i can reproduce the following segfault. i have seen similar crash already in 0.13.0, but had no time to debug. my guess is that this segfault is related to the threaded vnc server which was introduced in qemu 0.1

Re: [Qemu-devel] [PATCH 2/7] pci: memory access API and IOMMU support

2010-09-02 Thread Stefan Weil
Am 02.09.2010 10:51, schrieb Eduard - Gabriel Munteanu: On Wed, Sep 01, 2010 at 10:10:30PM +0200, Stefan Weil wrote: Please see my comments at the end of this mail. Am 30.08.2010 00:08, schrieb Eduard - Gabriel Munteanu: PCI devices should access memory through pci_memory_

Re: [Qemu-devel] [PATCH 2/7] pci: memory access API and IOMMU support

2010-09-01 Thread Stefan Weil
those type casts could be removed. Regards Stefan Weil -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Qemu-devel] [PATCH 1/2] Add kvm_set_ioeventfd_mmio_long definition for non-KVM systems

2010-08-11 Thread Stefan Weil
Am 11.08.2010 20:16, schrieb Cam Macdonell: --- kvm-stub.c | 5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/kvm-stub.c b/kvm-stub.c index 3378bd3..d45f9fa 100644 --- a/kvm-stub.c +++ b/kvm-stub.c @@ -136,3 +136,8 @@ int kvm_set_ioeventfd_pio_word(int fd, uint16_t addr, ui

Re: [Qemu-devel] [PATCH v8 5/5] RESEND: Inter-VM shared memory PCI device

2010-08-11 Thread Stefan Weil
Am 11.08.2010 19:07, schrieb Paolo Bonzini: On 08/11/2010 11:49 AM, Cam Macdonell wrote: The win32 problems (missing mmap, maybe more) remain. Could you please fix them? Could that be accomplished with excluding it on Windows on the makefiles? Yes, just use obj-$(CONFIG_POSIX). Paolo O

Re: [Qemu-devel] [PATCH v8 5/5] RESEND: Inter-VM shared memory PCI device

2010-08-11 Thread Stefan Weil
Am 27.07.2010 18:54, schrieb Cam Macdonell: resend for bug fix related to removal of irqfd Support an inter-vm shared memory device that maps a shared-memory object as a PCI device in the guest. This patch also supports interrupts between guest by communicating over a unix domain socket. This

Re: [Qemu-devel] Qemu terminating with SIGABRT

2009-12-12 Thread Stefan Weil
David S. Ahern schrieb: > I realize this is a rather generic question, but what are typical > reasons Qemu would be killed by a SIGABRT? I am seeing this on a > somewhat regular (though not repeatable on demand) basis. I do not have > a core file, though I hope to capture one if I can get it repeat

Re: [Qemu-devel] SeaBIOS cdrom regression with Vista

2009-11-17 Thread Stefan Weil
Avi Kivity schrieb: > qemu-kvm's switch to seabios uncovered a regression with cdrom > handling. Vista x64 no longer recognizes the cdrom, while pc-bios > still works. Installing works, but that uses int 13, not the native > driver. Haven't investigated further yet. > > Command line: > > qemu -d

Re: eepro100.c

2009-09-22 Thread Stefan Weil
Amit Shah schrieb: > On (Tue) Sep 22 2009 [13:31:11], Michal Filka wrote: > >> I don't want to corrupt present kvm installation, or better to say, I want >> to modify it as small as possible. Could you suggest me what should I >> replace or how to run new compilation instead of old one without

Re: eepro100.c

2009-09-19 Thread Stefan Weil
Stefan Weil schrieb: > Jan Kiszka schrieb: >> Michal Filka wrote: >>> Hi, >>> >>> I have question on i82557b emulation in kvm. >>> >>> I have run a proprietary operating system (Pharlap OS) in kvm. Part >>> of the job has been portin

Re: eepro100.c

2009-09-19 Thread Stefan Weil
Jan Kiszka schrieb: > Michal Filka wrote: >> Hi, >> >> I have question on i82557b emulation in kvm. >> >> I have run a proprietary operating system (Pharlap OS) in kvm. Part >> of the job has been porting driver for i8255x. During the job I >> discovered that kvm's emulation doesn't support a RNR i

Re: [Qemu-devel] [RFC] Bring in all the Linux headers we depend on in QEMU

2009-05-03 Thread Stefan Weil
...). Yes, those headers did not always match the features of the current kernel, so --enable-kvm did not work. This is fixed now - there is a linux-libc-dev 2.6.29-3 which is up-to-date. So, at the moment I see no need to fill the QEMU source tree with linux header files. For special needs the conf