Re: [PATCH] KVM: PPC: Implement extension to report number of memslots

2015-10-26 Thread Scott Wood
On Mon, 2015-10-26 at 16:15 +1100, Paul Mackerras wrote: > On Fri, Oct 16, 2015 at 08:41:31AM +0200, Thomas Huth wrote: > > Yes, we'll likely need this soon! 32 slots are not enough... > > Would anyone object if I raised the limit for PPC to 512 slots? > Would that cause problems on embedded PPC,

Re: [PATCH] KVM: PPC: e500: fix couple of shift operations on 64 bits

2015-10-01 Thread Scott Wood
On Thu, 2015-10-01 at 15:58 +0300, Laurentiu Tudor wrote: > Fix couple of cases where we shift left a 32-bit > value thus might get truncated results on 64-bit > targets. > > Signed-off-by: Laurentiu Tudor > Suggested-by: Scott Wood > --- > arch/powerpc/kvm/e500_mmu_h

Re: [PATCH][v2] KVM: PPC: e500: Emulate TMCFG0 TMRN register

2015-09-28 Thread Scott Wood
2 files changed, 24 insertions(+) Acked-by: Scott Wood -Scott -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 15/19] KVM: PPC: e500: fix handling local_sid_lookup result

2015-09-24 Thread Scott Wood
1 file changed, 2 insertions(+), 1 deletion(-) Acked-by: Scott Wood -Scott -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 1/2] perf,kvm/ppc: Add kvm_perf.h for powerpc

2015-07-31 Thread Scott Wood
[Added KVM lists and a couple relevant people] On Fri, 2015-07-31 at 14:25 +0530, Hemant Kumar wrote: > On 07/30/2015 03:52 AM, Scott Wood wrote: > > On Wed, 2015-07-29 at 16:07 +0530, Hemant Kumar wrote: > > > Hi Scott, > > > > > > On 07/17/2015 01:40 AM, Sc

Re: [RFC PATCH 6/6] powerpc/kvm: change the condition of identifying hugetlb vm

2015-07-07 Thread Scott Wood
On Tue, 2015-07-07 at 16:05 +0800, wenwei tao wrote: > Hi Scott > > I understand what you said. > > I will use the function 'is_vm_hugetlb_page()' to hide the bit > combinations according to your comments in the next version of patch > set. > > But for the situation like below, there isn't an ob

Re: [RFC PATCH 6/6] powerpc/kvm: change the condition of identifying hugetlb vm

2015-07-06 Thread Scott Wood
On Fri, 2015-07-03 at 16:47 +0800, wenwei tao wrote: > Hi Scott > > Thank you for your comments. > > Kernel already has that function: is_vm_hugetlb_page() , but the > original code didn't use it, > in order to keep the coding style of the original code, I didn't use it > either. > > For the sen

Re: [RFC PATCH 6/6] powerpc/kvm: change the condition of identifying hugetlb vm

2015-07-02 Thread Scott Wood
On Wed, 2015-06-10 at 14:27 +0800, Wenwei Tao wrote: > Hugetlb VMAs are not mergeable, that means a VMA couldn't have VM_HUGETLB > and > VM_MERGEABLE been set in the same time. So we use VM_HUGETLB to indicate new > mergeable VMAs. Because of that a VMA which has VM_HUGETLB been set is a > hugetl

Re: [PATCH][RFC] KVM: PPC: fix suspicious use of conditional operator

2015-05-22 Thread Scott Wood
mp; MAS6_SAS) ? MAS1_TS : 0) > | (vcpu->arch.shared->mas4 & MAS4_TSIZED(~0)); > vcpu->arch.shared->mas2 &= MAS2_EPN; > vcpu->arch.shared->mas2 |= vcpu->arch.shared->mas4 & Reviewed-by: Scott Woo

Re: [PATCH] KVM: PPC: check for lookup_linux_ptep() returning NULL

2015-05-21 Thread Scott Wood
i Caraman > Signed-off-by: Laurentiu Tudor > Cc: Scott Wood > --- > based on https://github.com/agraf/linux-2.6.git kvm-ppc-next > > arch/powerpc/kvm/e500_mmu_host.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Scott Wood -Scott -- To unsubscribe

Re: [RFC PATCH] KVM: introduce kvm_check_device

2015-01-07 Thread Scott Wood
On Wed, 2015-01-07 at 10:55 +, Andre Przywara wrote: > Hi Scott, > > thanks for looking at the patch. > > On 06/01/15 20:52, Scott Wood wrote: > > Out of curiosity, why do you need to test it from inside the kernel but > > outside kvm_main.c? > > I n

Re: [RFC PATCH] KVM: introduce kvm_check_device

2015-01-07 Thread Scott Wood
On Wed, 2015-01-07 at 18:11 +, Andre Przywara wrote: > On 07/01/15 17:45, Scott Wood wrote: > > On Wed, 2015-01-07 at 10:55 +, Andre Przywara wrote: > >> Hi Scott, > >> > >> thanks for looking at the patch. > >> > >> On 06/01/15 20:52

Re: [RFC PATCH] KVM: introduce kvm_check_device

2015-01-06 Thread Scott Wood
On Tue, 2015-01-06 at 16:12 +, Andre Przywara wrote: > While we can easily register and unregister KVM devices, there is > currently no easy way of checking whether a device has been > registered. > Introduce kvm_check_device() for that purpose and use it in two > existing functions. Also chang

Re: [PATCH] KVM: PPC: Convert openpic lock to raw_spinlock

2014-09-12 Thread Scott Wood
On Fri, 2014-09-12 at 09:12 -0500, Purcareata Bogdan-B43198 wrote: > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Thursday, September 11, 2014 9:19 PM > > To: Purcareata Bogdan-B43198 > > Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org > > Subject: Re: [PATCH] KVM: PPC: Conve

Re: [PATCH] KVM: PPC: Convert openpic lock to raw_spinlock

2014-09-11 Thread Scott Wood
On Thu, 2014-09-11 at 15:25 -0400, Bogdan Purcareata wrote: > This patch enables running intensive I/O workloads, e.g. netperf, in a guest > deployed on a RT host. No change for !RT kernels. > > The openpic spinlock becomes a sleeping mutex on a RT system. This no longer > guarantees that EPR is a

Re: [PATCH v4] KVM: PPC: BOOKE: Emulate debug registers and exception

2014-08-27 Thread Scott Wood
On Wed, 2014-08-27 at 13:23 +0200, Alexander Graf wrote: > > On 13.08.14 11:09, Bharat Bhushan wrote: > > This patch emulates debug registers and debug exception > > to support guest using debug resource. This enables running > > gdb/kgdb etc in guest. > > > > On BOOKE architecture we cannot shar

Re: [PATCH 7/7 v3] KVM: PPC: BOOKE: Emulate debug registers and exception

2014-08-12 Thread Scott Wood
On Tue, 2014-08-12 at 02:36 -0500, Bhushan Bharat-R65777 wrote: > > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Tuesday, August 12, 2014 5:30 AM > > To: Bhushan Bharat-R65777 > > Cc: ag...@suse.de; kvm-...@vger.kernel.org; kvm@vger.kernel.org; Yoder > > Stuart- > > B08248 >

Re: [PATCH 7/7 v3] KVM: PPC: BOOKE: Emulate debug registers and exception

2014-08-11 Thread Scott Wood
On Wed, 2014-08-06 at 12:08 +0530, Bharat Bhushan wrote: > @@ -1249,6 +1284,7 @@ int kvmppc_subarch_vcpu_init(struct kvm_vcpu *vcpu) > setup_timer(&vcpu->arch.wdt_timer, kvmppc_watchdog_func, > (unsigned long)vcpu); > > + kvmppc_clear_dbsr(); > return 0; This co

Re: [PATCH] KVM: PPC: e500mc: Add support for single threaded vcpus on e6500 core

2014-08-11 Thread Scott Wood
On Tue, 2014-08-12 at 01:53 +0200, Alexander Graf wrote: > > > Am 12.08.2014 um 01:36 schrieb Scott Wood : > > > >> On Wed, 2014-08-06 at 19:33 +0300, Mihai Caraman wrote: > >> @@ -390,19 +400,30 @@ static void kvmppc_core_vcpu_free_e500mc(struct > >

Re: [PATCH] KVM: PPC: e500mc: Add support for single threaded vcpus on e6500 core

2014-08-11 Thread Scott Wood
On Wed, 2014-08-06 at 19:33 +0300, Mihai Caraman wrote: > @@ -390,19 +400,30 @@ static void kvmppc_core_vcpu_free_e500mc(struct > kvm_vcpu *vcpu) > > static int kvmppc_core_init_vm_e500mc(struct kvm *kvm) > { > - int lpid; > + int i, lpid; > > - lpid = kvmppc_alloc_lpid(); > -

Re: [PATCH 5/5 v2] KVM: PPC: BOOKE: Emulate debug registers and exception

2014-08-05 Thread Scott Wood
On Mon, 2014-08-04 at 22:41 -0500, Bhushan Bharat-R65777 wrote: > > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Tuesday, August 05, 2014 4:23 AM > > To: Bhushan Bharat-R65777 > > Cc: ag...@suse.de; kvm-...@vger.kernel.org; kvm@vger.kernel.org; Yoder > > Stuart- > > B08248 >

Re: [PATCH 4/5] KVM: PPC: BOOKE: Clear guest dbsr in userspace exit KVM_EXIT_DEBUG

2014-08-04 Thread Scott Wood
On Mon, 2014-08-04 at 22:33 -0500, Bhushan Bharat-R65777 wrote: > > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Tuesday, August 05, 2014 4:17 AM > > To: Bhushan Bharat-R65777 > > Cc: ag...@suse.de; kvm-...@vger.kernel.org; kvm@vger.kernel.org; Yoder > > Stuart- > > B08248 >

Re: [PATCH 5/5 v2] KVM: PPC: BOOKE: Emulate debug registers and exception

2014-08-04 Thread Scott Wood
On Mon, 2014-08-04 at 13:32 +0530, Bharat Bhushan wrote: > @@ -735,7 +745,27 @@ static int kvmppc_handle_debug(struct kvm_run *run, > struct kvm_vcpu *vcpu) > struct debug_reg *dbg_reg = &(vcpu->arch.shadow_dbg_reg); > u32 dbsr = vcpu->arch.dbsr; > > - /* Clear guest dbsr (vcpu->

Re: [PATCH 4/5] KVM: PPC: BOOKE: Clear guest dbsr in userspace exit KVM_EXIT_DEBUG

2014-08-04 Thread Scott Wood
On Mon, 2014-08-04 at 13:22 +0530, Bharat Bhushan wrote: > Dbsr is not visible to userspace and we do not think any need to > expose this to userspace because: > Userspace cannot inject debug interrupt to guest (as this > does not know guest ability to handle debug interrupt), so > userspace

Re: [PATCH 6/6] KVM: PPC: BOOKE: Emulate debug registers and exception

2014-08-01 Thread Scott Wood
On Fri, 2014-08-01 at 04:34 -0500, Bhushan Bharat-R65777 wrote: > on dbsr write emulation, deque the debug interrupt even if DBSR_IDE is set. > > case SPRN_DBSR: > > vcpu->arch.dbsr &= ~spr_val; > if (!(vcpu->arch.dbsr & ~DBSR_IDE)) >

Re: [PATCH 6/6] KVM: PPC: BOOKE: Emulate debug registers and exception

2014-07-31 Thread Scott Wood
On Thu, 2014-07-31 at 01:15 -0500, Bhushan Bharat-R65777 wrote: > > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Thursday, July 31, 2014 8:18 AM > > To: Bhushan Bharat-R65777 > > Cc: ag...@suse.de; kvm-...@vger.kernel.org; kvm@vger.kernel.org; Yoder > > Stuart- > > B08248 >

Re: [PATCH 6/6] KVM: PPC: BOOKE: Emulate debug registers and exception

2014-07-30 Thread Scott Wood
On Wed, 2014-07-30 at 01:43 -0500, Bhushan Bharat-R65777 wrote: > > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Tuesday, July 29, 2014 3:58 AM > > To: Bhushan Bharat-R65777 > > Cc: ag...@suse.de; kvm-...@vger.kernel.org; kvm@vger.kernel.org; Yoder > > Stuart- > > B08248 > >

Re: [PATCH 1/6] KVM: PPC: BOOKE: No need to set DBCR0_EDM in guest visible register

2014-07-30 Thread Scott Wood
On Wed, 2014-07-30 at 12:57 -0500, Bhushan Bharat-R65777 wrote: > > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Wednesday, July 30, 2014 11:18 PM > > To: Bhushan Bharat-R65777 > > Cc: ag...@suse.de; kvm-...@vger.kernel.org; kvm@vger.kernel.org; Yoder > > Stuart- > > B08248

Re: [PATCH 1/6] KVM: PPC: BOOKE: No need to set DBCR0_EDM in guest visible register

2014-07-30 Thread Scott Wood
On Wed, 2014-07-30 at 00:21 -0500, Bhushan Bharat-R65777 wrote: > > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Tuesday, July 29, 2014 3:22 AM > > To: Bhushan Bharat-R65777 > > Cc: ag...@suse.de; kvm-...@vger.kernel.org; kvm@vger.kernel.org; Yoder > > Stuart- > > B08248 > >

Re: [PATCH 6/6] KVM: PPC: BOOKE: Emulate debug registers and exception

2014-07-29 Thread Scott Wood
On Tue, 2014-07-29 at 16:06 +0200, Alexander Graf wrote: > On 29.07.14 00:33, Scott Wood wrote: > > On Mon, 2014-07-28 at 16:04 +0200, Alexander Graf wrote: > >> On 11.07.14 10:39, Bharat Bhushan wrote: > >>> This patch emulates debug registers and debug exceptio

Re: [PATCH 1/6 v2] KVM: PPC: Book3E: Use common defines for SPE/FP/AltiVec int numbers

2014-07-28 Thread Scott Wood
On Mon, 2014-07-28 at 03:54 -0500, Caraman Mihai Claudiu-B02008 wrote: > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Saturday, July 26, 2014 3:11 AM > > To: Caraman Mihai Claudiu-B02008 > > Cc: Alexander Graf; kvm-...@vger.kernel.org; kvm@vger.kernel.org; > > linuxppc-...@lis

Re: [PATCH 6/6] KVM: PPC: BOOKE: Emulate debug registers and exception

2014-07-28 Thread Scott Wood
On Mon, 2014-07-28 at 16:04 +0200, Alexander Graf wrote: > On 11.07.14 10:39, Bharat Bhushan wrote: > > This patch emulates debug registers and debug exception > > to support guest using debug resource. This enables running > > gdb/kgdb etc in guest. > > > > On BOOKE architecture we cannot share de

Re: [PATCH 6/6] KVM: PPC: BOOKE: Emulate debug registers and exception

2014-07-28 Thread Scott Wood
On Fri, 2014-07-11 at 14:09 +0530, Bharat Bhushan wrote: > This patch emulates debug registers and debug exception > to support guest using debug resource. This enables running > gdb/kgdb etc in guest. > > On BOOKE architecture we cannot share debug resources between QEMU and > guest because: >

Re: [PATCH 5/6] KVM: PPC: BOOKE: Allow guest to change MSR_DE

2014-07-28 Thread Scott Wood
On Fri, 2014-07-11 at 14:09 +0530, Bharat Bhushan wrote: > When userspace is debugging guest then MSR_DE is always set and > MSRP_DEP is set so that guest cannot change MSR_DE. > Guest debug resources are not yet emulated, So there seems no reason > we should stop guest controlling MSR_DE. > Also a

Re: [PATCH 2/6] KVM: PPC: BOOKE: Force MSR_DE in rfci if guest is under debug

2014-07-28 Thread Scott Wood
On Fri, 2014-07-11 at 14:08 +0530, Bharat Bhushan wrote: > When userspace (QEMU) is using the debug resource to debug guest > then we want MSR_DE to be always set. This patch adds missing > MSR_DE setting in "rfci" instruction. > > Signed-off-by: Bharat Bhushan > --- > arch/powerpc/kvm/booke_emu

Re: [PATCH 1/6] KVM: PPC: BOOKE: No need to set DBCR0_EDM in guest visible register

2014-07-28 Thread Scott Wood
On Fri, 2014-07-11 at 14:08 +0530, Bharat Bhushan wrote: > This is not used and even I do not remember why this was added > in first place. > > Signed-off-by: Bharat Bhushan > --- > arch/powerpc/kvm/booke.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/powerpc/kvm/booke.c b/ar

[PATCH] powerpc/e6500: Work around erratum A-008139

2014-07-25 Thread Scott Wood
code, TID clearing has been moved from tlb_miss_kernel_e6500 until after the SMT section. Signed-off-by: Scott Wood --- arch/powerpc/mm/tlb_low_64e.S | 68 +++ 1 file changed, 56 insertions(+), 12 deletions(-) diff --git a/arch/powerpc/mm/tlb_low_64e.S b

Re: [PATCH 1/6 v2] KVM: PPC: Book3E: Use common defines for SPE/FP/AltiVec int numbers

2014-07-25 Thread Scott Wood
On Thu, 2014-07-24 at 04:16 -0500, Caraman Mihai Claudiu-B02008 wrote: > Scott, Alex's request to define SPE handlers only for e500v2 implies changes > in 32-bit FSL kernel to have exclusive configurations for e200/e500v2 and > e500mc/e5500. We would probably need something like this, what's your t

Re: [PATCH 1/6 v2] kvm: ppc: bookehv: Added wrapper macros for shadow registers

2014-07-17 Thread Scott Wood
On Thu, 2014-07-17 at 17:01 +0530, Bharat Bhushan wrote: > There are shadow registers like, GSPRG[0-3], GSRR0, GSRR1 etc on > BOOKE-HV and these shadow registers are guest accessible. > So these shadow registers needs to be updated on BOOKE-HV. > This patch adds new macro for get/set helper of shad

Re: [PATCH] kvm: ppc: booke: Restore SPRG3 when entering guest

2014-07-17 Thread Scott Wood
On Fri, 2014-07-18 at 02:37 +0200, Alexander Graf wrote: > On 18.07.14 02:36, Scott Wood wrote: > > On Fri, 2014-07-18 at 02:33 +0200, Alexander Graf wrote: > >> On 18.07.14 02:28, Scott Wood wrote: > >>> On Thu, 2014-07-17 at 18:29 +0200, Alexander Graf wrote: >

Re: [PATCH] kvm: ppc: booke: Restore SPRG3 when entering guest

2014-07-17 Thread Scott Wood
On Fri, 2014-07-18 at 02:33 +0200, Alexander Graf wrote: > On 18.07.14 02:28, Scott Wood wrote: > > On Thu, 2014-07-17 at 18:29 +0200, Alexander Graf wrote: > >> On 17.07.14 18:27, Alexander Graf wrote: > >>> On 17.07.14 18:24, bharat.bhus...@freescale.com wrote:

Re: [PATCH] kvm: ppc: booke: Restore SPRG3 when entering guest

2014-07-17 Thread Scott Wood
On Thu, 2014-07-17 at 18:29 +0200, Alexander Graf wrote: > On 17.07.14 18:27, Alexander Graf wrote: > > > > On 17.07.14 18:24, bharat.bhus...@freescale.com wrote: > >> > >>> -Original Message- > >>> From: Alexander Graf [mailto:ag...@suse.de] > >>> Sent: Thursday, July 17, 2014 9:41 PM > >>

Re: [RFC PATCH 3/4] KVM: PPC: e500: TLB emulation for IND entries

2014-07-07 Thread Scott Wood
On Thu, 2014-07-03 at 17:45 +0300, Mihai Caraman wrote: > Handle indirect entries (IND) in TLB emulation code. Translation size of IND > entries differ from the size of referred Page Tables (Linux guests now use IND > of 2MB for 4KB PTs) and this require careful tweak of the existing logic. > > TL

Re: [RFC PATCH 2/4] KVM: PPC: Book3E: Handle LRAT error exception

2014-07-07 Thread Scott Wood
On Fri, 2014-07-04 at 10:15 +0200, Alexander Graf wrote: > On 03.07.14 16:45, Mihai Caraman wrote: > > diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c > > index a192975..ab1077f 100644 > > --- a/arch/powerpc/kvm/booke.c > > +++ b/arch/powerpc/kvm/booke.c > > @@ -1286,6 +1286,46 @@

Re: [PATCH 4/6 v2] KVM: PPC: Book3E: Add AltiVec support

2014-07-03 Thread Scott Wood
On Mon, 2014-06-30 at 18:34 +0300, Mihai Caraman wrote: > Add KVM Book3E AltiVec support. KVM Book3E FPU support gracefully reuse host > infrastructure so follow the same approach for AltiVec. > > Signed-off-by: Mihai Caraman > --- > v2: > - integrate Paul's FP/VMX/VSX changes > > arch/powerpc

Re: [PATCH 1/6 v2] KVM: PPC: Book3E: Use common defines for SPE/FP/AltiVec int numbers

2014-07-03 Thread Scott Wood
On Fri, 2014-07-04 at 00:35 +0200, Alexander Graf wrote: > On 04.07.14 00:31, Scott Wood wrote: > > On Thu, 2014-07-03 at 17:15 -0500, Scott Wood wrote: > >> On Thu, 2014-07-03 at 10:25 -0500, Caraman Mihai Claudiu-B02008 wrote: > >>>> -Original Message

Re: [PATCH 1/6 v2] KVM: PPC: Book3E: Use common defines for SPE/FP/AltiVec int numbers

2014-07-03 Thread Scott Wood
On Thu, 2014-07-03 at 17:15 -0500, Scott Wood wrote: > On Thu, 2014-07-03 at 10:25 -0500, Caraman Mihai Claudiu-B02008 wrote: > > > -Original Message- > > > From: Alexander Graf [mailto:ag...@suse.de] > > > Sent: Thursday, July 03, 2014 3:21 PM > > >

Re: [PATCH 1/6 v2] KVM: PPC: Book3E: Use common defines for SPE/FP/AltiVec int numbers

2014-07-03 Thread Scott Wood
On Thu, 2014-07-03 at 10:25 -0500, Caraman Mihai Claudiu-B02008 wrote: > > -Original Message- > > From: Alexander Graf [mailto:ag...@suse.de] > > Sent: Thursday, July 03, 2014 3:21 PM > > To: Caraman Mihai Claudiu-B02008; kvm-...@vger.kernel.org > > Cc: kvm@vger.kernel.org; linuxppc-...@lis

Re: [PATCH 2/2] KVM : powerpc/booke: Allow debug interrupt injection to guest

2014-07-01 Thread Scott Wood
On Tue, 2014-07-01 at 18:22 +0200, Alexander Graf wrote: > On 01.07.14 17:35, Scott Wood wrote: > > On Tue, 2014-07-01 at 17:04 +0200, Alexander Graf wrote: > >> On 01.07.14 16:58, Scott Wood wrote: > >>> On Tue, 2014-07-01 at 08:23 +0200, Alexander Graf wrote: >

Re: [PATCH 2/2] KVM : powerpc/booke: Allow debug interrupt injection to guest

2014-07-01 Thread Scott Wood
On Tue, 2014-07-01 at 17:04 +0200, Alexander Graf wrote: > On 01.07.14 16:58, Scott Wood wrote: > > On Tue, 2014-07-01 at 08:23 +0200, Alexander Graf wrote: > >> I don't think QEMU should be aware of these limitations. > > OK, but we should at least have some i

Re: [PATCH 2/2] KVM : powerpc/booke: Allow debug interrupt injection to guest

2014-07-01 Thread Scott Wood
On Tue, 2014-07-01 at 08:23 +0200, Alexander Graf wrote: > > > Am 30.06.2014 um 22:25 schrieb Scott Wood : > > > >> On Sun, 2014-06-29 at 23:38 -0500, Bhushan Bharat-R65777 wrote: > >> > >>> -Original Message- > >>> From: Woo

Re: [PATCH 2/2] KVM : powerpc/booke: Allow debug interrupt injection to guest

2014-06-30 Thread Scott Wood
On Sun, 2014-06-29 at 23:38 -0500, Bhushan Bharat-R65777 wrote: > > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Friday, June 27, 2014 11:53 PM > > To: Bhushan Bharat-R65777 > > Cc: ag...@suse.de; kvm-...@vger.kernel.org; kvm@vger.kernel.org > > Subject: Re: [PATCH 2/2] KVM :

Re: [PATCH] KVM: PPC: e500: Emulate power management control SPR

2014-06-30 Thread Scott Wood
On Mon, 2014-06-30 at 15:55 +0300, Mihai Caraman wrote: > For FSL e6500 core the kernel uses power management SPR register (PWRMGTCR0) > to enable idle power down for cores and devices by setting up the idle count > period at boot time. With the host already controlling the power management > confi

Re: [PATCH] KVM: PPC: e500: Fix default tlb for victim hint

2014-06-30 Thread Scott Wood
irq_save(flags); > mtspr(SPRN_MAS6, 0); > + mas4 = mfspr(SPRN_MAS4); > + mtspr(SPRN_MAS4, mas4 & ~MAS4_TLBSEL_MASK); > asm volatile("tlbsx 0, %0" : : "b" (eaddr & ~CONFIG_PAGE_OFFSET)); > mas0 = mfspr(SPRN_MAS0); > + mtspr(SPRN_MAS4,

Re: [PATCH 2/2] KVM : powerpc/booke: Allow debug interrupt injection to guest

2014-06-27 Thread Scott Wood
On Fri, 2014-06-27 at 11:55 +0530, Bharat Bhushan wrote: > This patch allow userspace to inject debug interrupt to guest. > > Signed-off-by: Bharat Bhushan Could you describe how userspace plans to make use of this, and go into more detail about the changes you're making? > --- > arch/powerpc/

Re: [PATCH 00/33] KVM: PPC: Fix IRQ race in magic page code

2014-06-24 Thread Scott Wood
On Wed, 2014-06-25 at 01:40 +0200, Alexander Graf wrote: > On 25.06.14 01:15, Scott Wood wrote: > > On Wed, 2014-06-25 at 00:41 +0200, Alexander Graf wrote: > >> On 24.06.14 20:53, Scott Wood wrote: > >>> The timer interrupt works, but I'm not fully convinced th

Re: [PATCH 00/33] KVM: PPC: Fix IRQ race in magic page code

2014-06-24 Thread Scott Wood
On Wed, 2014-06-25 at 00:41 +0200, Alexander Graf wrote: > On 24.06.14 20:53, Scott Wood wrote: > > On Sun, 2014-06-22 at 23:23 +0200, Alexander Graf wrote: > >> Howdy, > >> > >> Ben reminded me a while back that we have a nasty race in our KVM PV code. > >

Re: [PATCH 00/33] KVM: PPC: Fix IRQ race in magic page code

2014-06-24 Thread Scott Wood
On Sun, 2014-06-22 at 23:23 +0200, Alexander Graf wrote: > Howdy, > > Ben reminded me a while back that we have a nasty race in our KVM PV code. > > We replace a few instructions with longer streams of instructions to check > whether it's necessary to trap out from it (like mtmsr, no need to trap

Re: [PATCH v4] KVM: PPC: e500mc: Enhance tlb invalidation condition on vcpu schedule

2014-06-18 Thread Scott Wood
lt; ENTRIES; j++) > bar = foo[j][0]; > > return 0; > } > > Signed-off-by: Mihai Caraman > Cc: Scott Wood > --- > v4: > - rename last_vcpu_on_cpu to last_vcpu_of_lpid > - use "*[" syntax despite checkpatch error > &g

Re: [PATCH v3] KVM: PPC: e500mc: Enhance tlb invalidation condition on vcpu schedule

2014-06-17 Thread Scott Wood
On Tue, 2014-06-17 at 15:02 -0500, Caraman Mihai Claudiu-B02008 wrote: > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Tuesday, June 17, 2014 10:48 PM > > To: Caraman Mihai Claudiu-B02008 > > Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org; linuxppc- > > d...@lists.ozlabs.org

Re: [PATCH v3] KVM: PPC: e500mc: Enhance tlb invalidation condition on vcpu schedule

2014-06-17 Thread Scott Wood
On Tue, 2014-06-17 at 14:42 -0500, Caraman Mihai Claudiu-B02008 wrote: > > > -static DEFINE_PER_CPU(struct kvm_vcpu *, last_vcpu_on_cpu); > > > +static DEFINE_PER_CPU(struct kvm_vcpu * [KVMPPC_NR_LPIDS], > > last_vcpu_on_cpu); > > > > Hmm, I didn't know you could express types like that. Is this

Re: [PATCH v3] KVM: PPC: e500mc: Enhance tlb invalidation condition on vcpu schedule

2014-06-17 Thread Scott Wood
= 0; j < ENTRIES; j++) > bar = foo[j][0]; > > return 0; > } > > Signed-off-by: Mihai Caraman > Cc: Scott Wood > --- > v3: > - use existing logic while keeping last_vcpu_per_cpu per lpid > > v2: > - improve patch name and desc

Re: [PATCH v2] KVM: PPC: e500mc: Enhance tlb invalidation condition on vcpu schedule

2014-06-17 Thread Scott Wood
On Tue, 2014-06-17 at 14:04 -0500, Caraman Mihai Claudiu-B02008 wrote: > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Tuesday, June 17, 2014 6:36 PM > > To: Caraman Mihai Claudiu-B02008 > > Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org; linuxppc- > > d...@lists.ozlabs.org >

Re: [PATCH] KVM: PPC: e500mc: Relax tlb invalidation condition on vcpu schedule

2014-06-17 Thread Scott Wood
On Thu, 2014-06-12 at 19:04 +0200, Alexander Graf wrote: > On 06/12/2014 04:00 PM, Mihai Caraman wrote: > > @@ -140,12 +142,24 @@ static void kvmppc_core_vcpu_load_e500mc(struct > > kvm_vcpu *vcpu, int cpu) > > mtspr(SPRN_GDEAR, vcpu->arch.shared->dar); > > mtspr(SPRN_GESR, vcpu->arch.shar

Re: [PATCH v2] KVM: PPC: e500mc: Enhance tlb invalidation condition on vcpu schedule

2014-06-17 Thread Scott Wood
On Tue, 2014-06-17 at 12:02 +0300, Mihai Caraman wrote: > On vcpu schedule, the condition checked for tlb pollution is too loose. > The tlb entries of a vcpu become polluted (vs stale) only when a different > vcpu within the same logical partition runs in-between. Optimize the tlb > invalidation co

Re: [PATCH 4/4 v3] KVM: PPC: Bookehv: Get vcpu's last instruction for emulation

2014-06-13 Thread Scott Wood
On Thu, 2014-06-12 at 18:04 +0200, Alexander Graf wrote: > On 06/02/2014 05:50 PM, Mihai Caraman wrote: > > On book3e, KVM uses load external pid (lwepx) dedicated instruction to read > > guest last instruction on the exit path. lwepx exceptions (DTLB_MISS, DSI > > and LRAT), generated by loading a

Re: [PATCH] KVM: PPC: e500mc: Relax tlb invalidation condition on vcpu schedule

2014-06-13 Thread Scott Wood
On Fri, 2014-06-13 at 16:55 +0200, Alexander Graf wrote: > On 13.06.14 16:43, mihai.cara...@freescale.com wrote: > >> -Original Message- > >> From: Alexander Graf [mailto:ag...@suse.de] > >> Sent: Thursday, June 12, 2014 8:05 PM > >> To: Caraman Mihai Claudiu-B02008 > >> Cc: kvm-...@vger.ke

Re: [PATCH v2 4/4] KVM: PPC: Bookehv: Get vcpu's last instruction for emulation

2014-05-02 Thread Scott Wood
On Fri, 2014-05-02 at 13:10 +0200, Alexander Graf wrote: > On 05/02/2014 12:12 PM, David Laight wrote: > > You also probably want the page mapped uncached - no point polluting the > > data > > cache. We can't do that without creating an architecturally illegal alias between cacheable and non-cach

Re: [PATCH 4/4] KVM: PPC: Bookehv: Get vcpu's last instruction for emulation

2014-04-01 Thread Scott Wood
On Tue, 2014-04-01 at 07:47 +0200, Alexander Graf wrote: > > > Am 01.04.2014 um 01:03 schrieb Scott Wood : > > > >> On Mon, 2014-03-31 at 15:41 +0200, Alexander Graf wrote: > >>> On 03/26/2014 10:17 PM, Scott Wood wrote: > >>>> On

Re: [PATCH 4/4] KVM: PPC: Bookehv: Get vcpu's last instruction for emulation

2014-03-31 Thread Scott Wood
On Mon, 2014-03-31 at 15:41 +0200, Alexander Graf wrote: > On 03/26/2014 10:17 PM, Scott Wood wrote: > > On Thu, 2014-02-20 at 18:30 +0200, Mihai Caraman wrote: > >> + /* > >> + * Another thread may rewrite the TLB entry in parallel, don't > >> +

Re: [PATCH 4/4] KVM: PPC: Bookehv: Get vcpu's last instruction for emulation

2014-03-26 Thread Scott Wood
On Thu, 2014-02-20 at 18:30 +0200, Mihai Caraman wrote: > Load external pid (lwepx) instruction faults (when called from > KVM with guest context) needs to be handled by KVM. This implies > additional code in DO_KVM macro to identify the source of the > exception (which oiginate from KVM host rathe

Re: [PATCH 3/4] KVM: PPC: Alow kvmppc_get_last_inst() to fail

2014-03-26 Thread Scott Wood
On Thu, 2014-02-20 at 18:30 +0200, Mihai Caraman wrote: > diff --git a/arch/powerpc/kvm/book3s_paired_singles.c > b/arch/powerpc/kvm/book3s_paired_singles.c > index a59a25a..80c533e 100644 > --- a/arch/powerpc/kvm/book3s_paired_singles.c > +++ b/arch/powerpc/kvm/book3s_paired_singles.c > @@ -640,1

Re: [PATCH 0/8] PPC Book 3S HV-mode KVM updates for 3.15

2014-03-24 Thread Scott Wood
memslots() in real > [PATCH 7/8] KVM: PPC: Book3S HV: Fix decrementer timeouts with > [PATCH 8/8] KVM: PPC: Book3S HV: Save/restore host PMU registers that Acked-by: Scott Wood -Scott -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] Fixes for HV KVM on PPC for 3.14

2014-03-13 Thread Scott Wood
roblems for other architectures or other PPC platforms. > > The patches are against the master branch of the kvm tree but should > apply equally on Linus' current master branch. > > Scott, please ack. > > Paolo, I meant to get these out earlier, but a personal emerg

Re: [RFC PATCH v4 06/10] VFIO_PLATFORM: Read and write support for the device fd

2014-02-10 Thread Scott Wood
On Mon, 2014-02-10 at 15:45 -0700, Alex Williamson wrote: > On Sat, 2014-02-08 at 18:29 +0100, Antonios Motakis wrote: > > VFIO returns a file descriptor which we can use to manipulate the memory > > regions of the device. Since some memory regions we cannot mmap due to > > security concerns, we al

Re: [PATCH v2] KVM: Specify byte order for KVM_EXIT_MMIO

2014-01-27 Thread Scott Wood
On Sat, 2014-01-25 at 03:15 +0100, Alexander Graf wrote: > Ok, let's go through the combinations for a 32-bit write of 0x01020304 on PPC > and what data[] looks like > > your proposal: > > BE guest, BE host: { 0x01, 0x02, 0x03, 0x04 } > LE guest, BE host: { 0x04, 0x03, 0x02, 0x01 } > BE gu

Re: [PATCH v2] KVM: Specify byte order for KVM_EXIT_MMIO

2014-01-24 Thread Scott Wood
On Fri, 2014-01-24 at 17:56 -0800, Christoffer Dall wrote: > On Sat, Jan 25, 2014 at 12:24:08AM +, Peter Maydell wrote: > > Finally, I think it's a bit confusing in that "as if the guest had > > accessed memory" is assigning implicit semantics to memory > > in the emulated system, when memory i

Re: [PATCH v2] KVM: Specify byte order for KVM_EXIT_MMIO

2014-01-24 Thread Scott Wood
On Sat, 2014-01-25 at 00:24 +, Peter Maydell wrote: > On 24 January 2014 23:51, Scott Wood wrote: > > On Fri, 2014-01-24 at 15:39 -0800, Christoffer Dall wrote: > >> diff --git a/Documentation/virtual/kvm/api.txt > >> b/Documentation/virtual/kvm/api.txt > &g

Re: [PATCH v2] KVM: Specify byte order for KVM_EXIT_MMIO

2014-01-24 Thread Scott Wood
On Fri, 2014-01-24 at 15:39 -0800, Christoffer Dall wrote: > The KVM API documentation is not clear about the semantics of the data > field on the mmio struct on the kvm_run struct. > > This has become problematic when supporting ARM guests on big-endian > host systems with guests of both endianne

[PATCH v2] kvm/ppc: IRQ disabling cleanup

2014-01-09 Thread Scott Wood
caller do it. Also move the IRQ enabling on heavyweight exit into kvmppc_prepare_to_enter(). Signed-off-by: Scott Wood --- v2: - rebased - removed redundant (on 64-bit) and possibly performance-affecting WARNs - addressed cosmetic feedback arch/powerpc/include/asm/kvm_ppc.h | 6 ++ arch

[PATCH] kvm: Provide kvm_vcpu_eligible_for_directed_yield() stub

2014-01-09 Thread Scott Wood
Commit 7940876e1330671708186ac3386aa521ffb5c182 ("kvm: make local functions static") broke KVM PPC builds due to removing (rather than moving) the stub version of kvm_vcpu_eligible_for_directed_yield(). This patch reintroduces it. Signed-off-by: Scott Wood Cc: Stephen Hemminger Cc:

Re: [PATCH 2/3] kvm/ppc: IRQ disabling cleanup

2014-01-02 Thread Scott Wood
On Sun, 2013-12-29 at 16:43 +0100, Alexander Graf wrote: > On 11.07.2013, at 00:47, Scott Wood wrote: > > diff --git a/arch/powerpc/kvm/book3s_pr.c b/arch/powerpc/kvm/book3s_pr.c > > index ddfaf56..c13caa0 100644 > > --- a/arch/powerpc/kvm/book3s_pr.c > > +++ b/a

Re: [REPOST][PATCH 2/2] driver core: platform: allow platform drivers to bind to any device

2013-12-19 Thread Scott Wood
On Thu, 2013-12-19 at 12:44 -0800, Greg Kroah-Hartman wrote: > On Thu, Dec 19, 2013 at 02:29:21PM -0600, Scott Wood wrote: > > On Wed, 2013-12-18 at 17:03 -0800, Greg Kroah-Hartman wrote: > > > On Tue, Dec 03, 2013 at 12:34:54PM +, Kim Phillips wrote: > > >

Re: [REPOST][PATCH 1/2] driver core: Add new device_driver flag to allow binding via sysfs only

2013-12-19 Thread Scott Wood
On Thu, 2013-12-19 at 13:43 -0800, Greg Kroah-Hartman wrote: > On Thu, Dec 19, 2013 at 09:06:21PM +, Stuart Yoder wrote: > > > > > > > -Original Message- > > > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > > > Sent: Thursday, December 19, 2013 2:34 PM > > > To: Wood S

Re: [REPOST][PATCH 2/2] driver core: platform: allow platform drivers to bind to any device

2013-12-19 Thread Scott Wood
On Wed, 2013-12-18 at 17:03 -0800, Greg Kroah-Hartman wrote: > On Tue, Dec 03, 2013 at 12:34:54PM +, Kim Phillips wrote: > > Platform drivers such as the vfio-platform "meta-" driver [1] > > should be allowed to specify that they can bind to any device, > > much like PCI drivers can with PCI_AN

Re: [REPOST][PATCH 1/2] driver core: Add new device_driver flag to allow binding via sysfs only

2013-12-19 Thread Scott Wood
On Wed, 2013-12-18 at 17:07 -0800, Greg Kroah-Hartman wrote: > On Tue, Dec 03, 2013 at 12:34:46PM +, Kim Phillips wrote: > > VFIO supports pass-through of devices to user space - for sake > > of illustration, say a PCI e1000 device: > > > > - the e1000 is first unbound from the PCI e1000 drive

Re: [1/3] powerpc/vfio: Enable on POWERNV platform

2013-12-13 Thread Scott Wood
On Fri, 2013-12-13 at 14:02 +1100, Alexey Kardashevskiy wrote: > On 12/13/2013 10:35 AM, Scott Wood wrote: > > On Tue, May 21, 2013 at 01:33:09PM +1000, Alexey Kardashevskiy wrote: > >> +static int iommu_add_device(struct device *dev) > >> +{ > >> + struct i

Re: [1/3] powerpc/vfio: Enable on POWERNV platform

2013-12-12 Thread Scott Wood
On Tue, May 21, 2013 at 01:33:09PM +1000, Alexey Kardashevskiy wrote: > +static int iommu_add_device(struct device *dev) > +{ > + struct iommu_table *tbl; > + int ret = 0; > + > + if (WARN_ON(dev->iommu_group)) { > + pr_warn("iommu_tce: device %s is already in iommu group %d

Re: [PATCH] powerpc/kvm/booke: Fix build break due to stack frame size warning

2013-12-10 Thread Scott Wood
On Tue, 2013-12-10 at 03:05 +0100, Alexander Graf wrote: > On 09.12.2013, at 22:18, Scott Wood wrote: > > > On Mon, 2013-11-25 at 04:26 -0600, Bharat Bhushan wrote: > >> > >>> -Original Message- > >>> From: Wood Scott-B07421 > >&g

Re: [REPOST][PATCH 1/2] driver core: Add new device_driver flag to allow binding via sysfs only

2013-12-09 Thread Scott Wood
On Mon, 2013-12-09 at 20:12 +0100, Jan Kiszka wrote: > On 2013-12-09 19:58, Kim Phillips wrote: > > On Thu, 5 Dec 2013 16:38:15 -0600 > > Scott Wood wrote: > > > >> What would combining them solve, other than making it more likely that > >> Greg complains

Re: [PATCH] powerpc/kvm/booke: Fix build break due to stack frame size warning

2013-12-09 Thread Scott Wood
warnings being treated as errors > > arch/powerpc/kvm/booke.c: In function 'kvmppc_vcpu_run': > > arch/powerpc/kvm/booke.c:760:1: error: the frame size of 1424 bytes is > > larger > > than 1024 bytes > > make[2]: *** [arch/powerpc/kvm/booke.o] Error 1

Re: [REPOST][PATCH 1/2] driver core: Add new device_driver flag to allow binding via sysfs only

2013-12-05 Thread Scott Wood
On Thu, 2013-12-05 at 17:45 +, Kim Phillips wrote: > On Tue, 03 Dec 2013 16:34:33 +0100 > Jan Kiszka wrote: > > > On 2013-12-03 13:34, Kim Phillips wrote: > > > VFIO supports pass-through of devices to user space - for sake > > > of illustration, say a PCI e1000 device: > > > > > > - the e10

[PATCH] powerpc/kvm/booke: Fix build break due to stack frame size warning

2013-11-22 Thread Scott Wood
ke.o] Error 1 make[1]: *** [arch/powerpc/kvm] Error 2 make[1]: *** Waiting for unfinished jobs Signed-off-by: Scott Wood Cc: Bharat Bhushan --- Build tested only. Bharat, please test. arch/powerpc/include/asm/switch_to.h | 2 +- arch/powerpc/kernel/process.c| 32 --

Re: [v5][PATCH] KVM: PPC: Book3E HV: call RECONCILE_IRQ_STATE to sync the software state

2013-11-19 Thread Scott Wood
On Tue, 2013-11-19 at 10:51 +0100, Alexander Graf wrote: > > Am 19.11.2013 um 00:49 schrieb Scott Wood : > > > On Mon, 2013-11-18 at 16:09 -0500, Alexander Graf wrote: > >> On 18.11.2013, at 03:34, “tiejun.chen” wrote: > >> > >>> On 10/23/2013 09:2

Re: [v5][PATCH] KVM: PPC: Book3E HV: call RECONCILE_IRQ_STATE to sync the software state

2013-11-18 Thread Scott Wood
On Mon, 2013-11-18 at 16:09 -0500, Alexander Graf wrote: > On 18.11.2013, at 03:34, “tiejun.chen” wrote: > > > On 10/23/2013 09:26 AM, Tiejun Chen wrote: > >> We enter with interrupts disabled in hardware, but we need to > >> call RECONCILE_IRQ_STATE anyway to ensure that the software state > >>

Re: [PATCH 0/4 v3] kvm: powerpc: use cache attributes from linux pte

2013-11-18 Thread Scott Wood
v_rm_mmu.c |8 +++-- > arch/powerpc/kvm/booke.c|1 + > arch/powerpc/kvm/e500.h |8 +++-- > arch/powerpc/kvm/e500_mmu_host.c| 55 +++++++--- > 6 files changed, 64 insertions(+), 31 deletions(-) Reviewed-by: Scott Wood wit

Re: [PATCH 4/4 v3] kvm: powerpc: use caching attributes as per linux pte

2013-11-15 Thread Scott Wood
On Fri, 2013-11-15 at 11:01 +0530, Bharat Bhushan wrote: > @@ -440,9 +437,9 @@ static inline int kvmppc_e500_shadow_map(struct > kvmppc_vcpu_e500 *vcpu_e500, > } > > if (likely(!pfnmap)) { > - unsigned long tsize_pages = 1 << (tsize + 10 - PAGE_SHIFT); > + tsi

Re: [PATCH 3/4 v2] kvm: powerpc: define a linux pte lookup function

2013-11-06 Thread Scott Wood
On Mon, 2013-10-28 at 15:52 +0530, Bharat Bhushan wrote: > We need to search linux "pte" to get "pte" attributes for > setting TLB in KVM. > This patch defines a linux_pte_lookup() function for same. > > Signed-off-by: Bharat Bhushan > --- > v1->v2 > -- removed _PAGE_BUSY and _PAGE_PRESENT as su

Re: [PULL 34/51] powerpc: move debug registers in a structure

2013-11-03 Thread Scott Wood
On Mon, 2013-11-04 at 07:56 +1100, Benjamin Herrenschmidt wrote: > On Sun, 2013-11-03 at 16:30 +0200, Gleb Natapov wrote: > > On Thu, Oct 31, 2013 at 10:18:19PM +0100, Alexander Graf wrote: > > > From: Bharat Bhushan > > > > > > This way we can use same data type struct with KVM and > > > also he

Re: [PATCH 3/4] VFIO: pci: amend vfio-pci for explicit binding via sysfs only

2013-10-28 Thread Scott Wood
On Mon, 2013-10-28 at 23:45 -0500, Bhushan Bharat-R65777 wrote: > > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Tuesday, October 29, 2013 10:05 AM > > To: Bhushan Bharat-R65777 > > Cc: Wood Scott-B07421; Alex Williamson; Kim Phillips; Yoder Stuart-B08248; > > christoffer.d..

  1   2   3   4   5   6   7   8   >