Re: kvm: irqchip: fix memory leak in -stable

2015-11-05 Thread Greg KH
On Wed, Nov 04, 2015 at 02:11:54PM +0100, William Dauchy wrote: > Hello stable release team, > > The commit ba60c41 kvm: irqchip: fix memory leak > is fixing commit e73f61e kvm: irqchip: Break up high order allocations of > kvm_irq_routing_table > > I believe commit ba60c41 kvm: irqchip: fix mem

Re: [request for stable inclusion][Patch 3.4.y] x86, kvm: use kernel_fpu_begin/end() in kvm_load/put_guest_fpu()

2015-07-30 Thread Greg KH
On Fri, Jul 31, 2015 at 11:03:48AM +0800, Rui Xiang wrote: > ping > > On 2015/7/29 19:03, Rui Xiang wrote: 2 days ago? For a very old and slowly updated kernel release? Hah, be happy if you get a response in a month... -- To unsubscribe from this list: send the line "unsubscribe kvm" in th

Re: [PATCH] MIPS: KVM: do not sign extend on unsigned MMIO load

2015-06-19 Thread Greg KH
On Mon, Jun 08, 2015 at 09:33:50AM +0100, James Hogan wrote: > Hi stable folk, > > On 08/05/15 15:16, James Hogan wrote: > > On 07/05/15 13:47, Nicholas Mc Guire wrote: > >> Fix possible unintended sign extension in unsigned MMIO loads by casting > >> to uint16_t in the case of mmio_needed != 2. >

Re: [PATCH] KVM: VMX: Preserve host CR4.MCE value while in guest mode.

2015-04-17 Thread Greg KH
On Thu, Apr 16, 2015 at 11:58:05AM -0700, Ben Serebrin wrote: > The host's decision to enable machine check exceptions should remain > in force during non-root mode. KVM was writing 0 to cr4 on VCPU reset > and passed a slightly-modified 0 to the vmcs.guest_cr4 value. > > Tested: Built. > On earl

Re: [PATCH for stable] x86/spinlocks/paravirt: Fix memory corruption on unlock

2015-02-24 Thread Greg KH
On Tue, Feb 24, 2015 at 11:49:13PM +0530, Raghavendra K T wrote: > On 02/24/2015 08:17 PM, Ingo Molnar wrote: > > > >* Greg KH wrote: > > > >>On Tue, Feb 24, 2015 at 02:54:59PM +0530, Raghavendra K T wrote: > >>>Paravirt spinlock clears slowpath flag afte

Re: [PATCH for stable] x86/spinlocks/paravirt: Fix memory corruption on unlock

2015-02-24 Thread Greg KH
On Tue, Feb 24, 2015 at 03:47:37PM +0100, Ingo Molnar wrote: > > * Greg KH wrote: > > > On Tue, Feb 24, 2015 at 02:54:59PM +0530, Raghavendra K T wrote: > > > Paravirt spinlock clears slowpath flag after doing unlock. > > > As explained by Linus currently it

Re: [PATCH for stable] x86/spinlocks/paravirt: Fix memory corruption on unlock

2015-02-24 Thread Greg KH
On Tue, Feb 24, 2015 at 02:54:59PM +0530, Raghavendra K T wrote: > Paravirt spinlock clears slowpath flag after doing unlock. > As explained by Linus currently it does: > prev = *lock; > add_smp(&lock->tickets.head, TICKET_LOCK_INC); > > /* add_smp()

Re: [PATCH 1/9] x86: export get_xsave_addr

2014-12-04 Thread Greg KH
On Thu, Dec 04, 2014 at 04:57:06PM +0100, Paolo Bonzini wrote: > get_xsave_addr is the API to access XSAVE states, and KVM would > like to use it. Export it. Use it in what way? > Cc: sta...@vger.kernel.org Why is this a stable patch? -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH] driver core: platform: add device binding path 'driver_override'

2014-07-08 Thread Greg KH
On Mon, Jun 02, 2014 at 07:42:58PM -0500, Kim Phillips wrote: > Needed by platform device drivers, such as the upcoming > vfio-platform driver, in order to bypass the existing OF, ACPI, > id_table and name string matches, and successfully be able to be > bound to any device, like so: > > echo vfio

Re: [PATCH] driver core: platform: add device binding path 'driver_override'

2014-06-02 Thread Greg KH
On Mon, Jun 02, 2014 at 07:42:58PM -0500, Kim Phillips wrote: > Needed by platform device drivers, such as the upcoming > vfio-platform driver, in order to bypass the existing OF, ACPI, > id_table and name string matches, and successfully be able to be > bound to any device, like so: > > echo vfio

Re: [PATCH v3] PCI: Introduce new device binding path using pci_dev.driver_override

2014-05-28 Thread Greg KH
On Tue, May 27, 2014 at 09:07:42PM -0600, Bjorn Helgaas wrote: > On Tue, May 20, 2014 at 08:53:21AM -0600, Alex Williamson wrote: > > The driver_override field allows us to specify the driver for a device > > rather than relying on the driver to provide a positive match of the > > device. This sho

Re: [PATCH v3] PCI: Introduce new device binding path using pci_dev.driver_override

2014-05-27 Thread Greg KH
On Tue, May 27, 2014 at 09:07:42PM -0600, Bjorn Helgaas wrote: > On Tue, May 20, 2014 at 08:53:21AM -0600, Alex Williamson wrote: > > The driver_override field allows us to specify the driver for a device > > rather than relying on the driver to provide a positive match of the > > device. This sho

Re: [PATCH] virtio-scsi: Skip setting affinity on uninitialized vq

2014-04-11 Thread Greg KH
On Fri, Apr 11, 2014 at 03:23:45PM +0800, Fam Zheng wrote: > virtscsi_init calls virtscsi_remove_vqs on err, even before initializing > the vqs. The latter calls virtscsi_set_affinity, so let's check the > pointer there before setting affinity on it. > > This fixes a panic when setting device's nu

Re: [RFC PATCH] PCI: Introduce new device binding path using pci_dev.driver_override

2014-04-01 Thread Greg KH
On Tue, Apr 01, 2014 at 06:52:12PM -0500, Kim Phillips wrote: > On Tue, 01 Apr 2014 10:28:54 -0600 > Alex Williamson wrote: > > > The driver_override field allows us to specify the driver for a device > > rather than relying on the driver to provide a positive match of the > > device. This short

Re: [RFC PATCH] PCI: Introduce new device binding path using pci_dev.driver_override

2014-04-01 Thread Greg KH
On Tue, Apr 01, 2014 at 10:28:54AM -0600, Alex Williamson wrote: > The driver_override field allows us to specify the driver for a device > rather than relying on the driver to provide a positive match of the > device. This shortcuts the existing process of looking up the vendor > and device ID, a

Re: [RFC PATCH v4 01/10] driver core: export driver_probe_device()

2014-02-14 Thread Greg KH
On Sat, Feb 08, 2014 at 06:29:31PM +0100, Antonios Motakis wrote: > From: Kim Phillips > > Needed by drivers, such as the vfio platform driver [1], seeking to > bypass bind_store()'s driver_match_device(), and bind to any device > via a private sysfs bind file. > > [1] https://lkml.org/lkml/2013

Re: [PATCH] KVM: SVM: fix NMI window after iret

2014-01-17 Thread Greg KH
On Fri, Jan 17, 2014 at 08:52:42PM +0100, Radim Krčmář wrote: > We should open NMI window right after an iret, but SVM exits before it. > We wanted to single step using the trap flag and then open it. > (or we could emulate the iret instead) > We don't do it since commit 3842d135ff2 (likely), becau

Re: [PATCH backport hints for <3.10] KVM: x86: Convert vapic synchronization to _cached functions (CVE-2013-6368)

2013-12-18 Thread Greg KH
On Mon, Dec 16, 2013 at 12:38:17PM +0100, Paolo Bonzini wrote: > The KVM patch "fix vapic memory corruption" applies to most kernels that > have KVM, but the fix does not apply on many older branches. The APIs it > uses are available in 3.1, but until 3.9 kvm_gfn_to_hva_cache_init had > one fewer

Re: [PATCH backport hints for <3.10] KVM: x86: Convert vapic synchronization to _cached functions (CVE-2013-6368)

2013-12-16 Thread Greg KH
On Mon, Dec 16, 2013 at 12:38:17PM +0100, Paolo Bonzini wrote: > The KVM patch "fix vapic memory corruption" applies to most kernels that > have KVM, but the fix does not apply on many older branches. The APIs it > uses are available in 3.1, but until 3.9 kvm_gfn_to_hva_cache_init had > one fewer

Re: [PATCH 3.12-rc7] KVM: Fix modprobe failure for kvm_intel/kvm_amd

2013-10-30 Thread Greg KH
On Wed, Oct 30, 2013 at 05:08:09PM +0100, Paolo Bonzini wrote: > Il 30/10/2013 16:59, Greg KH ha scritto: > >> > Even if it is okay to exit and not create the files (and I think it's a > >> > bit surprising), I'd like at least a printk to signal what's

Re: [PATCH 3.12-rc7] KVM: Fix modprobe failure for kvm_intel/kvm_amd

2013-10-30 Thread Greg KH
On Wed, Oct 30, 2013 at 04:46:28PM +0100, Paolo Bonzini wrote: > Il 30/10/2013 16:39, Raghavendra K T ha scritto: > >> > >> Why even error out at all here? You should never care about debugfs > >> file creation return values, so why pass any error back up the stack? > > > > We could change this t

Re: [PATCH 3.12-rc7] KVM: Fix modprobe failure for kvm_intel/kvm_amd

2013-10-30 Thread Greg KH
On Wed, Oct 30, 2013 at 07:31:05PM +0530, Raghavendra K T wrote: > On 10/30/2013 01:03 AM, Linus Torvalds wrote: > > On Tue, Oct 29, 2013 at 12:27 PM, Raghavendra K T > > wrote: > >> > >> Could one solution be cascading actual error > >> that is lost in fs/debugfs/inode.c:__create_file(), so that

Re: [PATCH 3.12-rc7] KVM: Fix modprobe failure for kvm_intel/kvm_amd

2013-10-29 Thread Greg KH
On Wed, Oct 30, 2013 at 12:57:32AM +0530, Raghavendra K T wrote: > Adding Greg/AI too since we touch debugfs code. You do? > [...] > >> > >>sudo modprobe kvm_amd > >>modprobe: ERROR: could not insert 'kvm_amd': Bad address > > > >"Bad address"? Christ people, are you guys making up error numbers

Re: [PATCH] intel-iommu: Fix leaks in pagetable freeing

2013-10-05 Thread Greg KH
On Wed, Oct 02, 2013 at 10:44:31AM +0200, Borislav Petkov wrote: > On Sat, Jun 15, 2013 at 10:27:19AM -0600, Alex Williamson wrote: > > At best the current code only seems to free the leaf pagetables and > > the root. If you're unlucky enough to have a large gap (like any > > QEMU guest with more

Re: [stable-3.4] possibly revert "KVM: X86 emulator: fix source operand decoding..."

2013-09-12 Thread Greg KH
On Tue, Sep 10, 2013 at 01:05:21PM +0200, Paolo Bonzini wrote: > Il 04/09/2013 18:44, Paul Gortmaker ha scritto: > > Hi Greg, > > > > The 3.4.44+ cherry pick: > > > > > > commit 5b5b30580218eae22609989546bac6e44d0eda6e > > Author: Gleb Natapov > > Date: Wed Apr 24 13:3

Re: [PATCHSET] kthread_worker: reimplement flush_kthread_work() to allow freeing during execution

2012-09-27 Thread Greg KH
On Mon, Sep 17, 2012 at 01:28:50PM -0700, Greg KH wrote: > On Mon, Sep 17, 2012 at 12:40:16PM -0700, Tejun Heo wrote: > > On Fri, Sep 14, 2012 at 03:50:40PM -0700, Colin Cross wrote: > > > This patch set fixes a reproducible crash I'm seeing on a 3.4.10 > > > kern

Re: [PATCHSET] kthread_worker: reimplement flush_kthread_work() to allow freeing during execution

2012-09-17 Thread Greg KH
On Mon, Sep 17, 2012 at 12:40:16PM -0700, Tejun Heo wrote: > On Fri, Sep 14, 2012 at 03:50:40PM -0700, Colin Cross wrote: > > This patch set fixes a reproducible crash I'm seeing on a 3.4.10 > > kernel. flush_kthread_worker (which is different from > > flush_kthread_work) is initializing a kthread

Re: linux-next: manual merge of the staging tree with the target-merge tree

2012-07-23 Thread Greg KH
On Sun, Jul 22, 2012 at 02:44:23PM -0700, Nicholas A. Bellinger wrote: > So Linus has merged target-pending/for-next this afternoon, so now we > are just waiting on net-next to hit mainline with the vhost patches > already ACK'ed by MST. Hopefully that makes things easier for you to > considering

Re: [PATCH v4 3/3] Documentation: Add ABI entry for vmcs sysfs interface

2012-07-04 Thread Greg KH
On Wed, Jul 04, 2012 at 06:06:28PM +0800, Yanfei Zhang wrote: > Signed-off-by: zhangyanfei > --- > Documentation/ABI/testing/sysfs-devices-system-cpu | 21 > > 1 files changed, 21 insertions(+), 0 deletions(-) > > diff --git a/Documentation/ABI/testing/sysfs-devices-syste

Re: [PATCH v4 2/3] KVM-INTEL: Add new module vmcsinfo-intel to fill VMCSINFO

2012-07-04 Thread Greg KH
On Wed, Jul 04, 2012 at 06:05:19PM +0800, Yanfei Zhang wrote: > +int vmcs_sysfs_add(struct device *dev) > +{ > + return sysfs_create_group(&dev->kobj, &vmcs_attr_group); > +} > + > +void vmcs_sysfs_remove(struct device *dev) > +{ > + sysfs_remove_group(&dev->kobj, &vmcs_attr_group); > +} W

Re: [PATCH v4 3/3] Documentation: Add ABI entry for vmcs sysfs interface

2012-07-04 Thread Greg KH
On Wed, Jul 04, 2012 at 06:06:28PM +0800, Yanfei Zhang wrote: > Signed-off-by: zhangyanfei > --- > Documentation/ABI/testing/sysfs-devices-system-cpu | 21 > > 1 files changed, 21 insertions(+), 0 deletions(-) > > diff --git a/Documentation/ABI/testing/sysfs-devices-syste

Re: [PATCH v3 4/5] Sysfs: Export VMCSINFO via sysfs

2012-06-28 Thread Greg KH
On Thu, Jun 28, 2012 at 04:37:38AM -0700, Greg KH wrote: > On Thu, Jun 28, 2012 at 05:54:30PM +0800, Yanfei Zhang wrote: > > 于 2012年06月28日 03:22, Greg KH 写道: > > > On Wed, Jun 27, 2012 at 04:54:54PM +0800, Yanfei Zhang wrote: > > >> This patch export offsets of fi

Re: [PATCH v3 4/5] Sysfs: Export VMCSINFO via sysfs

2012-06-28 Thread Greg KH
On Thu, Jun 28, 2012 at 05:54:30PM +0800, Yanfei Zhang wrote: > 于 2012年06月28日 03:22, Greg KH 写道: > > On Wed, Jun 27, 2012 at 04:54:54PM +0800, Yanfei Zhang wrote: > >> This patch export offsets of fields via /sys/devices/cpu/vmcs/. > >> Individual offsets are contain

Re: [PATCH v3 4/5] Sysfs: Export VMCSINFO via sysfs

2012-06-27 Thread Greg KH
On Wed, Jun 27, 2012 at 04:54:54PM +0800, Yanfei Zhang wrote: > This patch export offsets of fields via /sys/devices/cpu/vmcs/. > Individual offsets are contained in subfiles named by the filed's > encoding, e.g.: /sys/devices/cpu/vmcs/0800 > > Signed-off-by: zhangyanfei > --- > drivers/base/cor

Re: [PATCH 01/13] driver core: Add iommu_group tracking to struct device

2012-05-11 Thread Greg KH
On Fri, May 11, 2012 at 05:58:01PM -0600, Alex Williamson wrote: > On Fri, 2012-05-11 at 16:38 -0700, Greg KH wrote: > > On Fri, May 11, 2012 at 04:55:35PM -0600, Alex Williamson wrote: > > > IOMMU groups allow IOMMU drivers to represent DMA visibility > > > and isol

Re: [PATCH 02/13] iommu: IOMMU Groups

2012-05-11 Thread Greg KH
On Fri, May 11, 2012 at 04:55:41PM -0600, Alex Williamson wrote: > IOMMU device groups are currently a rather vague associative notion > with assembly required by the user or user level driver provider to > do anything useful. This patch intends to grow the IOMMU group concept > into something a b

Re: [PATCH 01/13] driver core: Add iommu_group tracking to struct device

2012-05-11 Thread Greg KH
On Fri, May 11, 2012 at 04:55:35PM -0600, Alex Williamson wrote: > IOMMU groups allow IOMMU drivers to represent DMA visibility > and isolation of devices. Multiple devices may be grouped > together for the purposes of DMA. Placing a pointer on > struct device enable easy access for things like s

Re: [PATCH 00/11] KVM fixes for 3.3.5

2012-05-10 Thread Greg KH
On Wed, May 09, 2012 at 04:10:36PM +0300, Avi Kivity wrote: > After a long hiatus, here are a bunch of very delayed fixes for 3.3.5. All applied, thanks. greg k-h -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 3/4] ksysfs: export VMCSINFO via sysfs

2012-04-16 Thread Greg KH
On Tue, Apr 17, 2012 at 09:52:42AM +0800, zhangyanfei wrote: > 于 2012年04月13日 07:00, Greg KH 写道: > > On Wed, Apr 11, 2012 at 09:57:34AM +0800, zhangyanfei wrote: > >> This patch creates sysfs file to export where VMCSINFO is allocated, > >> as below: > >>

Re: [PATCH 3/4] ksysfs: export VMCSINFO via sysfs

2012-04-12 Thread Greg KH
On Wed, Apr 11, 2012 at 09:57:34AM +0800, zhangyanfei wrote: > This patch creates sysfs file to export where VMCSINFO is allocated, > as below: > $ cat /sys/kernel/vmcsinfo > 1cb88a0 2000 > number on the left-hand side is the physical address of VMCSINFO, > while the one on the righ

Re: [PATCH v2 0/2] kvm: iommu unmap fixes

2012-04-11 Thread Greg KH
On Wed, Apr 11, 2012 at 09:51:43AM -0600, Alex Williamson wrote: > This is a documentation change only from the previous version. > After discussing it, there is a potential page leak as noted > in the updated changelog for the first patch. Thanks, This is not the correct way to submit patches

Re: [Xen-devel] [PATCH RFC V5 1/6] debugfs: Add support to print u32 array in debugfs

2012-03-30 Thread Greg KH
On Fri, Mar 30, 2012 at 04:49:12PM -0400, Konrad Rzeszutek Wilk wrote: > On Fri, Mar 23, 2012 at 01:36:28PM +0530, Raghavendra K T wrote: > > From: Srivatsa Vaddagiri > > > > Move the code from Xen to debugfs to make the code common > > for other users as well. > > > > Signed-off-by: Srivatsa Va

Re: [v3.0.y 1/2] KVM: x86: extend "struct x86_emulate_ops" with "get_cpuid"

2012-03-23 Thread Greg KH
On Fri, Mar 23, 2012 at 06:47:38PM +0100, Stefan Bader wrote: > On 23.03.2012 18:22, Greg KH wrote: > > On Thu, Mar 22, 2012 at 09:50:43AM +0100, Stefan Bader wrote: > >>> From eaee58e1433e1b16e686cfcdcbc207d4310a239f Mon Sep 17 00:00:00 2001 > >> From: =?

Re: [v3.0.y 1/2] KVM: x86: extend "struct x86_emulate_ops" with "get_cpuid"

2012-03-23 Thread Greg KH
On Thu, Mar 22, 2012 at 09:50:43AM +0100, Stefan Bader wrote: > >From eaee58e1433e1b16e686cfcdcbc207d4310a239f Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Stephan=20B=C3=A4rwolf?= > Date: Thu, 12 Jan 2012 16:43:03 +0100 > Subject: [PATCH 7/8] KVM: x86: extend "struct x86_emulate_ops" with > "get_c

Re: CVE-2012-0045 for 3.2.y, 3.0.y and 2.6.32.y (again)

2012-03-22 Thread Greg KH
On Thu, Mar 22, 2012 at 09:50:40AM +0100, Stefan Bader wrote: > Resubmitting with more of the proper maintainers > subscribed (note that Marcelo is one of them)... Again, for the others on the cc:, I can't take these in the stable tree(s) until I get an ack from the maintainers of the code. Espec

Re: [PATCH 1/1 v3] PCI: Device specific reset function

2012-03-05 Thread Greg KH
On Mon, Mar 05, 2012 at 10:00:49AM +, Tadeusz Struk wrote: > > --- > drivers/pci/pci.h|1 + > drivers/pci/quirks.c | 33 +++-- > include/linux/pci.h |1 + > 3 files changed, 29 insertions(+), 6 deletions(-) Please read Documentation/SubmittingPatche

[16/48] KVM: x86: Prevent starting PIT timers in the absence of irqchip support

2012-01-16 Thread Greg KH
3.1-stable review patch. If anyone has any objections, please let me know. -- From: Jan Kiszka (cherry picked from commit 0924ab2cfa98b1ece26c033d696651fd62896c69) User space may create the PIT and forgets about setting up the irqchips. In that case, firing PIT IRQs will cras

[15/48] KVM guest: prevent tracing recursion with kvmclock

2012-01-16 Thread Greg KH
3.1-stable review patch. If anyone has any objections, please let me know. -- From: Avi Kivity (cherry picked from commit 95ef1e52922cf75b1ea2eae54ef886f2cc47eecb) Prevent tracing of preempt_disable() in get_cpu_var() in kvm_clock_read(). When CONFIG_DEBUG_PREEMPT is enabled,

[17/48] KVM: Remove ability to assign a device without iommu support

2012-01-16 Thread Greg KH
3.1-stable review patch. If anyone has any objections, please let me know. -- From: Alex Williamson (cherry picked from commit 423873736b78f549fbfa2f715f2e4de7e6c5e1e9) This option has no users and it exposes a security hole that we can allow devices to be assigned without io

[18/48] KVM: Device assignment permission checks

2012-01-16 Thread Greg KH
3.1-stable review patch. If anyone has any objections, please let me know. -- From: Alex Williamson (cherry picked from commit 3d27e23b17010c668db311140b1770c78fb9) Only allow KVM device assignment to attach to devices which: - Are not bridges - Have BAR resources (ass

Re: [PATCH 0/4] KVM updates for Linux 3.1.8

2012-01-12 Thread Greg KH
On Thu, Jan 12, 2012 at 06:25:43PM +0200, Avi Kivity wrote: > On 01/12/2012 06:15 PM, Greg KH wrote: > > On Thu, Jan 12, 2012 at 12:39:50PM +0200, Avi Kivity wrote: > > > The following patches want to be applied to the 3.1 branch. "All users > > > must > > &

Re: [PATCH 0/4] KVM updates for Linux 3.1.8

2012-01-12 Thread Greg KH
On Thu, Jan 12, 2012 at 12:39:50PM +0200, Avi Kivity wrote: > The following patches want to be applied to the 3.1 branch. "All users must > update". Do any of these also need to go to the 3.0 branch? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body

Re: [PATCH RFC V2 2/5] debugfs: Renaming of xen functions and change unsigned to u32

2011-10-24 Thread Greg KH
On Mon, Oct 24, 2011 at 02:58:47PM +0530, Raghavendra K T wrote: > On 10/24/2011 03:49 AM, Greg KH wrote: > >On Mon, Oct 24, 2011 at 12:34:59AM +0530, Raghavendra K T wrote: > >>Renaming of xen functions and change unsigned to u32. > > > >Why not just rename when yo

Re: [PATCH RFC V2 2/5] debugfs: Renaming of xen functions and change unsigned to u32

2011-10-23 Thread Greg KH
On Mon, Oct 24, 2011 at 12:34:59AM +0530, Raghavendra K T wrote: > Renaming of xen functions and change unsigned to u32. Why not just rename when you move the functions? Why the extra step? greg k-h -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to maj

Re: [PATCH RFC V2 1/5] debugfs: Add support to print u32 array in debugfs

2011-10-23 Thread Greg KH
On Mon, Oct 24, 2011 at 12:34:04AM +0530, Raghavendra K T wrote: > Add debugfs support to print u32-arrays in debugfs. Move the code from Xen to > debugfs > to make the code common for other users as well. You forgot the kerneldoc for the function explaining what it is and how to use it, and the

Re: [PATCH 02/10] Driver core: Add iommu_ops to bus_type

2011-09-13 Thread Greg KH
On Tue, Sep 13, 2011 at 05:38:11PM +0200, Roedel, Joerg wrote: > On Tue, Sep 13, 2011 at 10:58:55AM -0400, Greg KH wrote: > > On Tue, Sep 13, 2011 at 04:54:02PM +0200, Roedel, Joerg wrote: > > > --- a/include/linux/device.h > > > +++ b/include/linux/device.h > > &g

Re: [PATCH 02/10] Driver core: Add iommu_ops to bus_type

2011-09-13 Thread Greg KH
On Tue, Sep 13, 2011 at 04:54:02PM +0200, Roedel, Joerg wrote: > --- a/include/linux/device.h > +++ b/include/linux/device.h > @@ -22,6 +22,7 @@ > #include > #include > #include > +#include Ick, please don't add new #includes to device.h, it makes the whole build slower. Just pre-declare t

Re: [PATCH 02/10] Driver core: Add iommu_ops to bus_type

2011-09-07 Thread Greg KH
ing? > On Wed, Sep 07, 2011 at 11:47:50AM -0700, Greg KH wrote: > > > +#ifdef CONFIG_IOMMU_API > > > +int bus_set_iommu(struct bus_type *bus, struct iommu_ops *ops) > > > +{ > > > + if (bus->iommu_ops != NULL) > > > + return -EBUSY; >

Re: [PATCH 0/10] IOMMU: Make iommu_ops per-bus_type

2011-09-07 Thread Greg KH
On Wed, Sep 07, 2011 at 05:41:43PM +0200, Joerg Roedel wrote: > Hi, > > here is the new version of the patch-set to make the iommu_ops used in > the iommu-api a bus_type property. This will allow us to move code out > of the iommu drivers into generic code and it simplifies the > implementation of

Re: [PATCH 02/10] Driver core: Add iommu_ops to bus_type

2011-09-07 Thread Greg KH
On Wed, Sep 07, 2011 at 05:41:45PM +0200, Joerg Roedel wrote: > This is the starting point to make the iommu_ops used for > the iommu-api a per-bus-type structure. It is required to > easily implement bus-specific setup in the iommu-layer. > The first user will be the iommu-group attribute in sysfs

Re: [PATCH v2] staging: zcache: support multiple clients, prep for KVM and RAMster

2011-07-05 Thread Greg KH
On Fri, Jul 01, 2011 at 07:58:45PM +0300, Dan Carpenter wrote: > On Fri, Jul 01, 2011 at 07:31:54AM -0700, Dan Magenheimer wrote: > > > Off by one errors are kind of insidious. People cut and paste them > > > and they spread. If someone adds a new list of chunks then there > > > are now two examp

Re: [PATCH v2] staging: zcache: support multiple clients, prep for KVM and RAMster

2011-06-30 Thread Greg KH
On Thu, Jun 30, 2011 at 12:01:08PM -0700, Dan Magenheimer wrote: > Hi Greg -- > > I think this patch is now ready for staging-next and for merging when > the 3.1 window opens. Please let me know if you need any logistics > done differently. Ok, thanks, I'll queue it up later this week for 3.1 g

Re: [PATCH 1/1] [virt] virtio-blk: Use ida to allocate disk index

2011-06-08 Thread Greg KH
On Thu, Jun 09, 2011 at 08:51:05AM +0930, Rusty Russell wrote: > On Wed, 08 Jun 2011 09:08:29 -0400, Mark Wu wrote: > > Hi Rusty, > > Yes, I can't figure out an instance of disk probing in parallel either, but > > as > > per the following commit, I think we still need use lock for safety. What's

Re: [stable] [PATCH] kvm: fix crash on irqfd deassign

2011-03-17 Thread Greg KH
On Thu, Mar 17, 2011 at 10:53:33AM +0200, Michael S. Tsirkin wrote: > irqfd in kvm used flush_work incorrectly: > it assumed that work scheduled previously can't run > after flush_work, but since kvm uses a non-reentrant > workqueue (by means of schedule_work) > we need flush_work_sync to get that

Re: [PATCH V3] VFIO driver: Non-privileged user level PCI drivers

2010-07-20 Thread Greg KH
On Sat, Jul 17, 2010 at 10:45:23AM +0200, Piotr Jaroszy??ski wrote: > On 16 July 2010 23:58, Tom Lyon wrote: > > The VFIO "driver" is used to allow privileged AND non-privileged processes > > to > > implement user-level device drivers for any well-behaved PCI, PCI-X, and > > PCIe > > devices. >

Re: [PATCH V2] VFIO driver: Non-privileged user level PCI drivers

2010-06-10 Thread Greg KH
On Thu, Jun 10, 2010 at 06:58:37PM -0700, Tom Lyon wrote: > On Thursday 10 June 2010 10:27:36 am Konrad Rzeszutek Wilk wrote: > > > +EXPORT_SYMBOL(uiommu_fdget); > > > > EXPORT_SYMBOL_GPL > > .. snip > > > +EXPORT_SYMBOL(uiommu_put); > > > > ditto. > > > > Is there a definitive explanation some

Re: [PATCH V2] VFIO driver: Non-privileged user level PCI drivers

2010-06-09 Thread Greg KH
On Wed, Jun 09, 2010 at 02:04:53PM +0300, Avi Kivity wrote: > On 06/09/2010 12:21 AM, Tom Lyon wrote: > >The VFIO "driver" is used to allow privileged AND non-privileged processes to > >implement user-level device drivers for any well-behaved PCI, PCI-X, and PCIe > >devices. > > Signed-off-by:

Re: [stable] [PATCH 3/3][STABLE] KVM: add schedule check to napi_enable call

2010-06-03 Thread Greg KH
On Thu, Jun 03, 2010 at 04:17:34PM -0600, Bruce Rogers wrote: > >>> On 6/3/2010 at 03:03 PM, Greg KH wrote: > > On Thu, Jun 03, 2010 at 01:38:31PM -0600, Bruce Rogers wrote: > >> virtio_net: Add schedule check to napi_enable call > >> Under harsh test

Re: [stable] [PATCH 3/3][STABLE] KVM: add schedule check to napi_enable call

2010-06-03 Thread Greg KH
On Thu, Jun 03, 2010 at 01:38:31PM -0600, Bruce Rogers wrote: > virtio_net: Add schedule check to napi_enable call > Under harsh testing conditions, including low memory, the guest would > stop receiving packets. With this patch applied we no longer see any > problems in the driver

Re: [stable] [PATCH 2/3][STABLE] KVM: indicate oom if add_buf fails

2010-06-03 Thread Greg KH
On Thu, Jun 03, 2010 at 01:36:20PM -0600, Bruce Rogers wrote: > This patch is a subset of an already upstream patch, but this portion is > useful in earlier releases. > Please consider for stable. WHat is the git commit id of the upstream patch? I need that for all stable patches to be accepted,

Re: [PATCH 2/2] pci: allow sysfs file owner to read device dependent config space

2010-05-14 Thread Greg KH
On Wed, May 12, 2010 at 06:29:57PM -0700, Chris Wright wrote: > The PCI config space bin_attr read handler has a hardcoded CAP_SYS_ADMIN > check to verify privileges before allowing a user to read device > dependent config space. This is meant to protect from an unprivileged > user potentially loc

Re: [PATCH 2/2 v2] pci: check caps from sysfs file open to read device dependent config space

2010-05-13 Thread Greg KH
On Thu, May 13, 2010 at 10:43:07AM -0700, Chris Wright wrote: > * Alan Cox (a...@lxorguk.ukuu.org.uk) wrote: > > I agree with the problem - but IMHO the fix is to require opening the file > > checks CAP_SYS_something instead: not to hack the read method and make it > > even weirder and more un-Linu

Re: 2.6.33.3: possible recursive locking detected

2010-05-12 Thread Greg KH
On Wed, May 12, 2010 at 12:34:20PM +0800, Américo Wang wrote: > On Tue, May 11, 2010 at 08:03:20AM -0700, Greg KH wrote: > >On Tue, May 11, 2010 at 09:33:50PM +1000, CaT wrote: > >> On Wed, May 05, 2010 at 10:52:50AM +0800, Américo Wang wrote: > >> > On Wed, May 5

Re: [RFC PATCH] sysfs: bin_attr permission checking

2010-05-12 Thread Greg KH
On Wed, May 12, 2010 at 12:28:28PM -0700, Chris Wright wrote: > * Greg KH (g...@kroah.com) wrote: > > On Wed, May 12, 2010 at 11:47:13AM -0700, Chris Wright wrote: > > > The PCI config space bin_attr read handler has a hardcoded CAP_SYS_ADMIN > > > check to verify privil

Re: [RFC PATCH] sysfs: bin_attr permission checking

2010-05-12 Thread Greg KH
On Wed, May 12, 2010 at 11:47:13AM -0700, Chris Wright wrote: > The PCI config space bin_attr read handler has a hardcoded CAP_SYS_ADMIN > check to verify privileges before allowing a user to read device > dependent config space. This is meant to protect from an unprivileged > user potentially loc

Re: 2.6.33.3: possible recursive locking detected

2010-05-11 Thread Greg KH
On Tue, May 11, 2010 at 09:33:50PM +1000, CaT wrote: > On Wed, May 05, 2010 at 10:52:50AM +0800, Américo Wang wrote: > > On Wed, May 5, 2010 at 10:32 AM, Yong Zhang > > wrote: > > > On Tue, May 04, 2010 at 11:37:37AM +0300, Avi Kivity wrote: > > >> On 05/04/2010 10:03 AM, CaT wrote: > > >> >I'm c

[69/98] KVM: remove unused load_segment_descriptor_to_kvm_desct

2010-05-10 Thread Greg KH
2.6.32-stable review patch. If anyone has any objections, please let us know. -- From: Marcelo Tosatti Commit 78ce64a384 in v2.6.32.12 introduced a warning due to unused load_segment_descriptor_to_kvm_desct helper, which has been opencoded by this commit. On upstream, the help

Re: [PATCH 2.6.32.12] KVM: remove unused load_segment_descriptor_to_kvm_desct

2010-04-27 Thread Greg KH
On Tue, Apr 27, 2010 at 01:16:49PM -0300, Marcelo Tosatti wrote: > On Tue, Apr 27, 2010 at 07:56:41AM -0700, Greg KH wrote: > > On Tue, Apr 27, 2010 at 05:52:20PM +0300, Gleb Natapov wrote: > > > On Tue, Apr 27, 2010 at 07:43:55AM -0700, Greg KH wrote: > > > > On T

Re: [PATCH 2.6.32.12] KVM: remove unused load_segment_descriptor_to_kvm_desct

2010-04-27 Thread Greg KH
On Tue, Apr 27, 2010 at 05:52:20PM +0300, Gleb Natapov wrote: > On Tue, Apr 27, 2010 at 07:43:55AM -0700, Greg KH wrote: > > On Tue, Apr 27, 2010 at 11:14:14AM -0300, Marcelo Tosatti wrote: > > > > > > Function is now unused. > > > > > > Signed-off

Re: [PATCH 2.6.32.12] KVM: remove unused load_segment_descriptor_to_kvm_desct

2010-04-27 Thread Greg KH
On Tue, Apr 27, 2010 at 11:14:14AM -0300, Marcelo Tosatti wrote: > > Function is now unused. > > Signed-off-by: Marcelo Tosatti Was this patch also upstream? Why does stable need it? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message t

Re: [PATCH] KVM: VMX: Disable unrestricted guest when EPT disabled

2010-04-07 Thread Greg KH
On Thu, Mar 18, 2010 at 02:11:19PM +0800, Sheng Yang wrote: > Otherwise would cause VMEntry failure when using ept=0 on unrestricted guest > supported processors. > > Signed-off-by: Sheng Yang Now included through a different submission. thanks, greg k-h -- To unsubscribe from this list: send

Re: [PATCH 0/1] uio_pci_generic: extensions to allow access for non-privileged processes

2010-04-02 Thread Greg KH
On Fri, Apr 02, 2010 at 09:43:35AM +0300, Avi Kivity wrote: > On 04/01/2010 10:24 PM, Tom Lyon wrote: >> >>> But there are multiple msi-x interrupts, how do you know which one >>> triggered? >>> >> You don't. This would suck for KVM, I guess, but we'd need major rework of >> the >> generic U

[027/116] hrtimer: Tune hrtimer_interrupt hang logic

2010-03-30 Thread Greg KH
2.6.32-stable review patch. If anyone has any objections, please let us know. -- From: Thomas Gleixner commit 41d2e494937715d3150e5c75d01f0e75ae899337 upstream. The hrtimer_interrupt hang logic adjusts min_delta_ns based on the execution time of the hrtimer callbacks. This is

[49/74] KVM: allow userspace to adjust kvmclock offset

2010-02-04 Thread Greg KH
2.6.32-stable review patch. If anyone has any objections, please let us know. -- From: Glauber Costa (cherry picked from afbcf7ab8d1bc8c2d04792f6d9e786e0adeb328d) When we migrate a kvm guest that uses pvclock between two hosts, we may suffer a large skew. This is because there

Re: kernel memory allocation bug in 2.6.27.32-2.6.27.41 kvm section

2010-01-05 Thread Greg KH
On Sun, Dec 27, 2009 at 12:13:00PM +0200, Avi Kivity wrote: > On 12/17/2009 05:35 PM, Oscon wrote: > > Hello! > > > > I can't register new account in bugzilla.kernel.org. / my ISP's spamfilter > > problem (?) maybe./ > > > > -------

Re: [PATCH RFC] pci: expose function reset capability in sysfs

2009-07-27 Thread Greg KH
On Mon, Jul 27, 2009 at 11:37:48PM +0300, Michael S. Tsirkin wrote: > On Mon, Jul 27, 2009 at 09:14:23AM -0700, Greg KH wrote: > > Fine with me. You forgot the documentation though :) > > This enough? > > pci: expose function reset capability in sysfs > > Some

Re: [PATCH RFC] pci: expose function reset capability in sysfs

2009-07-27 Thread Greg KH
On Mon, Jul 27, 2009 at 06:52:38PM +0300, Michael S. Tsirkin wrote: > On Mon, Jul 27, 2009 at 08:01:46AM -0700, Greg KH wrote: > > > + if (!pci_probe_reset_function(dev)) { > > > + retval = device_create_file(&dev->dev, &reset_attr); > > > +

Re: [PATCH RFC] pci: expose function reset capability in sysfs

2009-07-27 Thread Greg KH
On Sun, Jul 26, 2009 at 08:11:39PM +0300, Michael S. Tsirkin wrote: > Some devices allow an individual function to be reset without affecting > other functions in the same device: that's what pci_reset_function does. > For devices that have this support, expose reset attribite in sysfs. Please add

Re: [PATCHv5] uio: add generic driver for PCI 2.3 devices

2009-07-20 Thread Greg KH
On Mon, Jul 20, 2009 at 10:52:27PM +0300, Michael S. Tsirkin wrote: > On Mon, Jul 20, 2009 at 09:09:43PM +0200, Hans J. Koch wrote: > > On Mon, Jul 20, 2009 at 10:29:34AM +0300, Michael S. Tsirkin wrote: > > > This adds a generic uio driver that can bind to any PCI device. First > > > user will be

Re: [PATCHv4] uio: add generic driver for PCI 2.3 devices

2009-07-16 Thread Greg KH
On Thu, Jul 16, 2009 at 03:31:01PM +0300, Michael S. Tsirkin wrote: > On Wed, Jul 15, 2009 at 03:08:29PM -0700, Greg KH wrote: > > On Wed, Jul 15, 2009 at 11:13:40PM +0300, Michael S. Tsirkin wrote: > > > This adds a generic uio driver that can bind to any PCI device. First

Re: [PATCHv4] uio: add generic driver for PCI 2.3 devices

2009-07-16 Thread Greg KH
On Thu, Jul 16, 2009 at 08:03:46PM +0300, Michael S. Tsirkin wrote: > On Thu, Jul 16, 2009 at 08:52:08AM -0700, Greg KH wrote: > > On Thu, Jul 16, 2009 at 05:12:55PM +0200, Hans J. Koch wrote: > > > On Thu, Jul 16, 2009 at 05:07:10PM +0300, Michael S. Tsirkin wrote: > > >

Re: [PATCHv4] uio: add generic driver for PCI 2.3 devices

2009-07-16 Thread Greg KH
On Thu, Jul 16, 2009 at 05:12:55PM +0200, Hans J. Koch wrote: > On Thu, Jul 16, 2009 at 05:07:10PM +0300, Michael S. Tsirkin wrote: > > On Wed, Jul 15, 2009 at 03:08:29PM -0700, Greg KH wrote: > > > How about moving that documentation into a place that people will notice > >

Re: [PATCHv4] uio: add generic driver for PCI 2.3 devices

2009-07-15 Thread Greg KH
On Wed, Jul 15, 2009 at 11:13:40PM +0300, Michael S. Tsirkin wrote: > This adds a generic uio driver that can bind to any PCI device. First > user will be virtualization where a qemu userspace process needs to give > guest OS access to the device. > > Interrupts are handled using the Interrupt Di

Re: [RFC PATCH v2 09/19] net: Add vbus_enet driver

2009-04-09 Thread Greg KH
On Thu, Apr 09, 2009 at 09:37:10AM -0700, Stephen Hemminger wrote: > > +static int tx_ringlen = 256; > > +module_param(tx_ringlen, int, 0444); > > + > > +#undef PDEBUG /* undef it, just in case */ > > +#ifdef VBUS_ENET_DEBUG > > +# define PDEBUG(fmt, args...) printk(KERN_DEBUG "vbus_en

Re: [PATCH v10 4/7] PCI: add SR-IOV API for Physical Function driver

2009-03-10 Thread Greg KH
On Tue, Mar 10, 2009 at 09:37:53AM +0800, Yu Zhao wrote: > On Tue, Mar 10, 2009 at 03:39:01AM +0800, Greg KH wrote: > > On Mon, Mar 09, 2009 at 04:25:05PM +0800, Yu Zhao wrote: > > > > > + pci_device_add(virtfn, virtfn->bus); > > > > > > > >

Re: [PATCH v10 1/7] PCI: initialize and release SR-IOV capability

2009-03-10 Thread Greg KH
On Tue, Mar 10, 2009 at 09:19:44AM +0800, Yu Zhao wrote: > On Sat, Mar 07, 2009 at 10:38:45AM +0800, Greg KH wrote: > > On Fri, Mar 06, 2009 at 01:08:10PM -0700, Matthew Wilcox wrote: > > > On Fri, Feb 20, 2009 at 02:54:42PM +0800, Yu Zhao wrote: > > > > + list_

Re: [PATCH v10 4/7] PCI: add SR-IOV API for Physical Function driver

2009-03-09 Thread Greg KH
On Mon, Mar 09, 2009 at 04:25:05PM +0800, Yu Zhao wrote: > > > + pci_device_add(virtfn, virtfn->bus); > > > > Greg is probably going to ding you here for adding the device, then > > creating the symlinks. I believe it's now best practice to create the > > symlinks first, so there's no window wher

Re: [PATCH v10 0/7] PCI: Linux kernel SR-IOV support

2009-03-08 Thread Greg KH
On Sun, Mar 08, 2009 at 09:01:09AM -0600, Matthew Wilcox wrote: > On Sun, Mar 08, 2009 at 04:30:16PM +0200, Avi Kivity wrote: > > Matthew Wilcox wrote: > > >On Tue, Feb 24, 2009 at 12:47:38PM +0200, Avi Kivity wrote: > > >>Do those patches allow using a VF on the host (in other words, does the > >

Re: [PATCH v10 4/7] PCI: add SR-IOV API for Physical Function driver

2009-03-06 Thread Greg KH
On Fri, Mar 06, 2009 at 01:37:18PM -0700, Matthew Wilcox wrote: > On Fri, Feb 20, 2009 at 02:54:45PM +0800, Yu Zhao wrote: > > + virtfn->sysdata = dev->bus->sysdata; > > + virtfn->dev.parent = dev->dev.parent; > > + virtfn->dev.bus = dev->dev.bus; > > + virtfn->devfn = devfn; > > + virtfn

Re: [PATCH v10 0/7] PCI: Linux kernel SR-IOV support

2009-03-06 Thread Greg KH
On Fri, Mar 06, 2009 at 12:44:11PM -0700, Matthew Wilcox wrote: > > Physical Function driver patches for Intel 82576 NIC are available: > > http://patchwork.kernel.org/patch/8063/ > > http://patchwork.kernel.org/patch/8064/ > > http://patchwork.kernel.org/patch/8065/ > > http://patchwork.ke

  1   2   >