Re: KVM: x86: fix pvclock guest stopped flag reporting (v2)

2012-08-07 Thread Eric B Munson
On 2012-08-03 14:57, Marcelo Tosatti wrote: kvm_guest_time_update unconditionally clears hv_clock.flags field, so the notification never reaches the guest. Fix it by allowing PVCLOCK_GUEST_STOPPED to passthrough. Signed-off-by: Marcelo Tosatti Reviewed-by: Eric B Munson -- To unsubscribe

Re: WARNING: at arch/x86/kernel/kvmclock.c:127

2012-06-11 Thread Eric B Munson
On Mon, 11 Jun 2012 19:07:19 -0300, Marcelo Tosatti wrote: On Mon, Jun 11, 2012 at 05:47:00PM -0400, Eric B Munson wrote: On Sun, 10 Jun 2012 17:47:24 +0200, Sedat Dilek wrote: >Hi, > >I see the same warning especially when resuming from a suspend (see >timestamps >=30-35sec) bet

Re: WARNING: at arch/x86/kernel/kvmclock.c:127

2012-06-11 Thread Eric B Munson
On Sun, 10 Jun 2012 17:47:24 +0200, Sedat Dilek wrote: Hi, I see the same warning especially when resuming from a suspend (see timestamps >=30-35sec) between Linux v3.5-rc1..v3.5-rc2. $ sudo grep kvmclock.c /var/log/kern.log Jun 4 21:11:32 fambox kernel: [ 784.037237] WARNING: at arch/x86/ker

Re: WARNING: at arch/x86/kernel/kvmclock.c:127

2012-06-06 Thread Eric B Munson
On Wed, 06 Jun 2012 11:52:23 -0400, Eric B Munson wrote: On Tue, 5 Jun 2012 20:20:59 +0200, Frank Arnold wrote: Hi all, I observed the following warning during testing of 3.5-rc1, involving some intensive and random CPU online state toggling through sysfs. It only shows up about 1 out of

Re: WARNING: at arch/x86/kernel/kvmclock.c:127

2012-06-06 Thread Eric B Munson
[] system_call_fastpath+0x16/0x1b ---[ end trace 574db9e069f4f35e ]--- This is a regression introduced by the following commit: commit 3b5d56b9317fa7b5407dff1aa7b115bf6cdbd494 Author: Eric B Munson Date: Sat Mar 10 14:37:26 2012 -0500 kvmclock: Add functions to check if the host has stopped the vm When a

[PATCH] Remove unneeded EXPORT macro

2012-03-15 Thread Eric B Munson
check_and_clear_guest_paused does not need to be exported as it isn't used by any modules, remove the export. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: jan.kis...@siemens.com Cc: a...@redhat.com Cc

Re: [PATCH 2/4 V16] Add functions to check if the host has stopped the vm

2012-03-15 Thread Eric B Munson
On Wed, 14 Mar 2012 11:12:35 +0100, Jan Kiszka wrote: On 2012-03-10 20:37, Eric B Munson wrote: When a host stops or suspends a VM it will set a flag to show this. The watchdog will use these functions to determine if a softlockup is real, or the result of a suspended VM. ... diff --git

Re: [PATCH 2/4 V16] Add functions to check if the host has stopped the vm

2012-03-15 Thread Eric B Munson
On Wed, 14 Mar 2012 11:12:35 +0100, Jan Kiszka wrote: On 2012-03-10 20:37, Eric B Munson wrote: When a host stops or suspends a VM it will set a flag to show this. The watchdog will use these functions to determine if a softlockup is real, or the result of a suspended VM. ... diff --git

Re: [PATCH 0/4 V13] Avoid soft lockup message when KVM is stopped by host

2012-03-10 Thread Eric B Munson
On Mon, 05 Mar 2012, Marcelo Tosatti wrote: > On Tue, Feb 14, 2012 at 04:17:20PM -0500, Eric B Munson wrote: > > On Tue, 14 Feb 2012, Marcelo Tosatti wrote: > > > > > On Tue, Feb 14, 2012 at 10:50:13AM -0500, Eric B Munson wrote: > > > > On Tue

[PATCH 4/4 V16] Add check for suspended vm in softlockup detector

2012-03-10 Thread Eric B Munson
A suspended VM can cause spurious soft lockup warnings. To avoid these, the watchdog now checks if the kernel knows it was stopped by the host and skips the warning if so. When the watchdog is reset successfully, clear the guest paused flag. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc

[PATCH 2/4 V16] Add functions to check if the host has stopped the vm

2012-03-10 Thread Eric B Munson
When a host stops or suspends a VM it will set a flag to show this. The watchdog will use these functions to determine if a softlockup is real, or the result of a suspended VM. Signed-off-by: Eric B Munson asm-generic changes Acked-by: Arnd Bergmann Cc: mi...@redhat.com Cc: h...@zytor.com Cc

[PATCH 3/4 V16] Add ioctl for KVM_KVMCLOCK_CTRL

2012-03-10 Thread Eric B Munson
Now that we have a flag that will tell the guest it was suspended, create an interface for that communication using a KVM ioctl. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc: kvm

[PATCH 1/4 V16] Add flag to indicate that a vm was stopped by the host

2012-03-10 Thread Eric B Munson
This flag will be used to check if the vm was stopped by the host when a soft lockup was detected. The host will set the flag when it stops the guest. On resume, the guest will check this flag if a soft lockup is detected and skip issuing the warning. Signed-off-by: Eric B Munson Cc: mi

[PATCH 0/4 V16] Avoid soft lockup message when KVM is stopped by host

2012-03-10 Thread Eric B Munson
running in order to keep the wall clock accurate. Cc: mi...@redhat.com Cc: h...@zytor.com Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc: kvm@vger.kernel.org Cc: linux-a...@vger.kernel.org Cc: x...@kernel.org Cc: linux-ker...@vger.kernel.org Eric B Munson (4): A

Re: [PATCH 0/4 V13] Avoid soft lockup message when KVM is stopped by host

2012-03-05 Thread Eric B Munson
On Mon, 5 Mar 2012 13:39:43 -0300, Marcelo Tosatti wrote: On Tue, Feb 14, 2012 at 04:17:20PM -0500, Eric B Munson wrote: On Tue, 14 Feb 2012, Marcelo Tosatti wrote: > On Tue, Feb 14, 2012 at 10:50:13AM -0500, Eric B Munson wrote: > > On Tue, 14 Feb 2012, Marcelo Tosatti wrote: > &g

Re: [PATCH 0/4 V15] Avoid soft lockup message when KVM is stopped by host

2012-03-02 Thread Eric B Munson
On Sun, 19 Feb 2012 21:22:53 -0500, Eric B Munson wrote: Changes from V14: Update documentation for the pvclock api ... snip When a guest kernel is stopped by the host hypervisor it can look like a soft lockup to the guest kernel. This false warning can mask later soft lockup warnings

[PATCH 3/4 V15] Add ioctl for KVM_KVMCLOCK_CTRL

2012-02-19 Thread Eric B Munson
Now that we have a flag that will tell the guest it was suspended, create an interface for that communication using a KVM ioctl. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc: kvm

[PATCH 4/4 V15] Add check for suspended vm in softlockup detector

2012-02-19 Thread Eric B Munson
A suspended VM can cause spurious soft lockup warnings. To avoid these, the watchdog now checks if the kernel knows it was stopped by the host and skips the warning if so. When the watchdog is reset successfully, clear the guest paused flag. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc

[PATCH 1/4 V15] Add flag to indicate that a vm was stopped by the host

2012-02-19 Thread Eric B Munson
This flag will be used to check if the vm was stopped by the host when a soft lockup was detected. The host will set the flag when it stops the guest. On resume, the guest will check this flag if a soft lockup is detected and skip issuing the warning. Signed-off-by: Eric B Munson Cc: mi

[PATCH 0/4 V15] Avoid soft lockup message when KVM is stopped by host

2012-02-19 Thread Eric B Munson
com Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc: kvm@vger.kernel.org Cc: linux-a...@vger.kernel.org Cc: x...@kernel.org Cc: linux-ker...@vger.kernel.org Eric B Munson (4): Add flag to indicate that a vm was stopped by the host Add functions to check if the host h

[PATCH 2/4 V15] Add functions to check if the host has stopped the vm

2012-02-19 Thread Eric B Munson
When a host stops or suspends a VM it will set a flag to show this. The watchdog will use these functions to determine if a softlockup is real, or the result of a suspended VM. Signed-off-by: Eric B Munson asm-generic changes Acked-by: Arnd Bergmann Cc: mi...@redhat.com Cc: h...@zytor.com Cc

Re: [PATCH 3/4 V13] Add ioctl for KVM_KVMCLOCK_CTRL

2012-02-16 Thread Eric B Munson
On Thu, 16 Feb 2012, Eric B Munson wrote: > Now that we have a flag that will tell the guest it was suspended, create an > interface for that communication using a KVM ioctl. > > Signed-off-by: Eric B Munson Sorry, this is actually V14. signature.asc Description: Digital signature

[PATCH 2/4 V14] Add functions to check if the host has stopped the vm

2012-02-16 Thread Eric B Munson
When a host stops or suspends a VM it will set a flag to show this. The watchdog will use these functions to determine if a softlockup is real, or the result of a suspended VM. Signed-off-by: Eric B Munson asm-generic changes Acked-by: Arnd Bergmann Cc: mi...@redhat.com Cc: h...@zytor.com Cc

[PATCH 4/4 V14] Add check for suspended vm in softlockup detector

2012-02-16 Thread Eric B Munson
A suspended VM can cause spurious soft lockup warnings. To avoid these, the watchdog now checks if the kernel knows it was stopped by the host and skips the warning if so. When the watchdog is reset successfully, clear the guest paused flag. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc

[PATCH 3/4 V13] Add ioctl for KVM_KVMCLOCK_CTRL

2012-02-16 Thread Eric B Munson
Now that we have a flag that will tell the guest it was suspended, create an interface for that communication using a KVM ioctl. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc: kvm

[PATCH 0/4 V14] Avoid soft lockup message when KVM is stopped by host

2012-02-16 Thread Eric B Munson
Cc: mtosa...@redhat.com Cc: kvm@vger.kernel.org Cc: linux-a...@vger.kernel.org Cc: x...@kernel.org Cc: linux-ker...@vger.kernel.org Eric B Munson (4): Add flag to indicate that a vm was stopped by the host Add functions to check if the host has stopped the vm Add ioctl for KVM_KVMCLOCK_CTRL Add

[PATCH 1/4 V14] Add flag to indicate that a vm was stopped by the host

2012-02-16 Thread Eric B Munson
This flag will be used to check if the vm was stopped by the host when a soft lockup was detected. The host will set the flag when it stops the guest. On resume, the guest will check this flag if a soft lockup is detected and skip issuing the warning. Signed-off-by: Eric B Munson Cc: mi

Re: [PATCH 0/4 V13] Avoid soft lockup message when KVM is stopped by host

2012-02-14 Thread Eric B Munson
On Tue, 14 Feb 2012, Marcelo Tosatti wrote: > On Tue, Feb 14, 2012 at 10:50:13AM -0500, Eric B Munson wrote: > > On Tue, 14 Feb 2012, Marcelo Tosatti wrote: > > > > > On Tue, Feb 14, 2012 at 10:29:31AM -0500, Eric B Munson wrote: > > > > On W

Re: [PATCH 0/4 V13] Avoid soft lockup message when KVM is stopped by host

2012-02-14 Thread Eric B Munson
On Tue, 14 Feb 2012, Marcelo Tosatti wrote: > On Tue, Feb 14, 2012 at 10:29:31AM -0500, Eric B Munson wrote: > > On Wed, 08 Feb 2012, Eric B Munson wrote: > > > > > > > > When a guest kernel is stopped by the host hypervisor it can look like a > > > so

Re: [PATCH 0/4 V13] Avoid soft lockup message when KVM is stopped by host

2012-02-14 Thread Eric B Munson
On Wed, 08 Feb 2012, Eric B Munson wrote: > > When a guest kernel is stopped by the host hypervisor it can look like a soft > lockup to the guest kernel. This false warning can mask later soft lockup > warnings which may be real. This patch series adds a method for a host >

[PATCH 3/4 V13] Add ioctl for KVM_KVMCLOCK_CTRL

2012-02-08 Thread Eric B Munson
Now that we have a flag that will tell the guest it was suspended, create an interface for that communication using a KVM ioctl. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc: kvm

[PATCH 4/4 V13] Add check for suspended vm in softlockup detector

2012-02-08 Thread Eric B Munson
A suspended VM can cause spurious soft lockup warnings. To avoid these, the watchdog now checks if the kernel knows it was stopped by the host and skips the warning if so. When the watchdog is reset successfully, clear the guest paused flag. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc

[PATCH 2/4 V13] Add functions to check if the host has stopped the vm

2012-02-08 Thread Eric B Munson
When a host stops or suspends a VM it will set a flag to show this. The watchdog will use these functions to determine if a softlockup is real, or the result of a suspended VM. Signed-off-by: Eric B Munson asm-generic changes Acked-by: Arnd Bergmann Cc: mi...@redhat.com Cc: h...@zytor.com Cc

[PATCH 0/4 V13] Avoid soft lockup message when KVM is stopped by host

2012-02-08 Thread Eric B Munson
.org Cc: x...@kernel.org Cc: linux-ker...@vger.kernel.org Eric B Munson (4): Add flag to indicate that a vm was stopped by the host Add functions to check if the host has stopped the vm Add ioctl for KVM_KVMCLOCK_CTRL Add check for suspended vm in softlockup detector Documentation/virtual/k

[PATCH 1/4 V13] Add flag to indicate that a vm was stopped by the host

2012-02-08 Thread Eric B Munson
This flag will be used to check if the vm was stopped by the host when a soft lockup was detected. The host will set the flag when it stops the guest. On resume, the guest will check this flag if a soft lockup is detected and skip issuing the warning. Signed-off-by: Eric B Munson Cc: mi

Re: [PATCH 0/4 V12] Avoid soft lockup message when KVM is stopped by host

2012-02-07 Thread Eric B Munson
I managed to miss the discussion from the V11 thread, I will work those comments in tomorrow and send V13 as soon as that is done. Eric -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kern

[PATCH 2/4 V12] Add functions to check if the host has stopped the vm

2012-02-07 Thread Eric B Munson
When a host stops or suspends a VM it will set a flag to show this. The watchdog will use these functions to determine if a softlockup is real, or the result of a suspended VM. Signed-off-by: Eric B Munson asm-generic changes Acked-by: Arnd Bergmann Cc: mi...@redhat.com Cc: h...@zytor.com Cc

[PATCH 4/4] Add check for suspended vm in softlockup detector

2012-02-07 Thread Eric B Munson
A suspended VM can cause spurious soft lockup warnings. To avoid these, the watchdog now checks if the kernel knows it was stopped by the host and skips the warning if so. When the watchdog is reset successfully, clear the guest paused flag. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc

[PATCH 0/4 V12] Avoid soft lockup message when KVM is stopped by host

2012-02-07 Thread Eric B Munson
e. Cc: mi...@redhat.com Cc: h...@zytor.com Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc: kvm@vger.kernel.org Cc: linux-a...@vger.kernel.org Cc: x...@kernel.org Cc: linux-ker...@vger.kernel.org Eric B Munson (4): Add flag to indicate that a vm was stopped by the

[PATCH 3/4 V12] Add ioctl for KVMCLOCK_GUEST_STOPPED

2012-02-07 Thread Eric B Munson
Now that we have a flag that will tell the guest it was suspended, create an interface for that communication using a KVM ioctl. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc: kvm

[PATCH 1/4 V12] Add flag to indicate that a vm was stopped by the host

2012-02-07 Thread Eric B Munson
This flag will be used to check if the vm was stopped by the host when a soft lockup was detected. The host will set the flag when it stops the guest. On resume, the guest will check this flag if a soft lockup is detected and skip issuing the warning. Signed-off-by: Eric B Munson Cc: mi

[PATCH 0/4 V11] Avoid soft lockup message when KVM is stopped by host

2012-01-31 Thread Eric B Munson
_GUEST was renamed to KVM_GUEST_PAUSED Cc: mi...@redhat.com Cc: h...@zytor.com Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc: kvm@vger.kernel.org Cc: linux-a...@vger.kernel.org Cc: x...@kernel.org Cc: linux-ker...@vger.kernel.org Eric B Munson (4): Add flag t

[PATCH 2/4 V11] Add functions to check if the host has stopped the vm

2012-01-31 Thread Eric B Munson
When a host stops or suspends a VM it will set a flag to show this. The watchdog will use these functions to determine if a softlockup is real, or the result of a suspended VM. Signed-off-by: Eric B Munson asm-generic changes Acked-by: Arnd Bergmann Cc: mi...@redhat.com Cc: h...@zytor.com Cc

[PATCH 4/4 V11] Add check for suspended vm in softlockup detector

2012-01-31 Thread Eric B Munson
A suspended VM can cause spurious soft lockup warnings. To avoid these, the watchdog now checks if the kernel knows it was stopped by the host and skips the warning if so. When the watchdog is reset successfully, clear the guest paused flag. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc

[PATCH 1/4 V11] Add flag to indicate that a vm was stopped by the host

2012-01-31 Thread Eric B Munson
This flag will be used to check if the vm was stopped by the host when a soft lockup was detected. The host will set the flag when it stops the guest. On resume, the guest will check this flag if a soft lockup is detected and skip issuing the warning. Signed-off-by: Eric B Munson Cc: mi

[PATCH 3/4 V11] Add ioctl for KVMCLOCK_GUEST_STOPPED

2012-01-31 Thread Eric B Munson
Now that we have a flag that will tell the guest it was suspended, create an interface for that communication using a KVM ioctl. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc: kvm

Re: [PATCH 3/4 V10] Add ioctl for KVMCLOCK_GUEST_STOPPED

2012-01-30 Thread Eric B Munson
On Mon, 30 Jan 2012, Avi Kivity wrote: > On 01/30/2012 05:32 PM, Eric B Munson wrote: > > > > > > Can you point me to the discussion that moved this to be a vm ioctl? In > > > general vm ioctls that do things for all vcpus are racy, like here. > > &

Re: [PATCH 3/4 V10] Add ioctl for KVMCLOCK_GUEST_STOPPED

2012-01-30 Thread Eric B Munson
On Mon, 30 Jan 2012, Avi Kivity wrote: > On 01/30/2012 05:07 PM, Avi Kivity wrote: > > > +Parameters: None > > > +Returns: 0 on success, -1 on error > > > + > > > +This signals to the host kernel that the specified guest is being paused > > > by > > > +userspace. The host will set a flag in the

Re: [PATCH 3/4 V10] Add ioctl for KVMCLOCK_GUEST_STOPPED

2012-01-30 Thread Eric B Munson
On Mon, 30 Jan 2012, Avi Kivity wrote: > On 01/17/2012 08:40 PM, Eric B Munson wrote: > > Now that we have a flag that will tell the guest it was suspended, create an > > interface for that communication using a KVM ioctl. > > > > > > diff --git a/Documen

Re: [PATCH V7] Guest stop notification

2012-01-27 Thread Eric B Munson
On Tue, 17 Jan 2012, Eric B Munson wrote: > Often when a guest is stopped from the qemu console, it will report spurious > soft lockup warnings on resume. There are kernel patches being discussed that > will give the host the ability to tell the guest that it is being stopped and > s

Re: [PATCH 0/4 V10] Avoid soft lockup message when KVM is stopped by host

2012-01-27 Thread Eric B Munson
On Tue, 17 Jan 2012, Eric B Munson wrote: > Changes from V9: > Use kvm_for_each_vcpu to iterate online vcpu's > > Changes from V8: > Make KVM_GUEST_PAUSED a per vm ioctl instead of per vcpu > > Changes from V7: > Define KVM_CAP_GUEST_PAUSED and support check &g

[PATCH 4/4 V10] Add check for suspended vm in softlockup detector

2012-01-17 Thread Eric B Munson
A suspended VM can cause spurious soft lockup warnings. To avoid these, the watchdog now checks if the kernel knows it was stopped by the host and skips the warning if so. When the watchdog is reset successfully, clear the guest paused flag. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc

[PATCH 1/4 V10] Add flag to indicate that a vm was stopped by the host

2012-01-17 Thread Eric B Munson
This flag will be used to check if the vm was stopped by the host when a soft lockup was detected. The host will set the flag when it stops the guest. On resume, the guest will check this flag if a soft lockup is detected and skip issuing the warning. Signed-off-by: Eric B Munson Cc: mi

[PATCH 2/4 V10] Add functions to check if the host has stopped the vm

2012-01-17 Thread Eric B Munson
When a host stops or suspends a VM it will set a flag to show this. The watchdog will use these functions to determine if a softlockup is real, or the result of a suspended VM. Signed-off-by: Eric B Munson asm-generic changes Acked-by: Arnd Bergmann Cc: mi...@redhat.com Cc: h...@zytor.com Cc

[PATCH 3/4 V10] Add ioctl for KVMCLOCK_GUEST_STOPPED

2012-01-17 Thread Eric B Munson
Now that we have a flag that will tell the guest it was suspended, create an interface for that communication using a KVM ioctl. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc: jeremy.fitzhardi

[PATCH V7] Guest stop notification

2012-01-17 Thread Eric B Munson
patch uses the qemu Notifier system to tell the guest it is about to be stopped. Signed-off-by: Eric B Munson Cc: Avi Kivity Cc: Marcelo Tosatti Cc: Jan Kiszka Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: kvm@vger.kernel.org --- Changes from V6: Remove unnecessary include Changes

[PATCH V6] Guest stop notification

2012-01-17 Thread Eric B Munson
patch uses the qemu Notifier system to tell the guest it is about to be stopped. Signed-off-by: Eric B Munson Cc: Avi Kivity Cc: Marcelo Tosatti Cc: Jan Kiszka Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: kvm@vger.kernel.org --- Changes from V5: KVM_GUEST_PAUSED is now a per vm ioctl

[PATCH 3/4 V9] Add ioctl for KVMCLOCK_GUEST_STOPPED

2012-01-17 Thread Eric B Munson
Now that we have a flag that will tell the guest it was suspended, create an interface for that communication using a KVM ioctl. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc: jeremy.fitzhardi

[PATCH 2/4 V9] Add functions to check if the host has stopped the vm

2012-01-17 Thread Eric B Munson
When a host stops or suspends a VM it will set a flag to show this. The watchdog will use these functions to determine if a softlockup is real, or the result of a suspended VM. Signed-off-by: Eric B Munson asm-generic changes Acked-by: Arnd Bergmann Cc: mi...@redhat.com Cc: h...@zytor.com Cc

[PATCH 4/4 V9] Add check for suspended vm in softlockup detector

2012-01-17 Thread Eric B Munson
A suspended VM can cause spurious soft lockup warnings. To avoid these, the watchdog now checks if the kernel knows it was stopped by the host and skips the warning if so. When the watchdog is reset successfully, clear the guest paused flag. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc

[PATCH 0/4 V9] Avoid soft lockup message when KVM is stopped by host

2012-01-17 Thread Eric B Munson
Cc: x...@kernel.org Cc: linux-ker...@vger.kernel.org Eric B Munson (4): Add flag to indicate that a vm was stopped by the host Add functions to check if the host has stopped the vm Add ioctl for KVMCLOCK_GUEST_STOPPED Add check for suspended vm in softlockup detector Documentation/virtua

[PATCH 1/4 V9] Add flag to indicate that a vm was stopped by the host

2012-01-17 Thread Eric B Munson
This flag will be used to check if the vm was stopped by the host when a soft lockup was detected. The host will set the flag when it stops the guest. On resume, the guest will check this flag if a soft lockup is detected and skip issuing the warning. Signed-off-by: Eric B Munson Cc: mi

[PATCH 3/4 V8] Add ioctl for KVMCLOCK_GUEST_STOPPED

2012-01-11 Thread Eric B Munson
Now that we have a flag that will tell the guest it was suspended, create an interface for that communication using a KVM ioctl. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc: jeremy.fitzhardi

[PATCH 4/4 V8] Add check for suspended vm in softlockup detector

2012-01-11 Thread Eric B Munson
A suspended VM can cause spurious soft lockup warnings. To avoid these, the watchdog now checks if the kernel knows it was stopped by the host and skips the warning if so. When the watchdog is reset successfully, clear the guest paused flag. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc

[PATCH V5] Guest stop notification

2012-01-11 Thread Eric B Munson
patch uses the qemu Notifier system to tell the guest it is about to be stopped. Signed-off-by: Eric B Munson Cc: Avi Kivity Cc: Marcelo Tosatti Cc: Jan Kiszka Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: kvm@vger.kernel.org --- Changes from V4: Test if the guest paused capability is

[PATCH 1/4 V8] Add flag to indicate that a vm was stopped by the host

2012-01-11 Thread Eric B Munson
This flag will be used to check if the vm was stopped by the host when a soft lockup was detected. The host will set the flag when it stops the guest. On resume, the guest will check this flag if a soft lockup is detected and skip issuing the warning. Signed-off-by: Eric B Munson Cc: mi

[PATCH 0/4 V8] Avoid soft lockup message when KVM is stopped by host

2012-01-11 Thread Eric B Munson
Cc: h...@zytor.com Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc: jeremy.fitzhardi...@citrix.com Cc: levinsasha...@gmail.com Cc: Jan Kiszka Cc: kvm@vger.kernel.org Cc: linux-a...@vger.kernel.org Cc: x...@kernel.org Cc: linux-ker...@vger.kernel.org Eric B Munson (4): Add fl

[PATCH 2/4 V8] Add functions to check if the host has stopped the vm

2012-01-11 Thread Eric B Munson
When a host stops or suspends a VM it will set a flag to show this. The watchdog will use these functions to determine if a softlockup is real, or the result of a suspended VM. Signed-off-by: Eric B Munson asm-generic changes Acked-by: Arnd Bergmann Cc: mi...@redhat.com Cc: h...@zytor.com Cc

[PATCH 3/4 V7] Add ioctl for KVMCLOCK_GUEST_STOPPED

2011-12-15 Thread Eric B Munson
Now that we have a flag that will tell the guest it was suspended, create an interface for that communication using a KVM ioctl. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: a...@arndb.de Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc

[PATCH 4/4 V7] Add check for suspended vm in softlockup detector

2011-12-15 Thread Eric B Munson
A suspended VM can cause spurious soft lockup warnings. To avoid these, the watchdog now checks if the kernel knows it was stopped by the host and skips the warning if so. When the watchdog is reset successfully, clear the guest paused flag. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc

[PATCH 0/4 V7] Avoid soft lockup message when KVM is stopped by host

2011-12-15 Thread Eric B Munson
hardi...@citrix.com Cc: levinsasha...@gmail.com Cc: Jan Kiszka Cc: kvm@vger.kernel.org Cc: linux-a...@vger.kernel.org Cc: x...@kernel.org Cc: linux-ker...@vger.kernel.org Eric B Munson (4): Add flag to indicate that a vm was stopped by the host Add functions to check if the host has stopped the vm

[PATCH 1/4 V7] Add flag to indicate that a vm was stopped by the host

2011-12-15 Thread Eric B Munson
This flag will be used to check if the vm was stopped by the host when a soft lockup was detected. The host will set the flag when it stops the guest. On resume, the guest will check this flag if a soft lockup is detected and skip issuing the warning. Signed-off-by: Eric B Munson Cc: mi

[PATCH 2/4 V7] Add functions to check if the host has stopped the vm

2011-12-15 Thread Eric B Munson
When a host stops or suspends a VM it will set a flag to show this. The watchdog will use these functions to determine if a softlockup is real, or the result of a suspended VM. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: a...@arndb.de Cc: ry...@linux.vnet.ibm.com Cc

Re: [PATCH 0/5 V5] Avoid soft lockup message when KVM is stopped by host

2011-12-15 Thread Eric B Munson
On Thu, 15 Dec 2011, Avi Kivity wrote: > On 12/14/2011 07:58 PM, Eric B Munson wrote: > > > I don't think you should see a guest softlockup if the host is > > > overloaded. Nor should you see it due to a long live migration pause, > > > or STOP/CONT. You sho

Re: [PATCH 0/5 V5] Avoid soft lockup message when KVM is stopped by host

2011-12-14 Thread Eric B Munson
On Wed, 14 Dec 2011, Avi Kivity wrote: > On 12/08/2011 05:19 PM, Eric B Munson wrote: > > > error compiling committee.c: too many arguments to function > > > > > My concern for preempt notifiers is masking real soft lockup warnings. If > > the > > flag is

Re: [PATCH 2/5 V5] Add functions to check if the host has stopped the vm

2011-12-14 Thread Eric B Munson
On Wed, 14 Dec 2011, Avi Kivity wrote: > On 12/14/2011 07:11 PM, Eric B Munson wrote: > > > > > > > > > > If I understand (please correct me if this is wrong) because this is > > > > > only > > > > > called from the watchdo

Re: [PATCH 2/5 V5] Add functions to check if the host has stopped the vm

2011-12-14 Thread Eric B Munson
On Wed, 14 Dec 2011, Avi Kivity wrote: > On 12/14/2011 02:11 PM, Marcelo Tosatti wrote: > > On Thu, Dec 08, 2011 at 10:23:10AM -0500, Eric B Munson wrote: > > > On Wed, 07 Dec 2011, Avi Kivity wrote: > > > > > > > On 12/05/2011 10:19 PM, Eric B Munso

Re: [PATCH 0/5 V5] Avoid soft lockup message when KVM is stopped by host

2011-12-14 Thread Eric B Munson
On Wed, 14 Dec 2011, Avi Kivity wrote: > On 12/14/2011 02:16 PM, Marcelo Tosatti wrote: > > > Having this controlled from userspace means it doesn't work for SIGSTOP > > > or for long scheduling delays. What about doing this automatically > > > based on preempt notifiers? > > > > Long scheduling

[PATCH 0/4 V6] Avoid soft lockup message when KVM is stopped by host

2011-12-08 Thread Eric B Munson
rg Cc: linux-a...@vger.kernel.org Cc: x...@kernel.org Cc: linux-ker...@vger.kernel.org Eric B Munson (4): Add flag to indicate that a vm was stopped by the host Add functions to check if the host has stopped the vm Add ioctl for KVMCLOCK_GUEST_STOPPED Add check for suspended vm in softl

[PATCH 2/4] Add functions to check if the host has stopped the vm

2011-12-08 Thread Eric B Munson
When a host stops or suspends a VM it will set a flag to show this. The watchdog will use these functions to determine if a softlockup is real, or the result of a suspended VM. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: a...@arndb.de Cc: ry...@linux.vnet.ibm.com Cc

[PATCH 3/4] Add ioctl for KVMCLOCK_GUEST_STOPPED

2011-12-08 Thread Eric B Munson
Now that we have a flag that will tell the guest it was suspended, create an interface for that communication using a KVM ioctl. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: a...@arndb.de Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc

[PATCH 4/4] Add check for suspended vm in softlockup detector

2011-12-08 Thread Eric B Munson
A suspended VM can cause spurious soft lockup warnings. To avoid these, the watchdog now checks if the kernel knows it was stopped by the host and skips the warning if so. When the watchdog is reset successfully, clear the guest paused flag. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc

[PATCH 1/4 V6] Add flag to indicate that a vm was stopped by the host

2011-12-08 Thread Eric B Munson
This flag will be used to check if the vm was stopped by the host when a soft lockup was detected. The host will set the flag when it stops the guest. On resume, the guest will check this flag if a soft lockup is detected and skip issuing the warning. Signed-off-by: Eric B Munson Cc: mi

Re: [PATCH 4/5 V5] Add generic stubs for kvm stop check functions

2011-12-08 Thread Eric B Munson
On Wed, 07 Dec 2011, Avi Kivity wrote: > On 12/05/2011 10:19 PM, Eric B Munson wrote: > > > > diff --git a/include/asm-generic/kvm_para.h b/include/asm-generic/kvm_para.h > > new file mode 100644 > > index 000..177e1eb > > --- /dev/null > > +++ b/inc

Re: [PATCH 3/5 V5] Add ioctl for KVMCLOCK_GUEST_STOPPED

2011-12-08 Thread Eric B Munson
On Wed, 07 Dec 2011, Avi Kivity wrote: > On 12/05/2011 10:19 PM, Eric B Munson wrote: > > Now that we have a flag that will tell the guest it was suspended, create an > > interface for that communication using a KVM ioctl. > > > > @@ -3295,6 +3295,10 @@ long kvm_arch_v

Re: [PATCH 2/5 V5] Add functions to check if the host has stopped the vm

2011-12-08 Thread Eric B Munson
On Wed, 07 Dec 2011, Avi Kivity wrote: > On 12/05/2011 10:19 PM, Eric B Munson wrote: > > When a host stops or suspends a VM it will set a flag to show this. The > > watchdog will use these functions to determine if a softlockup is real, or > > the > > result of a su

Re: [PATCH 0/5 V5] Avoid soft lockup message when KVM is stopped by host

2011-12-08 Thread Eric B Munson
On Wed, 07 Dec 2011, Avi Kivity wrote: > On 12/05/2011 10:18 PM, Eric B Munson wrote: > > Changes from V4: > > Rename KVM_GUEST_PAUSED to KVMCLOCK_GUEST_PAUSED > > Add description of KVMCLOCK_GUEST_PAUSED ioctl to api.txt > > > > Changes from V3: > > Incl

[PATCH 3/5 V5] Add ioctl for KVMCLOCK_GUEST_STOPPED

2011-12-05 Thread Eric B Munson
Now that we have a flag that will tell the guest it was suspended, create an interface for that communication using a KVM ioctl. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: a...@arndb.de Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc

[PATCH 4/5 V5] Add generic stubs for kvm stop check functions

2011-12-05 Thread Eric B Munson
Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: a...@arndb.de Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: mtosa...@redhat.com Cc: jeremy.fitzhardi...@citrix.com Cc: levinsasha...@gmail.com Cc: Jan Kiszka Cc: kvm@vger.kernel.org Cc: linux-a...@vger.kernel.org

[PATCH 5/5 V5] Add check for suspended vm in softlockup detector

2011-12-05 Thread Eric B Munson
A suspended VM can cause spurious soft lockup warnings. To avoid these, the watchdog now checks if the kernel knows it was stopped by the host and skips the warning if so. When the watchdog is reset successfully, clear the guest paused flag. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc

[PATCH 0/5 V5] Avoid soft lockup message when KVM is stopped by host

2011-12-05 Thread Eric B Munson
nux-a...@vger.kernel.org Cc: x...@kernel.org Cc: linux-ker...@vger.kernel.org Eric B Munson (5): Add flag to indicate that a vm was stopped by the host Add functions to check if the host has stopped the vm Add ioctl for KVMCLOCK_GUEST_STOPPED Add generic stubs for kvm stop check functions Add chec

[PATCH 2/5 V5] Add functions to check if the host has stopped the vm

2011-12-05 Thread Eric B Munson
When a host stops or suspends a VM it will set a flag to show this. The watchdog will use these functions to determine if a softlockup is real, or the result of a suspended VM. Signed-off-by: Eric B Munson Cc: mi...@redhat.com Cc: h...@zytor.com Cc: a...@arndb.de Cc: ry...@linux.vnet.ibm.com Cc

[PATCH 1/5 V5] Add flag to indicate that a vm was stopped by the host

2011-12-05 Thread Eric B Munson
This flag will be used to check if the vm was stopped by the host when a soft lockup was detected. The host will set the flag when it stops the guest. On resume, the guest will check this flag if a soft lockup is detected and skip issuing the warning. Signed-off-by: Eric B Munson Cc: mi

[PATCH V4] Guest stop notification

2011-12-05 Thread Eric B Munson
patch uses the qemu Notifier system to tell the guest it is about to be stopped. Signed-off-by: Eric B Munson Cc: Avi Kivity Cc: Marcelo Tosatti Cc: Jan Kiszka Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: kvm@vger.kernel.org --- Changes from V3: Collapse new state change notification

Re: [PATCH 3/5 V4] Add ioctl for KVM_GUEST_STOPPED

2011-12-05 Thread Eric B Munson
On Sat, 03 Dec 2011, Sasha Levin wrote: > On Tue, 2011-11-29 at 16:35 -0500, Eric B Munson wrote: > > > > Now that we have a flag that will tell the guest it was suspended, > > create an interface for that communication using a KVM ioctl. > > > > Signed-off-b

Re: [PATCH V3] Guest stop notification

2011-12-05 Thread Eric B Munson
On Sat, 03 Dec 2011, Jan Kiszka wrote: > On 2011-12-02 22:27, Eric B Munson wrote: > > On Fri, 02 Dec 2011, Jan Kiszka wrote: > > > >> On 2011-12-02 20:19, Eric B Munson wrote: > >>> Often when a guest is stopped from the qemu console, it will report > >

Re: [PATCH V3] Guest stop notification

2011-12-02 Thread Eric B Munson
On Fri, 02 Dec 2011, Jan Kiszka wrote: > On 2011-12-02 20:19, Eric B Munson wrote: > > Often when a guest is stopped from the qemu console, it will report spurious > > soft lockup warnings on resume. There are kernel patches being discussed > > that > > will give t

[PATCH V3] Guest stop notification

2011-12-02 Thread Eric B Munson
-off-by: Eric B Munson Cc: Avi Kivity Cc: Marcelo Tosatti Cc: Jan Kiszka Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: kvm@vger.kernel.org --- Changes from V2: Move ioctl into hw/kvmclock.c so as other arches can use it as it is implemented Changes from V1: Remove unnecessary

Re: [PATCH] Guest stop notification

2011-12-01 Thread Eric B Munson
On Thu, 01 Dec 2011, Marcelo Tosatti wrote: > On Thu, Dec 01, 2011 at 06:36:17PM +0100, Jan Kiszka wrote: > > On 2011-12-01 18:22, Eric B Munson wrote: > > > On Thu, 01 Dec 2011, Jan Kiszka wrote: > > > > > >> On 2011-11-29 22:36, Eric B Munson wrote: >

[PATCH V2] Guest stop notification

2011-12-01 Thread Eric B Munson
patch uses the qemu Notifier system to tell the guest it is about to be stopped. Signed-off-by: Eric B Munson Cc: Avi Kivity Cc: Marcelo Tosatti Cc: Jan Kiszka Cc: ry...@linux.vnet.ibm.com Cc: aligu...@us.ibm.com Cc: linux-ker...@vger.kernel.org Cc: kvm@vger.kernel.org --- target-i386/kvm.c |1

  1   2   >